From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Rob Clark <robdclark@gmail.com>, <igt-dev@lists.freedesktop.org>
Cc: Rob Clark <robdclark@chromium.org>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [igt-dev] [PATCH igt 1/2] tools/msm_dp_compliance: Small arg parsing cleanup
Date: Thu, 19 Oct 2023 03:40:04 -0700 [thread overview]
Message-ID: <08cbf1e8-89c7-c0cd-2928-589e624710b1@quicinc.com> (raw)
In-Reply-To: <20211208192216.743364-2-robdclark@gmail.com>
Reviving this:
On 12/8/2021 11:22 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Nit: shouldnt the patch prefix be "PATCH i-g-t" ?
We will test this out next week and land this.
> ---
> tools/msm_dp_compliance.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/msm_dp_compliance.c b/tools/msm_dp_compliance.c
> index 5e491c89..a15a8dd9 100644
> --- a/tools/msm_dp_compliance.c
> +++ b/tools/msm_dp_compliance.c
> @@ -629,7 +629,9 @@ static const char optstr[] = "hi";
> static void __attribute__((noreturn)) usage(char *name, char opt)
> {
> igt_info("usage: %s [-hi]\n", name);
> - igt_info("\t-i\tdump info\n");
> + igt_info("\t-h, --help - print this usage message");
> + igt_info("\t--help-description - print test description");
> + igt_info("\t-i, --info - dump info\n");
> igt_info("\tDefault is to respond to Qd980 tests\n");
> exit((opt != 'h') ? -1 : 0);
> }
> @@ -709,6 +711,7 @@ int main(int argc, char **argv)
> struct option long_opts[] = {
> {"help-description", 0, 0, HELP_DESCRIPTION},
> {"help", 0, 0, 'h'},
> + {"info", 0, 0, 'i'},
> };
>
> enter_exec_path(argv);
next prev parent reply other threads:[~2023-10-19 10:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 19:22 [igt-dev] [PATCH igt 0/2] tools/msm_dp_compliance: Multi-connector support Rob Clark
2021-12-08 19:22 ` [igt-dev] [PATCH igt 1/2] tools/msm_dp_compliance: Small arg parsing cleanup Rob Clark
2023-10-19 10:40 ` Abhinav Kumar [this message]
2023-10-24 8:17 ` Kamil Konieczny
2021-12-08 19:22 ` [igt-dev] [PATCH igt 2/2] tools/msm_dp_compliance: Add arg to specify connector name Rob Clark
2023-10-19 10:43 ` Abhinav Kumar
2021-12-08 19:50 ` [igt-dev] [PATCH igt 0/2] tools/msm_dp_compliance: Multi-connector support Abhinav Kumar
2021-12-08 19:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-12-09 1:41 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08cbf1e8-89c7-c0cd-2928-589e624710b1@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox