Re: [PATCH i-g-t 1/4] tools/intel_vbt_decode: sync intel_vbt_defs.h with commit 1b85a9b04681

Ville Syrjälä
2026-04-17T10:31:31Z

On Fri, Apr 17, 2026 at 11:47:14AM +0530, Nautiyal, Ankit K wrote:
>
> On 4/17/2026 11:09 AM, Karthik B S wrote:
> > Hi Ankit,
> >
> > On 4/17/2026 9:40 AM, Ankit Nautiyal wrote:
> >> Synchronize intel_vbt_defs.h with kernel commit:
> >> 1b85a9b04681 ("drm/i915/vbt: Add edp pipe joiner enable/disable bits")
> >>
> >> Bspec:20142
> >> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> >> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> >> ---
> >>   tools/intel_vbt_defs.h | 1 +
> >>   1 file changed, 1 insertion(+)
> >>
> >> diff --git a/tools/intel_vbt_defs.h b/tools/intel_vbt_defs.h
> >> index 6612d3a4ec49..550a9bfba868 100644
> >> --- a/tools/intel_vbt_defs.h
> >> +++ b/tools/intel_vbt_defs.h
> >> @@ -1090,6 +1090,7 @@ struct bdb_edp {
> >>       u16 edp_dsc_disable;                    /* 251+ */
> >>       u16 t6_delay_support;                    /* 260+ */
> >>       u16 link_idle_time[16];                    /* 260+ */
> >> +    u16 joiner_enable;                    /* 261+ */
> >
> > The variable name should be 'pipe_joiner_enable'. With this updated,
> >
> > Reviewed-by: Karthik B S <karthik.b.s@intel.com>
>
>
> Thanks Karthik, will fix this and send shortly.

How was this even different? You didn't retype these by hand into the
igt copy of the header did you? The proper procedure is to actually
copy the whole file from the kernel tree.

--
Ville Syrjälä
Intel