Re: [PATCH 00/11] tests/intel/xe_eudebug_online: add pagefault-one-of-many test

[Maciej Patelczyk <maciej.patelczyk@intel.com>]

On 28/11/2025 15:12, Andrzej Hajda wrote:

> This series adds few bitmap helpers, performs xe_eudebug_online
> file refactoring, and finally it adds pagefault-one-of-many test
> which exercises detection of GPU EU threads causing pagefault.
> xe_eudebug_online needs much more refactoring, which hopefully
> will be done later.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> Andrzej Hajda (11):
>        lib/igt_aux: add hweight helper for bitmaps
>        lib/xe/xe_query: add helpers to return count of EUs and EU threads
>        lib/gpgpu_shader: use recently introduced helper to get EU thread count
>        tests/intel/xe_eudebug_online: use igt_bitmap_hweight
>        lib/igt_aux: add fls helper for bitmaps
>        tests/intel/xe_eudebug_online: use igt_bitmap_fls to calculate max dss count
>        tests/intel/xe_eudebug_online: add fd and flags to online_debug_data
>        tests/intel/xe_eudebug_online: rename threads_count to thread_hit_count
>        tests/intel/xe_eudebug_online: use online_debug_data in get_(shader|sip)
>        tests/intel/xe_eudebug_online: cache thread count value
>        tests/intel/xe_eudebug_online: add pagefault-one-of-many test
>
>   lib/gpgpu_shader.c                                |   5 +-
>   lib/igt_aux.c                                     |  48 +++
>   lib/igt_aux.h                                     |   3 +
>   lib/meson.build                                   |   2 +-
>   lib/xe/xe_query.c                                 |  57 ++++
>   lib/xe/xe_query.h                                 |   3 +
>   tests/intel/xe_eudebug_online.c                   | 353 ++++++++++++++--------
>   tests/intel/xe_eudebug_online.c.gen.iga64_codes.c |  43 +++
>   8 files changed, 391 insertions(+), 123 deletions(-)
> ---
> base-commit: 005281c52252a2b3790b186bf95c6cb378f9a609
> change-id: 20251126-pagefault-one-of-many-30a877d95441
>
> Best regards,
> --
> Andrzej Hajda <andrzej.hajda@intel.com>
>
This looks good.

Nice reworks which shall be continued especially for xe_eudebug_online.

Last patch a bit complicated as it is for pagefaults.

Thanks Andrzej!

Reviewed-by: Maciej Patelczyk <maciej.patelczyk@intel.com>