public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Nitin Gote <nitin.r.gote@intel.com>,
	igt-dev@lists.freedesktop.org, michal.wajdeczko@intel.com,
	Lukasz Laguna <lukasz.laguna@intel.com>
Subject: Re: [PATCH] tests/intel/xe_configfs: Skip ctx-restore subtests on SR-IOV VF
Date: Thu, 5 Mar 2026 17:21:21 +0100	[thread overview]
Message-ID: <09f01ecd-46dd-4712-90e7-a51aea8cd219@linux.intel.com> (raw)
In-Reply-To: <20260224132012.prlzw36las3j4uzk@kamilkon-DESK.igk.intel.com>


On 2/24/2026 2:20 PM, Kamil Konieczny wrote:
> Hi Nitin,
> On 2026-02-24 at 16:50:42 +0530, Nitin Gote wrote:
>> The ctx-restore subtests use intel_register_read() via direct MMIO
>> (PCI BAR) access to verify that the batch buffer wrote the expected
>> register values. On SR-IOV Virtual Functions (VF), only a very limited
>> subset of registers is accessible. Registers like 0x4F100 are not
>> exposed to VFs, so the read always returns 0, causing a false test
>> failure.
>>
>> Skip all ctx-restore subtests (post-bb, mid-bb, and their invalid
>> variants) when the device is running in SR-IOV VF mode.
Does it mean the feature is not applicable to VFs or just the 
verification is a bit harder ?
> +cc Lukasz and Marcin
>
>> Signed-off-by: Nitin Gote <nitin.r.gote@intel.com>
>> ---
>>   tests/intel/xe_configfs.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/tests/intel/xe_configfs.c b/tests/intel/xe_configfs.c
>> index 0db4af201..ab55e333b 100644
>> --- a/tests/intel/xe_configfs.c
>> +++ b/tests/intel/xe_configfs.c
>> @@ -409,6 +409,7 @@ int igt_main()
>>   
>>   	igt_describe("Validate ctx_restore_post_bb with invalid options");
>>   	igt_subtest("ctx-restore-post-bb-invalid") {
>> +		igt_require_f(!is_vf_device, "ctx-restore not supported in VF\n");
>>   		configfs_device_fd = create_device_configfs_group(configfs_fd);
>>   		test_ctx_restore_invalid(configfs_device_fd, "post");
>>   		close_configfs_group(configfs_fd, configfs_device_fd);
>> @@ -416,6 +417,7 @@ int igt_main()
>>   
>>   	igt_describe("Validate ctx_restore_post_bb");
>>   	igt_subtest("ctx-restore-post-bb") {
>> +		igt_require_f(!is_vf_device, "ctx-restore not supported in VF\n");
>>   		configfs_device_fd = create_device_configfs_group(configfs_fd);
>>   		test_ctx_restore(configfs_device_fd, "post");
>>   		close_configfs_group(configfs_fd, configfs_device_fd);
>> @@ -423,6 +425,7 @@ int igt_main()
>>   
>>   	igt_describe("Validate ctx_restore_mid_bb with invalid options");
>>   	igt_subtest("ctx-restore-mid-bb-invalid") {
>> +		igt_require_f(!is_vf_device, "ctx-restore not supported in VF\n");
>>   		configfs_device_fd = create_device_configfs_group(configfs_fd);
>>   		test_ctx_restore_invalid(configfs_device_fd, "mid");
>>   		close_configfs_group(configfs_fd, configfs_device_fd);
>> @@ -430,6 +433,7 @@ int igt_main()
>>   
>>   	igt_describe("Validate ctx_restore_mid_bb");
>>   	igt_subtest("ctx-restore-mid-bb") {
>> +		igt_require_f(!is_vf_device, "ctx-restore not supported in VF\n");
>>   		configfs_device_fd = create_device_configfs_group(configfs_fd);
>>   		test_ctx_restore(configfs_device_fd, "mid");
>>   		close_configfs_group(configfs_fd, configfs_device_fd);
>> -- 
>> 2.50.1
>>

  reply	other threads:[~2026-03-05 16:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 11:20 [PATCH] tests/intel/xe_configfs: Skip ctx-restore subtests on SR-IOV VF Nitin Gote
2026-02-24 13:15 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-02-24 13:20 ` [PATCH] " Kamil Konieczny
2026-03-05 16:21   ` Bernatowicz, Marcin [this message]
2026-03-10  4:37     ` Gote, Nitin R
2026-03-16  9:10       ` Bernatowicz, Marcin
2026-02-24 13:38 ` ✓ i915.CI.BAT: success for " Patchwork
2026-02-24 19:50 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-24 23:40 ` ✗ Xe.CI.FULL: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-03-16 10:31 [PATCH] " Nitin Gote

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09f01ecd-46dd-4712-90e7-a51aea8cd219@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=lukasz.laguna@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=nitin.r.gote@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox