Re: [PATCH i-g-t] tests/intel/i915_pm_rps: Disable subtest thresholds-park when SLPC is enabled

[Riana Tauro <riana.tauro@intel.com>]

Hi Anirban

On 7/24/2024 6:19 PM, sk.anirban@intel.com wrote:
> From: Sk Anirban <sk.anirban@intel.com>
> 
> Skip the test when SLPC is enabled as it fails frequently.
Provide reason for failure.
> 
> Bug: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11455
closes?
> 
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>   tests/intel/i915_pm_rps.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/i915_pm_rps.c b/tests/intel/i915_pm_rps.c
> index 99b83f315..e1489b446 100644
> --- a/tests/intel/i915_pm_rps.c
> +++ b/tests/intel/i915_pm_rps.c
> @@ -1179,7 +1179,8 @@ igt_main
>   
>   	igt_subtest_with_dynamic("thresholds-park") {
>   		int tmp, gt;
> -
> +		igt_skip_on_f(i915_is_slpc_enabled(drm_fd),
> +			      "This subtest is not supported when SLPC is enabled\n");
Don't we need this for all threshold tests?

Thanks,
Riana
>   		i915_for_each_gt(drm_fd, tmp, gt) {
>   			igt_dynamic_f("gt%u", gt)
>   				test_thresholds(drm_fd, gt, TEST_PARK);