From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20191001174924.20227-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Message-ID: <0ae718ca-00f1-8ed5-6a46-c2142f84693e@linux.intel.com> Date: Wed, 2 Oct 2019 09:42:01 +0100 MIME-Version: 1.0 In-Reply-To: <20191001174924.20227-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_userptr_blits: Check for allowed GTT mmaps List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org, Tvrtko Ursulin List-ID: Ck9uIDAxLzEwLzIwMTkgMTg6NDksIENocmlzIFdpbHNvbiB3cm90ZToKPiBIYXZpbmcgZGVjaWRl ZCB0byBjbG9zZSB0aGUgR1RUIG1tYXAgb2YgdXNlcnB0ciBvYmplY3RzIGxvb3Bob2xlIGluIHRo ZQo+IGtlcm5lbCwgd2UgbmVlZCB0byBhZGp1c3QgdGhlIHRlc3Qgc3VpdGUgdG8gYXZvaWQgdHJp cHBpbmcgb3ZlciBHVFQKPiBtbWFwcyB3aGVuIHJlcXVpcmVkLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IC0tLQo+ICAgdGVzdHMvaTkxNS9nZW1f dXNlcnB0cl9ibGl0cy5jIHwgMzIgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiAg IDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS90ZXN0cy9pOTE1L2dlbV91c2VycHRyX2JsaXRzLmMgYi90ZXN0cy9pOTE1L2dl bV91c2VycHRyX2JsaXRzLmMKPiBpbmRleCAzZmFkN2QxYjMuLjNmNWVkYWVhYiAxMDA2NDQKPiAt LS0gYS90ZXN0cy9pOTE1L2dlbV91c2VycHRyX2JsaXRzLmMKPiArKysgYi90ZXN0cy9pOTE1L2dl bV91c2VycHRyX2JsaXRzLmMKPiBAQCAtNjksMTEgKzY5LDMzIEBACj4gICAKPiAgIHN0YXRpYyB1 aW50MzJfdCB1c2VycHRyX2ZsYWdzID0gTE9DQUxfSTkxNV9VU0VSUFRSX1VOU1lOQ0hST05JWkVE Owo+ICAgCj4gK3N0YXRpYyBib29sIGNhbl9ndHRfbW1hcDsKPiArCj4gICAjZGVmaW5lIFdJRFRI IDUxMgo+ICAgI2RlZmluZSBIRUlHSFQgNTEyCj4gICAKPiAgIHN0YXRpYyB1aW50MzJfdCBsaW5l YXJbV0lEVEgqSEVJR0hUXTsKPiAgIAo+ICtzdGF0aWMgYm9vbCBoYXNfZ3R0X21tYXAoaW50IGk5 MTUpCj4gK3sKPiArCXZvaWQgKnB0ciwgKm1hcDsKPiArCXVpbnQzMl90IGhhbmRsZTsKPiArCj4g KwlpZ3RfYXNzZXJ0KHBvc2l4X21lbWFsaWduKCZwdHIsIFBBR0VfU0laRSwgUEFHRV9TSVpFKSA9 PSAwKTsKPiArCj4gKwlnZW1fdXNlcnB0cihpOTE1LCBwdHIsIDQwOTYsIDAsIDAsICZoYW5kbGUp Owo+ICsJaWd0X2Fzc2VydChoYW5kbGUgIT0gMCk7Cj4gKwo+ICsJbWFwID0gX19nZW1fbW1hcF9f Z3R0KGk5MTUsIGhhbmRsZSwgNDA5NiwgUFJPVF9XUklURSk7Cj4gKwlpZiAobWFwKQo+ICsJCW11 bm1hcChtYXAsIDQwOTYpOwo+ICsKPiArCWdlbV9jbG9zZShpOTE1LCBoYW5kbGUpOwo+ICsJZnJl ZShwdHIpOwo+ICsKPiArCXJldHVybiBtYXAgIT0gTlVMTDsKPiArfQo+ICsKPiAgIHN0YXRpYyB2 b2lkIGdlbV91c2VycHRyX3Rlc3RfdW5zeW5jaHJvbml6ZWQodm9pZCkKPiAgIHsKPiAgIAl1c2Vy cHRyX2ZsYWdzID0gTE9DQUxfSTkxNV9VU0VSUFRSX1VOU1lOQ0hST05JWkVEOwo+IEBAIC04NTMs NyArODc1LDcgQEAgc3RhdGljIHZvaWQgKnVtYXAoaW50IGZkLCB1aW50MzJfdCBoYW5kbGUpCj4g ICB7Cj4gICAJdm9pZCAqcHRyOwo+ICAgCj4gLQlpZiAoZ2VtX2hhc19sbGMoZmQpKSB7Cj4gKwlp ZiAoY2FuX2d0dF9tbWFwKSB7Cj4gICAJCXB0ciA9IGdlbV9tbWFwX19ndHQoZmQsIGhhbmRsZSwg c2l6ZW9mKGxpbmVhciksCj4gICAJCQkJICAgIFBST1RfUkVBRCB8IFBST1RfV1JJVEUpOwo+ICAg CX0gZWxzZSB7Cj4gQEAgLTg4NCw3ICs5MDYsNyBAQCBjaGVja19ibyhpbnQgZmQxLCB1aW50MzJf dCBoYW5kbGUxLCBpbnQgaXNfdXNlcnB0ciwgaW50IGZkMiwgdWludDMyX3QgaGFuZGxlMikKPiAg IAlzaWdidXNfc3RhcnQgPSAodW5zaWduZWQgbG9uZylwdHIyOwo+ICAgCWlndF9hc3NlcnQobWVt Y21wKHB0cjEsIHB0cjIsIHNpemVvZihsaW5lYXIpKSA9PSAwKTsKPiAgIAo+IC0JaWYgKGdlbV9o YXNfbGxjKGZkMSkpIHsKPiArCWlmIChjYW5fZ3R0X21tYXApIHsKPiAgIAkJY291bnRlcisrOwo+ ICAgCQltZW1zZXQocHRyMSwgY291bnRlciwgc2l6ZSk7Cj4gICAJCW1lbXNldChwdHIyLCBjb3Vu dGVyLCBzaXplKTsKPiBAQCAtOTcxLDcgKzk5Myw3IEBAIHN0YXRpYyBpbnQgdGVzdF9kbWFidWYo dm9pZCkKPiAgIAlmcmVlX3VzZXJwdHJfYm8oZmQxLCBoYW5kbGUpOwo+ICAgCWNsb3NlKGZkMSk7 Cj4gICAKPiAtCWlmIChnZW1faGFzX2xsYyhmZDIpKSB7Cj4gKwlpZiAoY2FuX2d0dF9tbWFwKSB7 CgpLdWRvcyB0byBteXNlbGYgSSB0aGluayBmb3IgY29taW5nIHVwIHdpdGggdGhpcyBjb252b2x1 dGVkIHRlc3Qgd2hpY2ggSSAKbmVlZGVkIDE1IG1pbnV0ZXMgdG8gcmV2ZXJzZSBlbmdpbmVlci4g OikgT2theSBpdCB3YXMgbWFueSB5ZWFycyBhZ28gc28gCnRoYXQncyBteSBleGN1c2UuIEluIGFs bCBjYXNlcyBtbWFwX19ndHQgaXMgZWl0aGVyIG9uIHVzZXJwdHIgb3Igb24gCmRtYWJ1ZiBpbXBv cnQgb2YgdXNlcnB0ciBzbyBJIHRoaW5rIGl0J3MgY29ycmVjdC4KCj4gICAJCXN0cnVjdCBzaWdh Y3Rpb24gc2lnYWN0LCBvcmlnX3NpZ2FjdDsKPiAgIAo+ICAgCQltZW1zZXQoJnNpZ2FjdCwgMCwg c2l6ZW9mKHNpZ2FjdCkpOwo+IEBAIC0xMjI1LDcgKzEyNDcsNyBAQCBzdGF0aWMgdm9pZCB0ZXN0 X3JlYWRvbmx5X21tYXAoaW50IGk5MTUpCj4gICAJb3JpZ2luYWwgPSBnX2NvbXB1dGVfY2hlY2tz dW1fZm9yX2RhdGEoR19DSEVDS1NVTV9TSEExLCBwYWdlcywgc3opOwo+ICAgCj4gICAJcHRyID0g X19nZW1fbW1hcF9fZ3R0KGk5MTUsIGhhbmRsZSwgc3osIFBST1RfV1JJVEUpOwo+IC0JaWd0X2Fz c2VydChwdHIgPT0gTlVMTCk7Cj4gKwlpZ3RfcmVxdWlyZShwdHIgIT0gTlVMTCk7CgpUaGlzIHNo b3VsZCBiZSBhYmxlIHRvIHN0YXkgdW5jaGFuZ2VkLCBubz8gV2hldGhlciByZWFkLW9ubHkgb3Ig bW1hcF9ndHQgCmlzIGRpc2FsbG93ZWQgaXQgbXVzdCBhbHdheXMgYmUgTlVMTCBoZXJlLiBOb24t TlVMTCBzaG91bGQgYmUgdGVzdCBmYWlsLgoKPiAgIAo+ICAgCXB0ciA9IGdlbV9tbWFwX19ndHQo aTkxNSwgaGFuZGxlLCBzeiwgUFJPVF9SRUFEKTsKPiAgIAlnZW1fY2xvc2UoaTkxNSwgaGFuZGxl KTsKPiBAQCAtMTgzNCw2ICsxODU2LDggQEAgaWd0X21haW5fYXJncygiYzoiLCBOVUxMLCBoZWxw X3N0ciwgb3B0X2hhbmRsZXIsIE5VTEwpCj4gICAJCWlndF9yZXF1aXJlX2dlbShmZCk7Cj4gICAJ CWdlbV9yZXF1aXJlX2JsaXR0ZXIoZmQpOwo+ICAgCj4gKwkJY2FuX2d0dF9tbWFwID0gaGFzX2d0 dF9tbWFwKGZkKSAmJiBnZW1faGFzX2xsYyhmZCk7Cj4gKwo+ICAgCQlzaXplID0gc2l6ZW9mKGxp bmVhcik7Cj4gICAKPiAgIAkJYXBlcnR1cmVfc2l6ZSA9IGdlbV9hcGVydHVyZV9zaXplKGZkKTsK PiAKClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3Qt ZGV2