From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F00010E4A3 for ; Wed, 9 Aug 2023 20:09:23 +0000 (UTC) Message-ID: <0b3a6511-d7e2-c7b8-f758-a0599c947734@intel.com> Date: Thu, 10 Aug 2023 01:38:43 +0530 MIME-Version: 1.0 Content-Language: en-US To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org References: <20230629144910.3055377-37-bhanuprakash.modem@intel.com> From: "Gupta, Nidhi1" In-Reply-To: <20230629144910.3055377-37-bhanuprakash.modem@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [V5, i-g-t, 36/81] tests/kms_atomic_transition: Document each subtest for testplan List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: LGTM Reviewed-by: Nidhi Gupta On 6/29/2023 8:18 PM, Bhanuprakash Modem wrote: > Add documentation for all kms tests which is used by IGT testplan > documentation. > > Signed-off-by: Bhanuprakash Modem > --- > tests/kms_atomic_transition.c | 100 ++++++++++++++++++++++++++++++++++ > 1 file changed, 100 insertions(+) > > diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c > index 6ab5267ca..196736df2 100644 > --- a/tests/kms_atomic_transition.c > +++ b/tests/kms_atomic_transition.c > @@ -21,6 +21,10 @@ > * IN THE SOFTWARE. > */ > > +/** > + * TEST: kms atomic transition > + * Category: Display > + */ > #include "igt.h" > #include "igt_rand.h" > #include "drmtest.h" > @@ -58,6 +62,15 @@ int *timeline; > pthread_t *thread; > int *seqno; > > +/** > + * SUBTEST: plane-primary-toggle-with-vblank-wait > + * Description: Check toggling of primary plane with vblank > + * Driver requirement: any > + * Functionality: watermark > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + */ > static void > run_primary_test(data_t *data, enum pipe pipe, igt_output_t *output) > { > @@ -470,6 +483,77 @@ static void wait_for_transition(data_t *data, enum pipe pipe, bool nonblocking, > } > } > > +/** > + * SUBTEST: plane-all-modeset-%s > + * Description: Modeset test for all plane combinations %arg[1] > + * Driver requirement: any > + * Functionality: watermark > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @transition: default > + * @transition-fencing: with fencing commit > + */ > + > +/** > + * SUBTEST: plane-all-modeset-%s > + * Description: Modeset test for all plane combinations %arg[1] > + * Driver requirement: any > + * Functionality: watermark > + * Mega feature: eDP > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @transition-fencing-internal-panels: on internal panels with fencing commit > + * @transition-internal-panels: on internal panels > + */ > + > +/** > + * SUBTEST: plane-all-%s > + * Description: Transition test for all plane combinations %arg[1] > + * Driver requirement: any > + * Functionality: watermark > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @transition: default > + * @transition-fencing: with fencing commit > + * @transition-nonblocking: with non-blocking commit > + * @transition-nonblocking-fencing: with non-blocking & fencing commit > + */ > + > +/** > + * SUBTEST: plane-toggle-modeset-transition > + * Description: Check toggling and modeset transition on plane > + * Driver requirement: any > + * Functionality: watermark > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * SUBTEST: plane-use-after-nonblocking-%s > + * Description: Transition test with non %arg[1] and make sure commit of disabled > + * plane has to complete before atomic commit on that plane > + * Driver requirement: any > + * Functionality: watermark > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @unbind: blocking commit > + * @unbind-fencing: blocking commit with fencing > + */ > + > /* > * 1. Set primary plane to a known fb. > * 2. Make sure getcrtc returns the correct fb id. > @@ -959,6 +1043,22 @@ retry: > } > } > > +/** > + * SUBTEST: modeset-%s > + * Description: Modeset transition tests for combinations of %arg[1] > + * Driver requirement: any > + * Functionality: watermark > + * Mega feature: General Display Features > + * Run type: FULL > + * Test category: functionality test > + * > + * arg[1]: > + * > + * @transition: crtc enabled > + * @transition-fencing: crtc enabled with fencing commit > + * @transition-nonblocking: crtc enabled with nonblocking commit > + * @transition-nonblocking-fencing: crtc enabled with nonblocking & fencing commit > + */ > static void run_modeset_transition(data_t *data, int requested_outputs, bool nonblocking, bool fencing) > { > igt_output_t *outputs[IGT_MAX_PIPES] = {}; -- ~Nidhi Gupta