From: Tomi Sarvela <tomi.p.sarvela@intel.com>
To: Petri Latvala <petri.latvala@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] intel-ci: Relegate gem_exec_reloc to the shards
Date: Fri, 1 Nov 2019 14:58:16 +0200 [thread overview]
Message-ID: <0b7bb816-6074-79df-eb77-af14cb6dcfd8@intel.com> (raw)
In-Reply-To: <20191101112123.GK25209@platvala-desk.ger.corp.intel.com>
On 11/1/19 1:21 PM, Petri Latvala wrote:
> On Fri, Nov 01, 2019 at 10:56:37AM +0000, Chris Wilson wrote:
>> Quoting Chris Wilson (2019-11-01 10:51:06)
>>> The gem_exec_reloc basic subtests cover a couple dozen basic ABI
>>> sanitychecks, aiming to prove the ABI works. While relocations used to
>>> be essential, they are no longer the basis of current clients who all
>>> softpin. It is a stagnant portion of the ABI that does not contribute
>>> much to overall driver health (the complicated portions of relocs are
>>> covered in the smoketests like gem_exec_parallel and gem_exec_gttfill).
>>> However, even though each of the basic subtest is trivial and runs in
>>> very little time, since CI is running each individually the time between
>>> tests mounts up (especially on eMMC devices like fi-kbl-soraka).
>>>
>>> By moving these tests to the shards we should speed up BAT on the
>>> ratelimiting fi-kbl-soraka, while losing no coverage overall -- and
>>> hopefully without losing any of the predictive failure coverage in BAT.
>>> This stagnant bit of uAPI/uABI will remain checked by the irregular idle
>>> runs.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
>>> Cc: Petri Latvala <petri.latvala@intel.com>
>>> Cc: Martin Peres <martin.peres@linux.intel.com>
>>
>> Before Joonas went fishing, he gave +1. So,
>> Acked-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>>
>> Tomi, Petri, Martin any objections?
>> -Chris
>
> Acked-by: Petri Latvala <petri.latvala@intel.com>
Looks reasonable, and I like it.
Acked-by: Tomi Sarvela <tomi.p.sarvela@intel.com>
--
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-11-01 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 10:51 [igt-dev] [PATCH i-g-t] intel-ci: Relegate gem_exec_reloc to the shards Chris Wilson
2019-11-01 10:56 ` [Intel-gfx] " Chris Wilson
2019-11-01 11:21 ` [igt-dev] " Petri Latvala
2019-11-01 12:58 ` Tomi Sarvela [this message]
2019-11-01 12:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-11-02 19:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b7bb816-6074-79df-eb77-af14cb6dcfd8@intel.com \
--to=tomi.p.sarvela@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox