From: Martin Peres <martin.peres@linux.intel.com>
To: Simon Ser <simon.ser@intel.com>, igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_chamelium: drop TEST_EDID_CHAMELIUM_DEFAULT
Date: Mon, 17 Jun 2019 10:17:18 +0300 [thread overview]
Message-ID: <0c95e129-a35b-f995-ded0-6ceaa513e337@linux.intel.com> (raw)
In-Reply-To: <20190614142203.7753-2-simon.ser@intel.com>
On 14/06/2019 17:22, Simon Ser wrote:
> We don't use the default Chamelium EDID anymore in Chamelium tests. We can drop
> it.
>
> Signed-off-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
> ---
> tests/kms_chamelium.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
> index 36e92e975d64..03ebbd9c4b20 100644
> --- a/tests/kms_chamelium.c
> +++ b/tests/kms_chamelium.c
> @@ -36,13 +36,12 @@
> #include <stdatomic.h>
>
> enum test_edid {
> - TEST_EDID_CHAMELIUM_DEFAULT,
> TEST_EDID_BASE,
> TEST_EDID_ALT,
> TEST_EDID_HDMI_AUDIO,
> TEST_EDID_DP_AUDIO,
> };
> -#define TEST_EDID_COUNT 5
> +#define TEST_EDID_COUNT 4
>
> typedef struct {
> struct chamelium *chamelium;
> @@ -2045,9 +2044,6 @@ test_hpd_storm_disable(data_t *data, struct chamelium_port *port, int width)
> static const unsigned char *get_edid(enum test_edid edid)
> {
> switch (edid) {
> - case TEST_EDID_CHAMELIUM_DEFAULT:
> - igt_assert(0); /* we don't have the raw data for this one */
> - return NULL;
> case TEST_EDID_BASE:
> return igt_kms_get_base_edid();
> case TEST_EDID_ALT:
> @@ -2089,8 +2085,7 @@ igt_main
> data.ports = chamelium_get_ports(data.chamelium,
> &data.port_count);
>
> - data.edids[TEST_EDID_CHAMELIUM_DEFAULT] = CHAMELIUM_DEFAULT_EDID;
> - for (i = 1; i < TEST_EDID_COUNT; ++i) {
> + for (i = 0; i < TEST_EDID_COUNT; ++i) {
> data.edids[i] = chamelium_new_edid(data.chamelium,
> get_edid(i));
> }
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-17 7:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 14:22 [igt-dev] [PATCH i-g-t 0/3] Preliminary work for automagical Chamelium port mapping Simon Ser
2019-06-14 14:22 ` [igt-dev] [PATCH i-g-t 1/3] tests/kms_chamelium: drop TEST_EDID_CHAMELIUM_DEFAULT Simon Ser
2019-06-17 7:17 ` Martin Peres [this message]
2019-06-14 14:22 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_chamelium: fix EDID list Simon Ser
2019-06-17 10:57 ` Arkadiusz Hiler
2019-06-14 14:22 ` [igt-dev] [PATCH i-g-t 3/3] lib/igt_chamelium: replace EDID IDs with opaque structs Simon Ser
2019-06-17 7:21 ` Martin Peres
2019-06-15 2:56 ` [igt-dev] ✓ Fi.CI.BAT: success for Preliminary work for automagical Chamelium port mapping Patchwork
2019-06-15 20:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c95e129-a35b-f995-ded0-6ceaa513e337@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox