From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id B628489127 for ; Tue, 2 Apr 2019 23:01:10 +0000 (UTC) Message-ID: <0caf155a763d28347f1af31733b4259a5527b8df.camel@intel.com> From: Dhinakaran Pandiyan Date: Tue, 02 Apr 2019 16:01:09 -0700 In-Reply-To: <20190328175450.8370-2-ville.syrjala@linux.intel.com> References: <20190328175450.8370-1-ville.syrjala@linux.intel.com> <20190328175450.8370-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_fb: Don't leak the bufmgr and batch for converted surfaces List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dhinakaran.pandiyan@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCAyMDE5LTAzLTI4IGF0IDE5OjU0ICswMjAwLCBWaWxsZSBTeXJqYWxhIHdyb3RlOgo+ IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g Cj4gUmVtZW1iZXIgdG8gZnJlZSB0aGUgYnVmbWdyIGFuZCBiYXRjaCBhZnRlciB0aGUgY29udmVy dCBzdXJmYWNlIGlzCj4gZGVzdHJveWVkLiBXZSdsbCBkbyB0aGF0IGJ5IHN1Y2tpbmcgdGhlIHJl bGV2YW50IGNvZGUgaW50bwo+IGZyZWVfbGluZWFyX21hcHBpbmcoKSwgYW5kIGZvciB0aGUgc2Fr ZSBvZiBzeW1tZXRyeSB3ZSdsbCBtb3ZlCj4gdGhlIHNldHVwIGNvZGUgaW50byBzZXR1cF9saW5l YXJfbWFwcGluZygpLgo+IAo+IENjOiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBh bmRpeWFuQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGlu YWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KCgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIu YyB8IDI0ICsrKysrKysrKysrLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5z ZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIu YyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDhiNmFkZjU1YTMzOC4uOTk3NjZkMmQwOGY5IDEwMDY0 NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3RfZmIuYwo+IEBAIC0xNjA0LDYg KzE2MDQsMTEgQEAgc3RhdGljIHZvaWQgZnJlZV9saW5lYXJfbWFwcGluZyhzdHJ1Y3QgZmJfYmxp dF91cGxvYWQKPiAqYmxpdCkKPiAgCj4gIAlnZW1fc3luYyhmZCwgbGluZWFyLT5mYi5nZW1faGFu ZGxlKTsKPiAgCWdlbV9jbG9zZShmZCwgbGluZWFyLT5mYi5nZW1faGFuZGxlKTsKPiArCj4gKwlp ZiAoYmxpdC0+YmF0Y2gpIHsKPiArCQlpbnRlbF9iYXRjaGJ1ZmZlcl9mcmVlKGJsaXQtPmJhdGNo KTsKPiArCQlkcm1faW50ZWxfYnVmbWdyX2Rlc3Ryb3koYmxpdC0+YnVmbWdyKTsKPiArCX0KPiAg fQo+ICAKPiAgc3RhdGljIHZvaWQgZGVzdHJveV9jYWlyb19zdXJmYWNlX19ibGl0KHZvaWQgKmFy ZykKPiBAQCAtMTYyNSw5ICsxNjMwLDYgQEAgc3RhdGljIHZvaWQgZGVzdHJveV9jYWlyb19zdXJm YWNlX19yZW5kZXJjb3B5KHZvaWQgKmFyZykKPiAgCj4gIAlmcmVlX2xpbmVhcl9tYXBwaW5nKGJs aXQpOwo+ICAKPiAtCWludGVsX2JhdGNoYnVmZmVyX2ZyZWUoYmxpdC0+YmF0Y2gpOwo+IC0JZHJt X2ludGVsX2J1Zm1ncl9kZXN0cm95KGJsaXQtPmJ1Zm1ncik7Cj4gLQo+ICAJZnJlZShibGl0KTsK PiAgfQo+ICAKPiBAQCAtMTYzNyw2ICsxNjM5LDEyIEBAIHN0YXRpYyB2b2lkIHNldHVwX2xpbmVh cl9tYXBwaW5nKHN0cnVjdCBmYl9ibGl0X3VwbG9hZAo+ICpibGl0KQo+ICAJc3RydWN0IGlndF9m YiAqZmIgPSBibGl0LT5mYjsKPiAgCXN0cnVjdCBmYl9ibGl0X2xpbmVhciAqbGluZWFyID0gJmJs aXQtPmxpbmVhcjsKPiAgCj4gKwlpZiAodXNlX3JlbmRlcmNvcHkoZmIpKSB7Cj4gKwkJYmxpdC0+ YnVmbWdyID0gZHJtX2ludGVsX2J1Zm1ncl9nZW1faW5pdChmZCwgNDA5Nik7Cj4gKwkJYmxpdC0+ YmF0Y2ggPSBpbnRlbF9iYXRjaGJ1ZmZlcl9hbGxvYyhibGl0LT5idWZtZ3IsCj4gKwkJCQkJCSAg ICAgIGludGVsX2dldF9kcm1fZGV2aWQoZmQpKTsKPiArCX0KPiArCj4gIAkvKgo+ICAJICogV2Ug Y3JlYXRlIGEgbGluZWFyIEJPIHRoYXQgd2UnbGwgbWFwIGZvciB0aGUgQ1BVIHRvIHdyaXRlIHRv ICh1c2luZwo+ICAJICogY2Fpcm8pLiBUaGlzIGxpbmVhciBibyB3aWxsIGJlIHRoZW4gYmxpdHRl ZCB0byBpdHMgZmluYWwKPiBAQCAtMTcwNiwxMCArMTcxNCw2IEBAIHN0YXRpYyB2b2lkIGNyZWF0 ZV9jYWlyb19zdXJmYWNlX19yZW5kZXJjb3B5KGludCBmZCwKPiBzdHJ1Y3QgaWd0X2ZiICpmYikK PiAgCWJsaXQtPmZkID0gZmQ7Cj4gIAlibGl0LT5mYiA9IGZiOwo+ICAKPiAtCWJsaXQtPmJ1Zm1n ciA9IGRybV9pbnRlbF9idWZtZ3JfZ2VtX2luaXQoZmQsIDQwOTYpOwo+IC0JYmxpdC0+YmF0Y2gg PSBpbnRlbF9iYXRjaGJ1ZmZlcl9hbGxvYyhibGl0LT5idWZtZ3IsCj4gLQkJCQkJICAgICAgaW50 ZWxfZ2V0X2RybV9kZXZpZChmZCkpOwo+IC0KPiAgCXNldHVwX2xpbmVhcl9tYXBwaW5nKGJsaXQp Owo+ICAKPiAgCWNhaXJvX2Zvcm1hdCA9IGRybV9mb3JtYXRfdG9fY2Fpcm8oZmItPmRybV9mb3Jt YXQpOwo+IEBAIC0yNTI1LDEyICsyNTI5LDYgQEAgc3RhdGljIHZvaWQgY3JlYXRlX2NhaXJvX3N1 cmZhY2VfX2NvbnZlcnQoaW50IGZkLAo+IHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICAJYmxpdC0+YmFz ZS5mZCA9IGZkOwo+ICAJYmxpdC0+YmFzZS5mYiA9IGZiOwo+ICAKPiAtCWlmICh1c2VfcmVuZGVy Y29weShmYikpIHsKPiAtCQlibGl0LT5iYXNlLmJ1Zm1nciA9IGRybV9pbnRlbF9idWZtZ3JfZ2Vt X2luaXQoZmQsIDQwOTYpOwo+IC0JCWJsaXQtPmJhc2UuYmF0Y2ggPSBpbnRlbF9iYXRjaGJ1ZmZl cl9hbGxvYyhibGl0LT5iYXNlLmJ1Zm1nciwKPiAtCQkJCQkJICAgaW50ZWxfZ2V0X2RybV9kZXZp ZChmZCkpOwo+IC0JfQo+IC0KPiAgCWJsaXQtPnNoYWRvd19wdHIgPSBpZ3RfZmJfY3JlYXRlX2Nh aXJvX3NoYWRvd19idWZmZXIoZmQsIGRybV9mb3JtYXQsCj4gIAkJCQkJCQkgICAgIGZiLT53aWR0 aCwKPiAgCQkJCQkJCSAgICAgZmItPmhlaWdodCwKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaWd0LWRldg==