From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D265610E09B
 for <igt-dev@lists.freedesktop.org>; Wed, 26 Apr 2023 06:21:15 +0000 (UTC)
Message-ID: <0cfbb508-2c39-25b1-5be8-4b0ead204a20@intel.com>
Date: Wed, 26 Apr 2023 11:51:11 +0530
MIME-Version: 1.0
Content-Language: en-US
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
 igt-dev@lists.freedesktop.org
References: <20230425064953.2121947-1-bhanuprakash.modem@intel.com>
 <20230425064953.2121947-25-bhanuprakash.modem@intel.com>
From: "Sharma, Swati2" <swati2.sharma@intel.com>
In-Reply-To: <20230425064953.2121947-25-bhanuprakash.modem@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [igt-dev] [i-g-t V2 24/40] tests/kms_atomic_transition: Add XE
 support
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 25-Apr-23 12:19 PM, Bhanuprakash Modem wrote:
> Add XE driver support for kms tests.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/kms_atomic_transition.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 7c7be578c..9f39d033d 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -136,7 +136,7 @@ static bool skip_plane(data_t *data, igt_plane_t *plane)
>   	if (data->extended)
>   		return false;
>   
> -	if (!is_i915_device(data->drm_fd))
> +	if (!is_intel_device(data->drm_fd))
>   		return false;
>   
>   	if (plane->type == DRM_PLANE_TYPE_CURSOR)
> @@ -848,7 +848,7 @@ retry:
>   		/* count enable pipes to set max iteration */
>   		j += 1;
>   
> -		if (is_i915_device(data->drm_fd))
> +		if (is_intel_device(data->drm_fd))
>   			data->pipe_crcs[i] = igt_pipe_crc_new(data->drm_fd, i,
>   							      IGT_PIPE_CRC_SOURCE_AUTO);
>   
> @@ -943,7 +943,7 @@ retry:
>   			commit_display(data, i, nonblocking);
>   			collect_crcs_mask(data->pipe_crcs, i, crcs[4]);
>   
> -			if (!is_i915_device(data->drm_fd))
> +			if (!is_intel_device(data->drm_fd))
>   				continue;
>   
>   			for (int k = 0; k < IGT_MAX_PIPES; k++) {
> @@ -996,7 +996,7 @@ static void run_modeset_transition(data_t *data, int requested_outputs, bool non
>   	unset_output_pipe(&data->display);
>   	igt_display_commit2(&data->display, COMMIT_ATOMIC);
>   
> -	if (is_i915_device(data->drm_fd)) {
> +	if (is_intel_device(data->drm_fd)) {
>   		for_each_pipe(&data->display, pipe)
>   			igt_pipe_crc_free(data->pipe_crcs[pipe]);
>   	}