Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Riana Tauro <riana.tauro@intel.com>
To: Soham Purkait <soham.purkait@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>
Subject: Re: [PATCH i-g-t v2] tests/intel/xe_oa: Check gtidle before rc6 disable test
Date: Thu, 3 Oct 2024 17:55:18 +0530	[thread overview]
Message-ID: <0d0cab70-0ba4-4c50-b7a9-ad580ee14db2@intel.com> (raw)
In-Reply-To: <20241003115741.119720-1-soham.purkait@intel.com>

Hi Soham

reword the subject

On 10/3/2024 5:27 PM, Soham Purkait wrote:
> Rc6 disable test has been modified in order to check the
> presence of gtidle node in sysfs gt0 path through the following
> code snippets :
> igt_require(xe_sysfs_gt_has_node(drm_fd, 0, "gtidle")).
do not add code snippet in commit message
> 
> As of now only Render GT (gt0) is used for rc6 disable test through OA
> activation. Standalone Media (gt1) is not supported yet for the same.
reword?
  OA is supported only on render gt.

add version history
> 
> Signed-off-by: Soham Purkait <soham.purkait@intel.com>
> ---
>   tests/intel/xe_oa.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 9be4fd633..6538d6323 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4644,8 +4644,10 @@ igt_main
>   			test_oa_unit_concurrent_oa_buffer_read();
>   	}
>   
> -	igt_subtest("rc6-disable")
> +	igt_subtest("rc6-disable"){
space before {

Thanks,
Riana
> +		igt_require(xe_sysfs_gt_has_node(drm_fd, 0, "gtidle"));
>   		test_rc6_disable();
> +	}
>   
>   	igt_subtest_with_dynamic("stress-open-close") {
>   		__for_one_hwe_in_oag(hwe)

  reply	other threads:[~2024-10-03 12:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03 11:57 [PATCH i-g-t v2] tests/intel/xe_oa: Check gtidle before rc6 disable test Soham Purkait
2024-10-03 12:25 ` Riana Tauro [this message]
2024-10-03 16:57   ` Dixit, Ashutosh
2024-10-03 15:20 ` ✓ CI.xeBAT: success for " Patchwork
2024-10-03 15:22 ` ✗ CI.xeBAT: failure " Patchwork
2024-10-03 15:26 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-03 16:07 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-08  2:40 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d0cab70-0ba4-4c50-b7a9-ad580ee14db2@intel.com \
    --to=riana.tauro@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox