From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Mika Kahola <mika.kahola@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_flip: Set duration for subtest from command line
Date: Thu, 8 Nov 2018 12:47:52 +0100 [thread overview]
Message-ID: <0e4681c0-c84d-f6c1-2a4a-d251b28fa103@linux.intel.com> (raw)
In-Reply-To: <1533809554-27925-2-git-send-email-mika.kahola@intel.com>
Op 09-08-18 om 12:12 schreef Mika Kahola:
> To reduce the execution time of kms_flip test on CI, let's move subtest
> duration parameter as command line option. The default subtest duration
> is 3 seconds for test that require jitter computation and for the rest
> of the subtests are run only once.
>
> v2: Run each subtest only once (default action)
> v3: Reduces default timeout for tests that require jitter computation (Ville)
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
I think this is the wrong approach. What we really want to do is kill tests from kms_flip
instead and move them to separate places.
Killing off all the interruptible tests would save 50% of the time. So all we have to do is
making sure that we have tests that test the missing ioctl's in in kms_atomic_interruptible,
and we would save 50% of the time.
After that we have to get rid of the unrelated tests to make the code more readable..
nonexisting-fb, dpms-vs-vblank-race, modeset-vs-vblank-race and bo-too-big would be
better off in a separate testcase.
Same for bad-tiling, but I already had a patch for that.
https://patchwork.freedesktop.org/patch/259361/
This would clean up kms_flip a lot, and make the test more readable.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-08 11:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 10:12 [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_flip: Binary mode optimizations Mika Kahola
2018-08-09 10:12 ` [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_flip: Set duration for subtest from command line Mika Kahola
2018-08-09 10:20 ` Chris Wilson
2018-08-09 11:29 ` Mika Kahola
2018-11-08 11:47 ` Maarten Lankhorst [this message]
2018-11-08 12:45 ` Kahola, Mika
2018-11-08 13:11 ` Maarten Lankhorst
2018-11-08 14:41 ` Kahola, Mika
2018-08-09 10:12 ` [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_flip: Change 2x tests execution order Mika Kahola
2018-11-08 11:16 ` Maarten Lankhorst
2018-08-09 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: Binary mode optimizations (rev4) Patchwork
2018-08-09 12:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e4681c0-c84d-f6c1-2a4a-d251b28fa103@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).