From: Riana Tauro <riana.tauro@intel.com>
To: Soham Purkait <soham.purkait@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>, <ashutosh.dixit@intel.com>
Subject: Re: [PATCH i-g-t v3] tests/intel/xe_oa: Preventing test failures by omitting rc6 disable test if 'gtidle' node is missing
Date: Tue, 8 Oct 2024 10:55:45 +0530 [thread overview]
Message-ID: <0e7c4c4c-185c-4f54-a02e-27cf019f575b@intel.com> (raw)
In-Reply-To: <20241007190541.141470-1-soham.purkait@intel.com>
Hi Soham
Re-word subject
skip rc6 idle test if gtidle node is missing
With the above review comment fixed
Reviewed-by: Riana Tauro <riana.tauro@intel.com>
On 10/8/2024 12:35 AM, Soham Purkait wrote:
> Rc6 disable test has been modified in order to check for 'gtidle'
> node to skip residency tests on VF devices where this node is not
> present, preventing test failure.
>
> v3: Commit message fixed (Ashutosh)
> Space added before curly braces (Riana)
>
> Signed-off-by: Soham Purkait <soham.purkait@intel.com>
> ---
> tests/intel/xe_oa.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index b4dfcced7..92f5828c7 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4649,8 +4649,10 @@ igt_main
> test_oa_unit_concurrent_oa_buffer_read();
> }
>
> - igt_subtest("rc6-disable")
> + igt_subtest("rc6-disable") {
> + igt_require(xe_sysfs_gt_has_node(drm_fd, 0, "gtidle"));
> test_rc6_disable();
> + }
>
> igt_subtest_with_dynamic("stress-open-close") {
> __for_one_hwe_in_oag(hwe)
next prev parent reply other threads:[~2024-10-08 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 19:05 [PATCH i-g-t v3] tests/intel/xe_oa: Preventing test failures by omitting rc6 disable test if 'gtidle' node is missing Soham Purkait
2024-10-07 23:29 ` ✓ CI.xeBAT: success for tests/intel/xe_oa: Preventing test failures by omitting rc6 disable test if 'gtidle' node is missing (rev2) Patchwork
2024-10-07 23:30 ` ✓ Fi.CI.BAT: " Patchwork
2024-10-08 5:25 ` Riana Tauro [this message]
2024-10-08 9:32 ` ✗ CI.xeFULL: failure " Patchwork
2024-10-08 23:29 ` ✗ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-10-07 4:22 [PATCH i-g-t v3] tests/intel/xe_oa: Preventing test failures by omitting rc6 disable test if 'gtidle' node is missing Soham Purkait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e7c4c4c-185c-4f54-a02e-27cf019f575b@intel.com \
--to=riana.tauro@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=soham.purkait@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox