From: Martin Peres <martin.peres@linux.intel.com>
To: Simon Ser <simon.ser@intel.com>, igt-dev@lists.freedesktop.org
Cc: martin.peres@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_edid: fix missing include in header
Date: Tue, 4 Jun 2019 15:44:50 +0300 [thread overview]
Message-ID: <0eb77906-ff50-424c-d748-b35ef94d8285@linux.intel.com> (raw)
In-Reply-To: <20190604115717.8138-1-simon.ser@intel.com>
On 04/06/2019 14:57, Simon Ser wrote:
> detailed_timing_set_mode uses detailed_timing_set_mode from xf86drmMode.h, but
> doesn't include it. This has gone unnoticed because all the igt_edid users
> were already including this file.
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
>
> Signed-off-by: Simon Ser <simon.ser@intel.com>
> Fixes: a2fd0489c87a ("lib/igt_edid: new library for generating EDIDs")
> ---
> lib/igt_edid.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/igt_edid.h b/lib/igt_edid.h
> index 7edd7e38f41e..1d0c6aa29578 100644
> --- a/lib/igt_edid.h
> +++ b/lib/igt_edid.h
> @@ -30,6 +30,8 @@
>
> #include <stdint.h>
>
> +#include <xf86drmMode.h>
> +
> struct est_timings {
> uint8_t t1;
> uint8_t t2;
> --
> 2.21.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-04 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 11:57 [igt-dev] [PATCH i-g-t] lib/igt_edid: fix missing include in header Simon Ser
2019-06-04 12:44 ` Martin Peres [this message]
2019-06-04 14:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-05 2:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eb77906-ff50-424c-d748-b35ef94d8285@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=martin.peres@intel.com \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox