From: Andrzej Hajda <andrzej.hajda@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org,
"Kamil Konieczny" <kamil.konieczny@linux.intel.com>,
"Dominik Grzegorzek" <dominik.grzegorzek@intel.com>,
"Christoph Manszewski" <christoph.manszewski@intel.com>,
"Dominik Karol Piątkowski" <dominik.karol.piatkowski@intel.com>
Subject: Re: [PATCH 3/4] lib/gpgpu_shader: add inline support for iga64 assembly
Date: Tue, 14 May 2024 11:39:27 +0200 [thread overview]
Message-ID: <0f31f8bc-1ae3-4f71-b375-ce775ad4d23a@intel.com> (raw)
In-Reply-To: <20240510104246.cpw4jvt3sj7ajw6u@zkempczy-mobl2>
[-- Attachment #1: Type: text/plain, Size: 719 bytes --]
Thanks for looking at the patches.
On 10.05.2024 12:42, Zbigniew Kempczyński wrote:
> On Mon, Apr 29, 2024 at 02:08:19PM +0200, Andrzej Hajda wrote:
> <cut>
>
>> +# check if we need to recompile - checksum difference and compiler present
>> +MD5_ASMS="$(for a in "${ASMS[@]}"; do echo "${a#*:}"; done | md5sum|cut -b1-32)"
> Why not use:
> MD5_ASMS=$(echo "${ASMS[@]}" | md5sum | cut -b1-32)
>
> I'm not sure but your check doesn't support function (asm) rename.
My version deliberately skips asm names because they are not passed to
the compiler, so the output
of iga64 does not depend on it. But you are right, after name change
output file should be regenerated.
Will be fixed.
Regards
Andrzej
> --
> Zbigniew
[-- Attachment #2: Type: text/html, Size: 1501 bytes --]
next prev parent reply other threads:[~2024-05-14 9:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 12:08 [PATCH 0/4] lib/gpgpu: add shader support Andrzej Hajda
2024-04-29 12:08 ` [PATCH 1/4] lib/gpu_cmds: add Xe_LP version of emit_vfe_state Andrzej Hajda
2024-04-29 12:37 ` Grzegorzek, Dominik
2024-04-29 12:08 ` [PATCH 2/4] lib/gpgpu_shader: tooling for preparing and running gpgpu shaders Andrzej Hajda
2024-04-29 12:23 ` Grzegorzek, Dominik
2024-04-29 12:08 ` [PATCH 3/4] lib/gpgpu_shader: add inline support for iga64 assembly Andrzej Hajda
2024-05-10 5:52 ` Zbigniew Kempczyński
2024-05-10 10:42 ` Zbigniew Kempczyński
2024-05-14 9:39 ` Andrzej Hajda [this message]
2024-05-10 11:18 ` Kamil Konieczny
2024-05-14 9:42 ` Andrzej Hajda
2024-04-29 12:08 ` [PATCH 4/4] intel/xe_exec_sip: port test for shader sanity check Andrzej Hajda
2024-05-10 10:44 ` Zbigniew Kempczyński
2024-05-14 9:49 ` Andrzej Hajda
2024-05-10 11:30 ` Kamil Konieczny
2024-04-29 16:19 ` ✗ Fi.CI.BUILD: failure for lib/gpgpu: add shader support Patchwork
2024-04-29 16:21 ` ✗ GitLab.Pipeline: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f31f8bc-1ae3-4f71-b375-ce775ad4d23a@intel.com \
--to=andrzej.hajda@intel.com \
--cc=christoph.manszewski@intel.com \
--cc=dominik.grzegorzek@intel.com \
--cc=dominik.karol.piatkowski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox