Re: [PATCH i-g-t v1 3/3] tests/xe_ccs: Check if platform supports compression

[Matthew Auld <matthew.auld@intel.com>]

On 26/03/2024 09:54, Akshata Jahagirdar wrote:
> Add check before running the test to ensure the platform supports
> compression and has flat ccs enabled.
> 
> Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
> ---
>   tests/intel/xe_ccs.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c
> index 8fe1f62eb..b424a1d6d 100644
> --- a/tests/intel/xe_ccs.c
> +++ b/tests/intel/xe_ccs.c
> @@ -718,6 +718,7 @@ igt_main_args("bf:pst:W:H:", NULL, help_str, opt_handler, NULL)
>   	igt_fixture {
>   		xe = drm_open_driver(DRIVER_XE);
>   		igt_require(blt_has_block_copy(xe));
> +		igt_require(blt_platform_supports_compression(xe));

At least on Xe2 I think we still need some kind validation here, since 
this is a valid user config. IIRC HW claims that we shouldn't really 
care that flat-ccs is for example disabled by BIOS on LNL. Everything 
should "just work", given that the CCS state is always zero. IMO test 
should be updated to account for xe2 && compression_disabled to verify 
that CCS state is indeed always zero on such a config.

>   		if (AT_LEAST_GEN(xe, 20))
>   			igt_require(HAS_FLATCCS(xe));
>