From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id D27C16E0B9 for ; Tue, 15 Jan 2019 22:07:25 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id u47so4873826qtj.6 for ; Tue, 15 Jan 2019 14:07:25 -0800 (PST) Message-ID: <10d4cacf6437aa41092e70fb030d962fb2c3563b.camel@redhat.com> From: Lyude Paul Date: Tue, 15 Jan 2019 17:07:23 -0500 In-Reply-To: <20190111090532.19235-18-paul.kocialkowski@bootlin.com> References: <20190111090532.19235-1-paul.kocialkowski@bootlin.com> <20190111090532.19235-18-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v3 17/21] lib/igt_chamelium: Generalize the frame match helper with check type List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: T24gRnJpLCAyMDE5LTAxLTExIGF0IDEwOjA1ICswMTAwLCBQYXVsIEtvY2lhbGtvd3NraSB3cm90 ZToKPiBJbiBwcmV2aXNpb24gb2YgYWRkaW5nIHN1cHBvcnQgZm9yIGFub3RoZXIgdHlwZSBvZiBm cmFtZSBtYXRjaGluZywKPiByZW5hbWUgY2hhbWVsaXVtX2Fzc2VydF9hbmFsb2dfZnJhbWVfbWF0 Y2hfb3JfZHVtcCB0byBkcm9wIHRoZQo+IGFuYWxvZyBwYXJ0IGFuZCBmZWVkIGl0IHRoZSBjaGVj ayB0eXBlLiBUaGlzIHdheSwgdGhlIGJ1bGsgb2YgdGhlCj4gaGVscGVyIGNhbiBhcHBseSB0byBv dGhlciBmcmFtZSBtYXRjaGluZyB0eXBlcy4KPiAKPiBUaGlzIHJlcXVpcmVzIG1vdmluZyB0aGUg Y2hhbWVsaXVtX2NoZWNrIGVudW0gZnJvbSB0aGUgdGVzdCB0byB0aGUKPiBjb21tb24gY2hhbWVs aXVtIGhlYWRlci4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5r b2NpYWxrb3dza2lAYm9vdGxpbi5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfY2hhbWVsaXVtLmMgICB8 IDIxICsrKysrKysrKysrKysrKy0tLS0tLQo+ICBsaWIvaWd0X2NoYW1lbGl1bS5oICAgfCAxNCAr KysrKysrKysrLS0tLQo+ICB0ZXN0cy9rbXNfY2hhbWVsaXVtLmMgfCAgOSArKy0tLS0tLS0KPiAg MyBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiAKPiBk aWZmIC0tZ2l0IGEvbGliL2lndF9jaGFtZWxpdW0uYyBiL2xpYi9pZ3RfY2hhbWVsaXVtLmMKPiBp bmRleCA1OTY2YjVjZTA3NDMuLjE3MzIxYTJjZWY4OSAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2No YW1lbGl1bS5jCj4gKysrIGIvbGliL2lndF9jaGFtZWxpdW0uYwo+IEBAIC0xMDk1LDE5ICsxMDk1 LDIxIEBAIHZvaWQgY2hhbWVsaXVtX2Fzc2VydF9jcmNfZXFfb3JfZHVtcChzdHJ1Y3QKPiBjaGFt ZWxpdW0gKmNoYW1lbGl1bSwKPiAgfQo+ICAKPiAgLyoqCj4gLSAqIGNoYW1lbGl1bV9hc3NlcnRf YW5hbG9nX2ZyYW1lX21hdGNoX29yX2R1bXA6Cj4gKyAqIGNoYW1lbGl1bV9hc3NlcnRfZnJhbWVf bWF0Y2hfb3JfZHVtcDoKPiAgICogQGNoYW1lbGl1bTogVGhlIGNoYW1lbGl1bSBpbnN0YW5jZSB0 aGUgZnJhbWUgZHVtcCBiZWxvbmdzIHRvCj4gICAqIEBmcmFtZTogVGhlIGNoYW1lbGl1bSBmcmFt ZSBkdW1wIHRvIG1hdGNoCj4gICAqIEBmYjogcG9pbnRlciB0byBhbiAjaWd0X2ZiIHN0cnVjdHVy ZQo+ICsgKiBAY2hlY2s6IHRoZSB0eXBlIG9mIGZyYW1lIG1hdGNoaW5nIGNoZWNrIHRvIHVzZQo+ ICAgKgo+ICAgKiBBc3NlcnRzIHRoYXQgdGhlIHByb3ZpZGVkIGNhcHR1cmVkIGZyYW1lIG1hdGNo ZXMgdGhlIHJlZmVyZW5jZSBmcmFtZQo+IGZyb20KPiAgICogdGhlIGZyYW1lYnVmZmVyLiBJZiB0 aGV5IGRvIG5vdCwgdGhpcyBzYXZlcyB0aGUgcmVmZXJlbmNlIGFuZCBjYXB0dXJlZAo+IGZyYW1l cwo+ICAgKiB0byBhIHBuZyBmaWxlLgo+ICAgKi8KPiAtdm9pZCBjaGFtZWxpdW1fYXNzZXJ0X2Fu YWxvZ19mcmFtZV9tYXRjaF9vcl9kdW1wKHN0cnVjdCBjaGFtZWxpdW0KPiAqY2hhbWVsaXVtLAo+ IC0JCQkJCQkgc3RydWN0IGNoYW1lbGl1bV9wb3J0ICpwb3J0LAo+IC0JCQkJCQkgY29uc3Qgc3Ry dWN0Cj4gY2hhbWVsaXVtX2ZyYW1lX2R1bXAgKmZyYW1lLAo+IC0JCQkJCQkgc3RydWN0IGlndF9m YiAqZmIpCj4gK3ZvaWQgY2hhbWVsaXVtX2Fzc2VydF9mcmFtZV9tYXRjaF9vcl9kdW1wKHN0cnVj dCBjaGFtZWxpdW0gKmNoYW1lbGl1bSwKPiArCQkJCQkgIHN0cnVjdCBjaGFtZWxpdW1fcG9ydCAq cG9ydCwKPiArCQkJCQkgIGNvbnN0IHN0cnVjdCBjaGFtZWxpdW1fZnJhbWVfZHVtcAo+ICpmcmFt ZSwKPiArCQkJCQkgIHN0cnVjdCBpZ3RfZmIgKmZiLAo+ICsJCQkJCSAgZW51bSBjaGFtZWxpdW1f Y2hlY2sgY2hlY2spCj4gIHsKPiAgCWNhaXJvX3N1cmZhY2VfdCAqcmVmZXJlbmNlOwo+ICAJY2Fp cm9fc3VyZmFjZV90ICpjYXB0dXJlOwo+IEBAIC0xMTIxLDcgKzExMjMsMTQgQEAgdm9pZAo+IGNo YW1lbGl1bV9hc3NlcnRfYW5hbG9nX2ZyYW1lX21hdGNoX29yX2R1bXAoc3RydWN0IGNoYW1lbGl1 bSAqY2hhbWVsaXVtLAo+ICAJLyogR3JhYiB0aGUgY2FwdHVyZWQgZnJhbWUgZnJvbSBjaGFtZWxp dW0gKi8KPiAgCWNhcHR1cmUgPSBjb252ZXJ0X2ZyYW1lX2R1bXBfYXJnYjMyKGZyYW1lKTsKPiAg Cj4gLQltYXRjaCA9IGlndF9jaGVja19hbmFsb2dfZnJhbWVfbWF0Y2gocmVmZXJlbmNlLCBjYXB0 dXJlKTsKPiArCXN3aXRjaCAoY2hlY2spIHsKPiArCWNhc2UgQ0hBTUVMSVVNX0NIRUNLX0FOQUxP RzoKPiArCQltYXRjaCA9IGlndF9jaGVja19hbmFsb2dfZnJhbWVfbWF0Y2gocmVmZXJlbmNlLCBj YXB0dXJlKTsKPiArCQlicmVhazsKPiArCWRlZmF1bHQ6Cj4gKwkJaWd0X2Fzc2VydChmYWxzZSk7 Cj4gKwl9Cj4gKwo+ICAJaWYgKCFtYXRjaCAmJiBpZ3RfZnJhbWVfZHVtcF9pc19lbmFibGVkKCkp IHsKPiAgCQlyZWZlcmVuY2VfY3JjID0gbWFsbG9jKHNpemVvZihpZ3RfY3JjX3QpKTsKPiAgCj4g ZGlmZiAtLWdpdCBhL2xpYi9pZ3RfY2hhbWVsaXVtLmggYi9saWIvaWd0X2NoYW1lbGl1bS5oCj4g aW5kZXggYWY5NjU1YTBiMWNmLi4wNDJhYzAxOWNjZGIgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9j aGFtZWxpdW0uaAo+ICsrKyBiL2xpYi9pZ3RfY2hhbWVsaXVtLmgKPiBAQCAtNDAsNiArNDAsMTEg QEAgc3RydWN0IGNoYW1lbGl1bV9wb3J0Owo+ICBzdHJ1Y3QgY2hhbWVsaXVtX2ZyYW1lX2R1bXA7 Cj4gIHN0cnVjdCBjaGFtZWxpdW1fZmJfY3JjX2FzeW5jX2RhdGE7Cj4gIAo+ICtlbnVtIGNoYW1l bGl1bV9jaGVjayB7Cj4gKwlDSEFNRUxJVU1fQ0hFQ0tfQU5BTE9HLAo+ICsJQ0hBTUVMSVVNX0NI RUNLX0NSQywKPiArfTsKPiArCldlIHNob3VsZCBhZGQgc29tZSBkb2NzIHRvIHRoaXMgd2hpbGUg d2UncmUgYXQgaXQuIFdpdGggdGhhdCBmaXhlZDoKClJldmlld2VkLWJ5OiBMeXVkZSBQYXVsIDxs eXVkZUByZWRoYXQuY29tPgo+ICBzdHJ1Y3QgY2hhbWVsaXVtICpjaGFtZWxpdW1faW5pdChpbnQg ZHJtX2ZkKTsKPiAgdm9pZCBjaGFtZWxpdW1fZGVpbml0KHN0cnVjdCBjaGFtZWxpdW0gKmNoYW1l bGl1bSk7Cj4gIHZvaWQgY2hhbWVsaXVtX3Jlc2V0KHN0cnVjdCBjaGFtZWxpdW0gKmNoYW1lbGl1 bSk7Cj4gQEAgLTExMCwxMCArMTE1LDExIEBAIHZvaWQgY2hhbWVsaXVtX2Fzc2VydF9jcmNfZXFf b3JfZHVtcChzdHJ1Y3QgY2hhbWVsaXVtCj4gKmNoYW1lbGl1bSwKPiAgCQkJCSAgICAgaWd0X2Ny Y190ICpyZWZlcmVuY2VfY3JjLAo+ICAJCQkJICAgICBpZ3RfY3JjX3QgKmNhcHR1cmVfY3JjLCBz dHJ1Y3QgaWd0X2ZiCj4gKmZiLAo+ICAJCQkJICAgICBpbnQgaW5kZXgpOwo+IC12b2lkIGNoYW1l bGl1bV9hc3NlcnRfYW5hbG9nX2ZyYW1lX21hdGNoX29yX2R1bXAoc3RydWN0IGNoYW1lbGl1bQo+ ICpjaGFtZWxpdW0sCj4gLQkJCQkJCSBzdHJ1Y3QgY2hhbWVsaXVtX3BvcnQgKnBvcnQsCj4gLQkJ CQkJCSBjb25zdCBzdHJ1Y3QKPiBjaGFtZWxpdW1fZnJhbWVfZHVtcCAqZnJhbWUsCj4gLQkJCQkJ CSBzdHJ1Y3QgaWd0X2ZiICpmYik7Cj4gK3ZvaWQgY2hhbWVsaXVtX2Fzc2VydF9mcmFtZV9tYXRj aF9vcl9kdW1wKHN0cnVjdCBjaGFtZWxpdW0gKmNoYW1lbGl1bSwKPiArCQkJCQkgIHN0cnVjdCBj aGFtZWxpdW1fcG9ydCAqcG9ydCwKPiArCQkJCQkgIGNvbnN0IHN0cnVjdCBjaGFtZWxpdW1fZnJh bWVfZHVtcAo+ICpmcmFtZSwKPiArCQkJCQkgIHN0cnVjdCBpZ3RfZmIgKmZiLAo+ICsJCQkJCSAg ZW51bSBjaGFtZWxpdW1fY2hlY2sgY2hlY2spOwo+ICB2b2lkIGNoYW1lbGl1bV9jcm9wX2FuYWxv Z19mcmFtZShzdHJ1Y3QgY2hhbWVsaXVtX2ZyYW1lX2R1bXAgKmR1bXAsIGludAo+IHdpZHRoLAo+ ICAJCQkJIGludCBoZWlnaHQpOwo+ICB2b2lkIGNoYW1lbGl1bV9kZXN0cm95X2ZyYW1lX2R1bXAo c3RydWN0IGNoYW1lbGl1bV9mcmFtZV9kdW1wICpkdW1wKTsKPiBkaWZmIC0tZ2l0IGEvdGVzdHMv a21zX2NoYW1lbGl1bS5jIGIvdGVzdHMva21zX2NoYW1lbGl1bS5jCj4gaW5kZXggNjRmODdkM2Fl NDc0Li5mYTZmZWU3ZDllM2UgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21zX2NoYW1lbGl1bS5jCj4g KysrIGIvdGVzdHMva21zX2NoYW1lbGl1bS5jCj4gQEAgLTUyNywxMSArNTI3LDYgQEAgc3RhdGlj IGludCBjaGFtZWxpdW1fZ2V0X3BhdHRlcm5fZmIoZGF0YV90ICpkYXRhLAo+IHNpemVfdCB3aWR0 aCwgc2l6ZV90IGhlaWdodCwKPiAgCXJldHVybiBmYl9pZDsKPiAgfQo+ICAKPiAtZW51bSBjaGFt ZWxpdW1fY2hlY2sgewo+IC0JQ0hBTUVMSVVNX0NIRUNLX0FOQUxPRywKPiAtCUNIQU1FTElVTV9D SEVDS19DUkMsCj4gLX07Cj4gLQo+ICBzdGF0aWMgdm9pZCBkb190ZXN0X2Rpc3BsYXkoZGF0YV90 ICpkYXRhLCBzdHJ1Y3QgY2hhbWVsaXVtX3BvcnQgKnBvcnQsCj4gIAkJCSAgICBpZ3Rfb3V0cHV0 X3QgKm91dHB1dCwgZHJtTW9kZU1vZGVJbmZvICptb2RlLAo+ICAJCQkgICAgdWludDMyX3QgZm91 cmNjLCBlbnVtIGNoYW1lbGl1bV9jaGVjayBjaGVjaywKPiBAQCAtNTg5LDggKzU4NCw4IEBAIHN0 YXRpYyB2b2lkIGRvX3Rlc3RfZGlzcGxheShkYXRhX3QgKmRhdGEsIHN0cnVjdAo+IGNoYW1lbGl1 bV9wb3J0ICpwb3J0LAo+ICAJCQkJCQkgIDAsIDApOwo+ICAJCWNoYW1lbGl1bV9jcm9wX2FuYWxv Z19mcmFtZShkdW1wLCBtb2RlLT5oZGlzcGxheSwKPiAgCQkJCQkgICAgbW9kZS0+dmRpc3BsYXkp Owo+IC0JCWNoYW1lbGl1bV9hc3NlcnRfYW5hbG9nX2ZyYW1lX21hdGNoX29yX2R1bXAoZGF0YS0+ Y2hhbWVsaXVtLAo+IC0JCQkJCQkJICAgIHBvcnQsIGR1bXAsICZmYik7Cj4gKwkJY2hhbWVsaXVt X2Fzc2VydF9mcmFtZV9tYXRjaF9vcl9kdW1wKGRhdGEtPmNoYW1lbGl1bSwgcG9ydCwKPiArCQkJ CQkJICAgICBkdW1wLCAmZmIsIGNoZWNrKTsKPiAgCQljaGFtZWxpdW1fZGVzdHJveV9mcmFtZV9k dW1wKGR1bXApOwo+ICAJfQo+ICAKLS0gCkNoZWVycywKCUx5dWRlIFBhdWwKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0 CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=