From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 588096E245 for ; Tue, 29 Jan 2019 19:43:58 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id l12so23630012qtf.8 for ; Tue, 29 Jan 2019 11:43:58 -0800 (PST) Message-ID: <10e4007a871c108f04ac9fde18887dece9ae033c.camel@redhat.com> From: Lyude Paul Date: Tue, 29 Jan 2019 14:43:56 -0500 In-Reply-To: <20190125145842.15738-5-maxime.ripard@bootlin.com> References: <20190125145842.15738-1-maxime.ripard@bootlin.com> <20190125145842.15738-5-maxime.ripard@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 04/13] igt: fb: Move i915 YUV buffer clearing code to a function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Thomas Petazzoni , eben@raspberrypi.org List-ID: UmV2aWV3ZWQtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+CgpPbiBGcmksIDIwMTkt MDEtMjUgYXQgMTU6NTggKzAxMDAsIE1heGltZSBSaXBhcmQgd3JvdGU6Cj4gVGhlIFlVViBidWZm ZXIgYWxsb2NhdGlvbiBwYXRoIGZvciB0aGUgaTkxNSBkcml2ZXIgYWxzbyBoYXMgc29tZSBjb2Rl IHRvCj4gY2xlYXIgYSBZVVYgYnVmZmVyLgo+IAo+IEFzIHRoYXQgaXMgZ29pbmcgdG8gYmUgdXNl ZnVsIGZvciBhbGwgdGhlIG90aGVyIGRyaXZlcnMsIGxldCdzIG1vdmUgaXQgdG8KPiBhIHNlcGFy YXRlIGZ1bmN0aW9uLgo+IAo+IFJldmlld2VkLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5r b2NpYWxrb3dza2lAYm9vdGxpbi5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8 bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KPiAtLS0KPiAgbGliL2lndF9mYi5jIHwgODAgKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDQ1NjkxZmQ0NDFkOS4u ZDY5YzNmYjJkMzhkIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3Rf ZmIuYwo+IEBAIC00ODQsNiArNDg0LDQ3IEBAIHVpbnQ2NF90IGlndF9mYl90aWxpbmdfdG9fbW9k KHVpbnQ2NF90IHRpbGluZykKPiAgCX0KPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgY2xlYXJfeXV2 X2J1ZmZlcihzdHJ1Y3QgaWd0X2ZiICpmYikKPiArewo+ICsJYm9vbCBmdWxsX3JhbmdlID0gZmIt PmNvbG9yX3JhbmdlID09IElHVF9DT0xPUl9ZQ0JDUl9GVUxMX1JBTkdFOwo+ICsJdm9pZCAqcHRy Owo+ICsKPiArCWlndF9hc3NlcnQoaWd0X2Zvcm1hdF9pc195dXYoZmItPmRybV9mb3JtYXQpKTsK PiArCj4gKwkvKiBFbnN1cmUgdGhlIGZyYW1lYnVmZmVyIGlzIHByZWFsbG9jYXRlZCAqLwo+ICsJ cHRyID0gaWd0X2ZiX21hcF9idWZmZXIoZmItPmZkLCBmYik7Cj4gKwlpZ3RfYXNzZXJ0KCoodWlu dDMyX3QgKilwdHIgPT0gMCk7Cj4gKwo+ICsJc3dpdGNoIChmYi0+ZHJtX2Zvcm1hdCkgewo+ICsJ Y2FzZSBEUk1fRk9STUFUX05WMTI6Cj4gKwkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ ICsJCSAgICAgICBmdWxsX3JhbmdlID8gMHgwMCA6IDB4MTAsCj4gKwkJICAgICAgIGZiLT5zdHJp ZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSk7Cj4gKwkJbWVtc2V0KHB0ciArIGZiLT5vZmZz ZXRzWzFdLAo+ICsJCSAgICAgICAweDgwLAo+ICsJCSAgICAgICBmYi0+c3RyaWRlc1sxXSAqIGZi LT5wbGFuZV9oZWlnaHRbMV0pOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSBEUk1fRk9STUFUX1hZVVY4 ODg4Ogo+ICsJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sIGZ1bGxfcmFuZ2UgPyAweDAw MDA4MDgwIDoKPiAweDAwMTA4MDgwLAo+ICsJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9o ZWlnaHRbMF0gLwo+IHNpemVvZih3Y2hhcl90KSk7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIERSTV9G T1JNQVRfWVVZVjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+ICsJCXdtZW1zZXQocHRyICsg ZmItPm9mZnNldHNbMF0sCj4gKwkJCWZ1bGxfcmFuZ2UgPyAweDgwMDA4MDAwIDogMHg4MDEwODAx MCwKPiArCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8KPiBzaXplb2Yo d2NoYXJfdCkpOwo+ICsJCWJyZWFrOwo+ICsJY2FzZSBEUk1fRk9STUFUX1VZVlk6Cj4gKwljYXNl IERSTV9GT1JNQVRfVllVWToKPiArCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ICsJ CQlmdWxsX3JhbmdlID8gMHgwMDgwMDA4MCA6IDB4MTA4MDEwODAsCj4gKwkJCWZiLT5zdHJpZGVz WzBdICogZmItPnBsYW5lX2hlaWdodFswXSAvCj4gc2l6ZW9mKHdjaGFyX3QpKTsKPiArCQlicmVh azsKPiArCX0KPiArCj4gKwlpZ3RfZmJfdW5tYXBfYnVmZmVyKGZiLCBwdHIpOwo+ICt9Cj4gKwo+ ICAvKiBoZWxwZXJzIHRvIGNyZWF0ZSBuaWNlLWxvb2tpbmcgZnJhbWVidWZmZXJzICovCj4gIHN0 YXRpYyBpbnQgY3JlYXRlX2JvX2Zvcl9mYihzdHJ1Y3QgaWd0X2ZiICpmYikKPiAgewo+IEBAIC01 MDEsNTAgKzU0MiwxMyBAQCBzdGF0aWMgaW50IGNyZWF0ZV9ib19mb3JfZmIoc3RydWN0IGlndF9m YiAqZmIpCj4gIAkJZmItPmlzX2R1bWIgPSBmYWxzZTsKPiAgCj4gIAkJaWYgKGlzX2k5MTVfZGV2 aWNlKGZkKSkgewo+IC0JCQl2b2lkICpwdHI7Cj4gLQkJCWJvb2wgZnVsbF9yYW5nZSA9IGZiLT5j b2xvcl9yYW5nZSA9PQo+IElHVF9DT0xPUl9ZQ0JDUl9GVUxMX1JBTkdFOwo+ICAKPiAgCQkJZmIt PmdlbV9oYW5kbGUgPSBnZW1fY3JlYXRlKGZkLCBmYi0+c2l6ZSk7Cj4gIAo+ICAJCQlnZW1fc2V0 X3RpbGluZyhmZCwgZmItPmdlbV9oYW5kbGUsCj4gIAkJCQkgICAgICAgaWd0X2ZiX21vZF90b190 aWxpbmcoZmItPnRpbGluZyksCj4gIAkJCQkgICAgICAgZmItPnN0cmlkZXNbMF0pOwo+IC0KPiAt CQkJZ2VtX3NldF9kb21haW4oZmQsIGZiLT5nZW1faGFuZGxlLAo+IC0JCQkJICAgICAgIEk5MTVf R0VNX0RPTUFJTl9HVFQsCj4gSTkxNV9HRU1fRE9NQUlOX0dUVCk7Cj4gLQo+IC0JCQkvKiBFbnN1 cmUgdGhlIGZyYW1lYnVmZmVyIGlzIHByZWFsbG9jYXRlZCAqLwo+IC0JCQlwdHIgPSBnZW1fbW1h cF9fZ3R0KGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiAtCQkJCQkgICAgZmItPnNpemUsIFBST1RfUkVB RCB8IFBST1RfV1JJVEUpOwo+IC0JCQlpZ3RfYXNzZXJ0KCoodWludDMyX3QgKilwdHIgPT0gMCk7 Cj4gLQo+IC0JCQlzd2l0Y2ggKGZiLT5kcm1fZm9ybWF0KSB7Cj4gLQkJCWNhc2UgRFJNX0ZPUk1B VF9OVjEyOgo+IC0JCQkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+IC0JCQkJICAgICAg IGZ1bGxfcmFuZ2UgPyAweDAwIDogMHgxMCwKPiAtCQkJCSAgICAgICBmYi0+c3RyaWRlc1swXSAq IGZiLT5wbGFuZV9oZWlnaHRbMF0pOwo+IC0JCQkJbWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzFd LAo+IC0JCQkJICAgICAgIDB4ODAsCj4gLQkJCQkgICAgICAgZmItPnN0cmlkZXNbMV0gKiBmYi0+ cGxhbmVfaGVpZ2h0WzFdKTsKPiAtCQkJCWJyZWFrOwo+IC0JCQljYXNlIERSTV9GT1JNQVRfWFlV Vjg4ODg6Cj4gLQkJCQl3bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLCBmdWxsX3JhbmdlID8K PiAweDAwMDA4MDgwIDogMHgwMDEwODA4MCwKPiAtCQkJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5w bGFuZV9oZWlnaHRbMF0gLwo+IHNpemVvZih3Y2hhcl90KSk7Cj4gLQkJCQlicmVhazsKPiAtCQkJ Y2FzZSBEUk1fRk9STUFUX1lVWVY6Cj4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9ZVllVOgo+IC0JCQkJ d21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwKPiAtCQkJCQlmdWxsX3JhbmdlID8gMHg4MDAw ODAwMCA6IDB4ODAxMDgwMTAsCj4gLQkJCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVp Z2h0WzBdIC8KPiBzaXplb2Yod2NoYXJfdCkpOwo+IC0JCQkJYnJlYWs7Cj4gLQkJCWNhc2UgRFJN X0ZPUk1BVF9VWVZZOgo+IC0JCQljYXNlIERSTV9GT1JNQVRfVllVWToKPiAtCQkJCXdtZW1zZXQo cHRyICsgZmItPm9mZnNldHNbMF0sCj4gLQkJCQkJZnVsbF9yYW5nZSA/IDB4MDA4MDAwODAgOiAw eDEwODAxMDgwLAo+IC0JCQkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSAv Cj4gc2l6ZW9mKHdjaGFyX3QpKTsKPiAtCQkJCWJyZWFrOwo+IC0JCQl9Cj4gLQkJCWdlbV9tdW5t YXAocHRyLCBmYi0+c2l6ZSk7Cj4gKwkJCWNsZWFyX3l1dl9idWZmZXIoZmQpOwo+ICAKPiAgCQkJ cmV0dXJuIGZiLT5nZW1faGFuZGxlOwo+ICAJCX0gZWxzZSB7Ci0tIApDaGVlcnMsCglMeXVkZSBQ YXVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3Qt ZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK