Re: [igt-dev] [PATCH i-g-t] PSR: Bump wait for active timeout to 2.5s

[Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>]

On Tue, 2018-12-11 at 17:16 +0100, Maarten Lankhorst wrote:
> Typically PSR enables in around 136 ms, but when enabling 2
> screens, 500 ms is not enough on icelake sometimes, so bump
> it a bit higher.
> 
> On kms_frontbuffer_tracking:
> Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
> psr_active(debugfs_fd, true) took 136ms
> psr_active(debugfs_fd, true) took 136ms
> psr_active(debugfs_fd, true) took 350ms
> psr_active(debugfs_fd, true) took 136ms
> psr_active(debugfs_fd, true) took 1598ms

We have to find out why it took that long, ~96 frames exceeds the idle
frame limit we set in the driver. I'm concerned we might be covering up
a bug by increasing the limit so high.

-DK

> 
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
> ---
>  lib/igt_psr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 0ddfb64f0e72..265521217a2d 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -39,7 +39,7 @@ static bool psr_active(int debugfs_fd, bool
> check_active)
>  
>  bool psr_wait_entry(int debugfs_fd)
>  {
> -	return igt_wait(psr_active(debugfs_fd, true), 500, 20);
> +	return igt_wait(psr_active(debugfs_fd, true), 2500, 20);
>  }
>  
>  bool psr_wait_exit(int debugfs_fd)

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev