From: Karthik B S <karthik.b.s@intel.com>
To: Petri Latvala <petri.latvala@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Remove redundant igt_require_pipe
Date: Thu, 6 Aug 2020 19:07:37 +0530 [thread overview]
Message-ID: <11452e95-c104-db89-c8cd-58858f7dfdcc@intel.com> (raw)
In-Reply-To: <20200806133337.8482-1-petri.latvala@intel.com>
LGTM.
Acked-by: Karthik B S <karthik.b.s@intel.com>
On 8/6/2020 7:03 PM, Petri Latvala wrote:
> The plan was to remove the call while merging a6b258448837
> ("tests/kms_pipe_crc_basic: Sanity check for CRC mismatches")
> according to the review feedback, but that was forgotten. Remove it
> now.
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Karthik B S <karthik.b.s@intel.com>
> Cc: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
> tests/kms_pipe_crc_basic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
> index c3c4cdd8..bb66bc6c 100644
> --- a/tests/kms_pipe_crc_basic.c
> +++ b/tests/kms_pipe_crc_basic.c
> @@ -177,7 +177,6 @@ static void test_compare_crc(data_t *data, enum pipe pipe)
> igt_require_f(output, "No connector found for pipe %s\n",
> kmstest_pipe_name(pipe));
>
> - igt_require_pipe(display, pipe);
> igt_display_reset(display);
> igt_output_set_pipe(output, pipe);
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-08-06 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:33 [igt-dev] [PATCH i-g-t] tests/kms_pipe_crc_basic: Remove redundant igt_require_pipe Petri Latvala
2020-08-06 13:37 ` Karthik B S [this message]
2020-08-06 14:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-08-06 17:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-07 8:55 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11452e95-c104-db89-c8cd-58858f7dfdcc@intel.com \
--to=karthik.b.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox