Re: [PATCH i-g-t] lib/dsc: use intel_display_caps instead of i915_display_capabilities

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Jani,

Thanks for the reply.

Patch LGTM.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 26-03-2025 02:56 pm, Jani Nikula wrote:
> On Wed, 26 Mar 2025, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
>> Hi Jani,
>>
>> Have few queries:
>> 1. Are we going to remove i915_display_capabilities ?
> Yes, hence the patch at hand. Can't remove it before merging this.
>
> intel_display_caps already has more information than
> i915_display_capabilities, and I intend to add more.
>
>> 2. Since this new debugfs intel_display_caps, has prefix "intel" whereas
>> all other debugfs still has "i915"
>> Are we going to make this change to other display related debugfs too?
> Eventually, yes. The xe driver having debugfs files with i915 prefix is
> quite confusing.
>
> I think new debugfs files should be prefixed intel_ while any rename
> will need more careful consideration. It's quite the flag day change.
>
> This one's easier as i915_display_capabilities and intel_display_caps
> already coexist.
>
> BR,
> Jani.
>
>
>> On 25-03-2025 06:38 pm, Jani Nikula wrote:
>>> Turns out we've added two similar files in kernel. Consolidate on
>>> intel_display_caps as the more driver independent name.
>>>
>>> Cc: Swati Sharma <swati2.sharma@intel.com>
>>> Cc: Vinod Govindapillai <vinod.govindapillai@intel.com>
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>> ---
>>>    lib/igt_dsc.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/igt_dsc.c b/lib/igt_dsc.c
>>> index 8d259b7344a6..4caad39db7a9 100644
>>> --- a/lib/igt_dsc.c
>>> +++ b/lib/igt_dsc.c
>>> @@ -56,7 +56,7 @@ bool igt_is_dsc_supported_by_source(int drmfd)
>>>    	dir = igt_debugfs_dir(drmfd);
>>>    	igt_assert(dir >= 0);
>>>    
>>> -	res = igt_debugfs_simple_read(dir, "i915_display_capabilities",
>>> +	res = igt_debugfs_simple_read(dir, "intel_display_caps",
>>>    				      buf, sizeof(buf));
>>>    	close(dir);
>>>