Re: [igt-dev] [PATCH i-g-t v2 09/16] lib/intel_allocator: Add field to distinquish underlying driver

[Karolina Stolarek <karolina.stolarek@intel.com>]

On 6.07.2023 08:05, Zbigniew Kempczyński wrote:
> Cache what driver is using on drm fd to avoid calling same code
> in allocator functions.

Good call!

Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>

> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
>   lib/intel_allocator.c | 1 +
>   lib/intel_allocator.h | 3 +++
>   2 files changed, 4 insertions(+)
> 
> diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
> index be24f8f2d0..228b33b92f 100644
> --- a/lib/intel_allocator.c
> +++ b/lib/intel_allocator.c
> @@ -318,6 +318,7 @@ static struct intel_allocator *intel_allocator_create(int fd,
>   
>   	igt_assert(ial);
>   
> +	ial->driver = get_intel_driver(fd);
>   	ial->type = allocator_type;
>   	ial->strategy = allocator_strategy;
>   	ial->default_alignment = default_alignment;
> diff --git a/lib/intel_allocator.h b/lib/intel_allocator.h
> index 3ec74f6191..1001b21b98 100644
> --- a/lib/intel_allocator.h
> +++ b/lib/intel_allocator.h
> @@ -141,6 +141,9 @@ struct intel_allocator {
>   	/* allocator's private structure */
>   	void *priv;
>   
> +	/* driver - i915 or Xe */
> +	enum intel_driver driver;
> +
>   	void (*get_address_range)(struct intel_allocator *ial,
>   				  uint64_t *startp, uint64_t *endp);
>   	uint64_t (*alloc)(struct intel_allocator *ial, uint32_t handle,