From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CA466E579 for ; Thu, 4 Apr 2019 07:33:35 +0000 (UTC) From: "Lisovskiy, Stanislav" Date: Thu, 4 Apr 2019 07:33:31 +0000 Message-ID: <126e6a048495814781d60526fc7fc813158d821c.camel@intel.com> References: <20190219093800.4312-1-stanislav.lisovskiy@intel.com> <690c1112b0fd97f4810cced16d442d16ca75809b.camel@intel.com> <20190403142311.GL2665@phenom.ffwll.local> In-Reply-To: <20190403142311.GL2665@phenom.ffwll.local> Content-Language: en-US Content-ID: <63CB95F902FDFE44BBC247D726CCA24B@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v4] igt/tests: Fix error checking in kms_atomic_transition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "daniel@ffwll.ch" , "Summers, Stuart" Cc: "igt-dev@lists.freedesktop.org" , "norkernel@freedesktop.org" , "Syrjala, Ville" , "Heikkila, Juha-pekka" , "Peres, Martin" List-ID: T24gV2VkLCAyMDE5LTA0LTAzIGF0IDE2OjIzICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOg0K PiBPbiBUdWUsIEZlYiAxOSwgMjAxOSBhdCAwOTowNToxMlBNICswMDAwLCBTdW1tZXJzLCBTdHVh cnQgd3JvdGU6DQo+ID4gT24gVHVlLCAyMDE5LTAyLTE5IGF0IDExOjM4ICswMjAwLCBTdGFuaXNs YXYgTGlzb3Zza2l5IHdyb3RlOg0KPiA+ID4gRnJvbTogU3RhbmlzbGF2IExpc292c2tpeSA8c3Rh bmlzbGF2Lmxpc292c2tpeUBnbWFpbC5jb20+DQo+ID4gPiANCj4gPiA+IFRoZXJlIGlzIG5vIGd1 YXJhbnRlZSB0aGF0IGVycm9yIHJldHVybiB2YWx1ZSB3aWxsIGJlDQo+ID4gPiBhbHdheXMgRUlO VkFMLCBtYWRlIGEgY2hlY2sgbW9yZSBnZW5lcmFsIGFzIGl0IGNhbiBiZQ0KPiA+ID4gRVJBTkdF LCBFTk9TUEMsIEVJTlZBTCBhbmQgcHJvYmFibHkgb3RoZXJzLCB3aGljaCBhbGwNCj4gPiA+IG1l YW4gdGhlIHNhbWUgaW4gY29udGV4dCBvZiB0aGlzIHRlc3QgY2FzZTogaS5lIHRoaXMgc3ByaXRl DQo+ID4gPiBzaXplIGlzIG5vdCB2YWxpZC4NCj4gPiA+IA0KPiA+ID4gdjI6IEFkZGVkIG1hY3Jv IHRvIG1ha2UgY2hlY2sgbG9vayBhIGJpdCBuaWNlci4NCj4gPiA+IHYzOiBSZW1vdmVkIHJlZHVu ZGFudCBkZWJ1ZyBsaW5lLg0KPiA+ID4gdjQ6IEFkZGVkIGFzc2VydGlvbiBpZiBlcnJvciBpcyBu b3QgRUlOVkFMIGFzIGV4cGVjdGVkLA0KPiA+ID4gICAgIG90aGVyIGVycm9ycyBleGNlcHQgRUlO VkFMIGFyZSBjb25zaWRlcmVkIG5vdyBhIGZhaWx1cmVzLg0KPiANCj4gVWgsIGNvbW1pdCBtZXNz YWdlIHNheXMgdG8gbWFrZSB0aGUgZXJyb3IgbWVzc2FnZSBtb3JlIGdlbmVyYWwsIGFuZA0KPiB0 aGVuDQo+IHByb2NlZWRzIHRvIG1ha2UgaXQgbm90IG1vcmUgZ2VuZXJhbC4gVGhpcyBraW5kIG9m IGluY29uc2lzdGVuY2llcw0KPiBzaG91bGQNCj4gYmUgY2F1Z2h0IGluIHJldmlldy4NCg0KSGkg RGFuaWVsLA0KDQpBcyB0aGUgY29tbWl0IG1lc3NhZ2Ugc2F5cywgcHJldmlzb3VseSB3ZSB3ZXJl IGV4cGVjdGluZyBvbmx5DQpFSU5WQUwod2hpY2ggaW5kaWNhdGVzIGZvcg0KdXMgdGhhdCB3ZSBo YWQgcmVhY2hlZCBtYXggc2l6ZSBvZiBhIHBsYW5lKSBvciAwLg0KDQpQcm9ibGVtIHdhcyB0aGF0 IGluIHNvbWUgY2lyY3Vtc3RhbmNlcywgaWYgd2UgZ2V0IHNvbWV0aGluZyBlbHNlDQp0ZXN0IGNh c2UgZGlkIG5vdCBjYXRjaCB0aGF0IGFuZCBwcm9jZWVkZWQgYXMgaWYgZXZlcnl0aGluZyBpcw0K Z3JlYXQsIGZhaWxpbmcgYWZ0ZXJ3YXJkcywgd2hlbiB0cnlpbmcgYWxyZWFkeSB0byBjb21taXQg b3Igb3RoZXINCnBsYWNlLg0KVGhlIHRoaW5nIHdoaWNoIHRoaXMgcGF0Y2ggZG9lcyBpcyBhcyBz YWlkICJBZGRlZCBhc3NlcnRpb24gaWYgZXJyb3IgaXMNCm5vdCBFSU5WQUwgYXMgZXhwZWN0ZWQs IG90aGVyIGVycm9ycyBleGNlcHQgRUlOVkFMIGFyZSBjb25zaWRlcmVkIG5vdyBhDQpmYWlsdXJl cyIuIE90aGVyd2lzZSBpZiB3ZSBnb3QgRUlOVkFMLCB3ZSBwcm9jZWVkIG5vcm1hbGx5Lg0KDQpU aGVyZSB3YXMgYWN0dWFsbHkgbm8gcHVycG9zZSB0byAiZml4IiBzb21ldGhpbmcgYnkgdGhhdCwg YnV0IHJhdGhlcg0KbWFrZSBpdCBmYWlsIGluIGEgcHJvcGVyIHBsYWNlIGFuZCBwcm9wZXIgd2F5 LCBvdGhlcndpc2UgZXJyb3IganVzdA0Kd2VudCBmdXJ0aGVyLiANCg0KTXkgaW5pdGlhbCBpZGVh IGFjdHVhbGx5IHdhcyB0byBjYXRjaCBhbGwga2luZCBvZiBwcm9ibGVtcyBoZXJlLCBzbw0KdGhh dCB3ZSBhbHdheXMgZ2V0IHNvbWUga2luZCBvZiB3b3JraW5nIHBsYW5lIGNvbmZpZ3VyYXRpb24g aGVyZS4NCkhvd2V2ZXIgaXQgd2FzIG5vdCBhY2NlcHRlZCBhbmQgY3VycmVudGx5IG9ubHkgRUlO VkFMIGlzIHRyZWF0ZWQgYXMNCiJub3JtYWwiIGVycm9yLg0KDQpJZiB5b3UgaGF2ZSBhbnkgcHJv cG9zYWxzLCBob3cgdGhpcyBjYW4gYmUgaW1wcm92ZWQgc3VyZSBJIGNhbiBkbyB0aGlzLg0KDQo+ IA0KPiA+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwOTIyNQ0KPiA+ID4gU2lnbmVkLW9mZi1ieTogU3RhbmlzbGF2IExpc292c2tpeSA8 c3RhbmlzbGF2Lmxpc292c2tpeUBpbnRlbC5jb20NCj4gPiA+ID4NCj4gDQo+IEFuZCBJIGFsc28g ZG9uJ3QgdW5kZXJzdGFuZCBob3cgdGhpcyBwYXRjaCBmaXhlZCBhbnl0aGluZyByZWFsbHksIHdl DQo+IHN0aWxsDQo+IGp1c3QgY2hlY2sgZm9yIEVJTlZBTC4NCj4gLURhbmllbA0KPiANCj4gPiA+ IC0tLQ0KPiA+ID4gIHRlc3RzL2ttc19hdG9taWNfdHJhbnNpdGlvbi5jIHwgMTMgKysrKysrKysr KystLQ0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQ0KPiA+ID4gDQo+ID4gPiBkaWZmIC0tZ2l0IGEvdGVzdHMva21zX2F0b21pY190cmFuc2l0 aW9uLmMNCj4gPiA+IGIvdGVzdHMva21zX2F0b21pY190cmFuc2l0aW9uLmMNCj4gPiA+IGluZGV4 IDEyYmFmZTg3Li5lMWEyZDRhMCAxMDA2NDQNCj4gPiA+IC0tLSBhL3Rlc3RzL2ttc19hdG9taWNf dHJhbnNpdGlvbi5jDQo+ID4gPiArKysgYi90ZXN0cy9rbXNfYXRvbWljX3RyYW5zaXRpb24uYw0K PiA+ID4gQEAgLTE4Nyw2ICsxODcsMTIgQEAgc3RhdGljIHZvaWQgc2V0X3Nwcml0ZV93aChpZ3Rf ZGlzcGxheV90DQo+ID4gPiAqZGlzcGxheSwgZW51bSBwaXBlIHBpcGUsDQo+ID4gPiAgCQkgICAg ICBMT0NBTF9EUk1fRk9STUFUX01PRF9OT05FLCBzcHJpdGVfZmIpOw0KPiA+ID4gIH0NCj4gPiA+ ICANCj4gPiA+ICsjZGVmaW5lIGlzX2F0b21pY19jaGVja19mYWlsdXJlX2Vycm5vKGVycm5vKSBc DQo+ID4gPiArCQkoZXJybm8gIT0gLUVJTlZBTCAmJiBlcnJubyAhPSAwKQ0KPiA+ID4gKw0KPiA+ ID4gKyNkZWZpbmUgaXNfYXRvbWljX2NoZWNrX3BsYW5lX3NpemVfZXJybm8oZXJybm8pIFwNCj4g PiA+ICsJCShlcnJubyA9PSAtRUlOVkFMKQ0KPiA+ID4gKw0KPiA+ID4gIHN0YXRpYyB2b2lkIHNl dHVwX3Bhcm1zKGlndF9kaXNwbGF5X3QgKmRpc3BsYXksIGVudW0gcGlwZSBwaXBlLA0KPiA+ID4g IAkJCWNvbnN0IGRybU1vZGVNb2RlSW5mbyAqbW9kZSwNCj4gPiA+ICAJCQlzdHJ1Y3QgaWd0X2Zi ICpwcmltYXJ5X2ZiLA0KPiA+ID4gQEAgLTI1MSw4ICsyNTcsOSBAQCByZXRyeToNCj4gPiA+ICAN Cj4gPiA+ICAJCXdtX3NldHVwX3BsYW5lKGRpc3BsYXksIHBpcGUsICgxIDw8IG5fcGxhbmVzKSAt IDEsDQo+ID4gPiBwYXJtcywgZmFsc2UpOw0KPiA+ID4gIAkJcmV0ID0gaWd0X2Rpc3BsYXlfdHJ5 X2NvbW1pdF9hdG9taWMoZGlzcGxheSwNCj4gPiA+IERSTV9NT0RFX0FUT01JQ19URVNUX09OTFkg fCBEUk1fTU9ERV9BVE9NSUNfQUxMT1dfTU9ERVNFVCwgTlVMTCk7DQo+ID4gPiArCQlpZ3RfYXNz ZXJ0KCFpc19hdG9taWNfY2hlY2tfZmFpbHVyZV9lcnJubyhyZXQpKTsNCj4gPiA+ICANCj4gPiA+ IC0JCWlmIChyZXQgPT0gLUVJTlZBTCkgew0KPiA+ID4gKwkJaWYgKGlzX2F0b21pY19jaGVja19w bGFuZV9zaXplX2Vycm5vKHJldCkpIHsNCj4gPiA+ICAJCQlpZiAoY3Vyc29yX3dpZHRoID09IHNw cml0ZV93aWR0aCAmJg0KPiA+ID4gIAkJCSAgICBjdXJzb3JfaGVpZ2h0ID09IHNwcml0ZV9oZWln aHQpIHsNCj4gPiA+ICAJCQkJaWd0X2Fzc2VydF9mKGFscGhhLA0KPiA+ID4gQEAgLTQ0Miw3ICs0 NDksOSBAQCBydW5fdHJhbnNpdGlvbl90ZXN0KGlndF9kaXNwbGF5X3QgKmRpc3BsYXksDQo+ID4g PiBlbnVtDQo+ID4gPiBwaXBlIHBpcGUsIGlndF9vdXRwdXRfdCAqb3V0cHV0DQo+ID4gPiAgCQkJ aWd0X3BpcGVfcmVxdWVzdF9vdXRfZmVuY2UocGlwZV9vYmopOw0KPiA+ID4gIA0KPiA+ID4gIAkJ cmV0ID0gaWd0X2Rpc3BsYXlfdHJ5X2NvbW1pdF9hdG9taWMoZGlzcGxheSwNCj4gPiA+IERSTV9N T0RFX0FUT01JQ19URVNUX09OTFkgfCBEUk1fTU9ERV9BVE9NSUNfQUxMT1dfTU9ERVNFVCwgTlVM TCk7DQo+ID4gPiAtCQlpZiAocmV0ICE9IC1FSU5WQUwgfHwgcGlwZV9vYmotPm5fcGxhbmVzIDwg MykNCj4gPiA+ICsJCWlndF9hc3NlcnQoIWlzX2F0b21pY19jaGVja19mYWlsdXJlX2Vycm5vKHJl dCkpOw0KPiA+ID4gKw0KPiA+ID4gKwkJaWYgKCFpc19hdG9taWNfY2hlY2tfcGxhbmVfc2l6ZV9l cnJubyhyZXQpIHx8IHBpcGVfb2JqLQ0KPiA+ID4gPiBuX3BsYW5lcyA8IDMpDQo+ID4gPiANCj4g PiA+ICAJCQlicmVhazsNCj4gPiA+ICANCj4gPiA+ICAJCXJldCA9IDA7DQo+ID4gDQo+ID4gTEdU TQ0KPiA+IA0KPiA+IFJldmlld2VkLWJ5OiBTdHVhcnQgU3VtbWVycyA8c3R1YXJ0LnN1bW1lcnNA aW50ZWwuY29tPg0KPiANCj4gDQo+IA0KPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fDQo+ID4gaWd0LWRldiBtYWlsaW5nIGxpc3QNCj4gPiBpZ3QtZGV2 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0KPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaWd0LWRldg0KPiANCj4gDQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2lndC1kZXY=