From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Mika Kahola <mika.kahola@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation
Date: Wed, 24 Apr 2019 10:58:54 +0300 [thread overview]
Message-ID: <1387af32-3c83-dcfc-d84f-6591c2af449b@gmail.com> (raw)
In-Reply-To: <20190423130049.306-1-mika.kahola@intel.com>
Look ok to me. Hope i915 doesn't get changes onto that list too frequently.
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 23.4.2019 16.00, Mika Kahola wrote:
> Update the list of pixel formats that cannot be rotated by 90/270 degrees. With this patch,
> the kernel and IGT are aligned for i915 driver.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=109052
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110369
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_plane_scaling.c | 27 +++++++++++++++++++++------
> 1 file changed, 21 insertions(+), 6 deletions(-)
>
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 079d2700..3d247130 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -174,14 +174,29 @@ static const igt_rotation_t rotations[] = {
> static bool can_rotate(data_t *d, unsigned format, uint64_t tiling,
> igt_rotation_t rot)
> {
> - if (format == DRM_FORMAT_C8 ||
> - (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
> - return false;
>
> - // Y-tiled 90/270 rotation isn't supported for fp16 on Intel
> - if (is_i915_device(d->drm_fd) && igt_format_is_fp16(format) &&
> - (rot == IGT_ROTATION_90 || rot == IGT_ROTATION_270))
> + if (!is_i915_device(d->drm_fd))
> + return true;
> +
> + switch (format) {
> + case DRM_FORMAT_RGB565:
> + if (intel_gen(d->devid) >= 11)
> + break;
> + /* fall through */
> + case DRM_FORMAT_C8:
> + case DRM_FORMAT_XRGB16161616F:
> + case DRM_FORMAT_XBGR16161616F:
> + case DRM_FORMAT_ARGB16161616F:
> + case DRM_FORMAT_ABGR16161616F:
> + case DRM_FORMAT_Y210:
> + case DRM_FORMAT_Y212:
> + case DRM_FORMAT_Y216:
> + case DRM_FORMAT_XVYU12_16161616:
> + case DRM_FORMAT_XVYU16161616:
> return false;
> + default:
> + break;
> + }
>
> return true;
> }
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-24 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 13:00 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: Update list of supported pixel formats for rotation Mika Kahola
2019-04-23 14:35 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-23 17:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-24 7:58 ` Juha-Pekka Heikkila [this message]
2019-04-24 9:48 ` [igt-dev] [PATCH i-g-t] " Kahola, Mika
2019-04-24 19:16 ` James Ausmus
2019-04-25 6:40 ` Kahola, Mika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387af32-3c83-dcfc-d84f-6591c2af449b@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox