Re: [PATCH v2 0/3] lib/igt_core: add timestamps to error logs

["Hajda, Andrzej" <andrzej.hajda@intel.com>]

W dniu 7.05.2026 o 14:34, Andrzej Hajda pisze:
> This patchset add timestamps to error logs in IGT.
> One of side effects of adding timestamps is detection by CI of previously
> hidden errors in errno handling.
> According to manual errno should be read immediately AFTER library function
> returns an error, otherwise errno can be overwriten by subsequent calls.
> First patches fixes these errors.
> 
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>


Apparently the errno is handled non-safely in so many places, that 
fixing this will take some time. I will try to detach timestamps from 
errno fixes in next iteration.

Regards
Andrzej


> ---
> Changes in v2:
> - added fixes to errno handling
> - adjusted format string to be the same as in dmesg
> - Link to v1: https://patch.msgid.link/20260505-add_timestamps_to_logs-v1-1-2d95f499fdfb@intel.com
> 
> ---
> Andrzej Hajda (3):
>        tests/core_auth: do not call any function before errno check
>        lib/igt_sysfs: protect errno from being overwritten in igt_debug_on
>        lib/igt_core: add timestamps to error logs
> 
>   lib/igt_core.c    | 13 +++++++++----
>   lib/igt_sysfs.c   | 17 +++++++++++------
>   tests/core_auth.c |  2 +-
>   3 files changed, 21 insertions(+), 11 deletions(-)
> ---
> base-commit: 3e5747e536f148bf232049e49a00e2b683f91a83
> change-id: 20260430-add_timestamps_to_logs-d84fdfd7ef4c
> 
> Best regards,
> --
> Andrzej Hajda <andrzej.hajda@intel.com>
>