public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Latvala, Petri" <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/fb: Remove unused variables
Date: Thu, 20 Dec 2018 12:22:21 +0000	[thread overview]
Message-ID: <1437a2e82045a0a94d1f396c3c6ef58a5237b899.camel@intel.com> (raw)
In-Reply-To: <20181220121517.28078-1-petri.latvala@intel.com>

On Thu, 2018-12-20 at 14:15 +0200, Petri Latvala wrote:
> ../lib/igt_fb.c: In function ‘convert_rgb24_to_yuv444’:
> ../lib/igt_fb.c:1720:16: warning: unused variable ‘v’ [-Wunused-
> variable]
>     float y, u, v;
>           ^
> ../lib/igt_fb.c:1720:13: warning: unused variable ‘u’ [-Wunused-
> variable]
>     float y, u, v;
>              ^
> ../lib/igt_fb.c:1720:10: warning: unused variable ‘y’ [-Wunused-
> variable]
>     float y, u, v;
>                 ^
> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  lib/igt_fb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 57264844..2f555c95 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -1717,7 +1717,6 @@ static void convert_rgb24_to_yuv444(struct
> fb_convert *cvt)
>  		for (j = 0; j < cvt->dst.fb->width; j++) {
>  			struct igt_vec4 rgb;
>  			struct igt_vec4 yuv;
> -			float y, u, v;
>  
>  			read_rgb(&rgb, &rgb24[i * rgb24_stride + j *
> 4]);
>  

Thanks for spotting.

Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

-- 
Best Regards,

Lisovskiy Stanislav
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-12-20 12:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20 12:15 [igt-dev] [PATCH i-g-t] lib/fb: Remove unused variables Petri Latvala
2018-12-20 12:22 ` Lisovskiy, Stanislav [this message]
2018-12-20 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-21 11:45 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437a2e82045a0a94d1f396c3c6ef58a5237b899.camel@intel.com \
    --to=stanislav.lisovskiy@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox