Re: [PATCH i-g-t v2 2/2] oa/i915: Add ARL standlone oa files

["Souza, Jose" <jose.souza@intel.com>]

On Mon, 2024-11-04 at 13:06 -0800, Dixit, Ashutosh wrote:
> On Mon, 04 Nov 2024 12:52:00 -0800, José Roberto de Souza wrote:
> > 
> 
> Hi Jose,
> 
> > There is suficient differences between generated ARL OA files and
> > MTL ones for us to generated and split ARL to its own files.
> > 
> > v2:
> > - add missing arl check in perf-metricset-codegen.py
> 
> These work this time correct, unlike the last time where something was
> wrong? Maybe it was due to this?

Yes, it was not working because it was missing this change.

> 
> The subject should be lib/i915/perf (which Kamil requested the last time),
> but I can fix that up before merging. Unless you can merge, in that case
> please fix this up.
> 
> Otherwise:
> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

Thank you, will open the Mesa MR today lets hold the merging until Lionel gives some feedback.
But now it is working.

> 
> > 
> > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>