From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8311D6E0DB for ; Tue, 27 Nov 2018 12:00:42 +0000 (UTC) References: <20181126204349.6739-1-andi.shyti@intel.com> <20181126204349.6739-3-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: <14b2e3a6-ef69-1ab6-6a04-0fb426adff62@linux.intel.com> Date: Tue, 27 Nov 2018 12:00:40 +0000 MIME-Version: 1.0 In-Reply-To: <20181126204349.6739-3-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v3 2/3] lib: implement new engine discovery interface List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti , Tvrtko Ursulin List-ID: Ck9uIDI2LzExLzIwMTggMjA6NDMsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gS2VybmVsIGNvbW1pdHM6 Cj4gCj4gWzFdIGFlOGY0NTQ0ZGQ4ZiAoImRybS9pOTE1OiBFbmdpbmUgZGlzY292ZXJ5IHF1ZXJ5 IikKPiBbMl0gMzFlN2QzNTY2N2EwICgiZHJtL2k5MTU6IEFsbG93IGEgY29udGV4dCB0byBkZWZp bmUgaXRzIHNldCBvZiBlbmdpbmVzIikKPiAKPiBmcm9tIFsqXSByZXBvc2l0b3J5LCBpbXBsZW1l bnQgYSBuZXcgdWFwaSBmb3IgZW5naW5lIGRpc2NvdmVyeQo+IHRoYXQgY29uc2lzdCBpbiBmaXJz dCBxdWVyeWluZyB0aGUgZHJpdmVyIGFib3V0IHRoZSBlbmdpbmVzIGluCj4gdGhlIGdwdSBbMV0g YW5kIHRoZW4gYmluZGluZyBhIGNvbnRleHQgdG8gdGhlIHNldCBvZiBlbmdpbmVzIHRoYXQKPiBp dCBjYW4gYWNjZXNzIFsyXS4KPiAKPiBJbiBpZ3QgdGhlIGNsYXNzaWMgd2F5IGZvciBkaXNjb3Zl cmluZyBlbmdpbmVzIGlzIGRvbmUgdGhyb3VnaAo+IHRoZSBmb3JfZWFjaF9waHlzaWNhbF9lbmdp bmUoKSBtYWNybywgdGhhdCB3b3VsZCBiZSByZXBsYWNlZCBieQo+IHRoZSBuZXcgZm9yX2VhY2hf ZW5naW5lX2N0eCgpLgo+IAo+IFsqXSBnaXQ6Ly9wZW9wbGUuZnJlZWRlc2t0b3Aub3JnL350dXJz dWxpbi9kcm0taW50ZWwKPiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmRpIFNoeXRpIDxhbmRpLnNoeXRp QGludGVsLmNvbT4KPiAtLS0KPiAgIGxpYi9pZ3RfZ3QuYyB8IDc0ICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgIGxpYi9pZ3RfZ3QuaCB8ICA1 ICsrKysKPiAgIDIgZmlsZXMgY2hhbmdlZCwgNzkgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1n aXQgYS9saWIvaWd0X2d0LmMgYi9saWIvaWd0X2d0LmMKPiBpbmRleCBhMjA2MTkyNC4uZTU1NDNi MjcgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9ndC5jCj4gKysrIGIvbGliL2lndF9ndC5jCj4gQEAg LTY1MCwzICs2NTAsNzcgQEAgYm9vbCBnZW1fcmluZ19oYXNfcGh5c2ljYWxfZW5naW5lKGludCBm ZCwgdW5zaWduZWQgcmluZykKPiAgIAo+ICAgCXJldHVybiBnZW1faGFzX3JpbmcoZmQsIHJpbmcp Owo+ICAgfQo+ICsKPiArc3RhdGljIHN0cnVjdCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbyAq cXVlcnlfZW5naW5lcyhpbnQgZmQpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9xdWVyeSBxdWVy eSA9IHsgfTsKPiArCXN0cnVjdCBkcm1faTkxNV9xdWVyeV9pdGVtIGl0ZW0gPSB7IH07Cj4gKwlz dHJ1Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5lX2luZm8gKnF1ZXJ5X2VuZ2luZXM7Cj4gKwo+ICsJ aXRlbS5xdWVyeV9pZCA9IERSTV9JOTE1X1FVRVJZX0VOR0lORV9JTkZPOwo+ICsJcXVlcnkuaXRl bXNfcHRyID0gdG9fdXNlcl9wb2ludGVyKCZpdGVtKTsKPiArCXF1ZXJ5Lm51bV9pdGVtcyA9IDE7 Cj4gKwo+ICsJLyoKPiArCSAqIFRoZSBmaXJzdCBpb2N0bCBpcyBzZW50IHdpdGggaXRlbS5sZW5n dGggPSAwCj4gKwkgKiB3aGljaCBhc2tzIHRvIHRoZSBkcml2ZXIgdG8gc3RvcmUgaW4gbGVuZ3Ro IHRoZQo+ICsJICogbWVtb3J5IG5lZWRlZCBmb3IgdGhlIGVuZ2luZXMuIEluIHRoZSBkcml2ZXIs IGxlbmd0aAo+ICsJICogaXMgZXF1YWwgdG8KPiArCSAqCj4gKwkgKiAgIGxlbiA9IHNpemVvZihz dHJ1Y3QgZHJtX2k5MTVfcXVlcnlfZW5naW5lX2luZm8pICsKPiArCSAqICAgICAgICAgICAgICAg ICAgIElOVEVMX0lORk8oaTkxNSktPm51bV9yaW5ncyAqCj4gKwkgKiAgICAgICAgICAgICAgICAg ICBzaXplb2Yoc3RydWN0IGRybV9pOTE1X2VuZ2luZV9pbmZvKTsKPiArCSAqLwo+ICsJaWd0X3Jl cXVpcmUoIWlvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9RVUVSWSwgJnF1ZXJ5KSk7Cj4gKwo+ICsJ aWd0X2Fzc2VydCgocXVlcnlfZW5naW5lcyA9IGNhbGxvYyhpdGVtLmxlbmd0aCwgMSkpKTsKPiAr CWl0ZW0uZGF0YV9wdHIgPSB0b191c2VyX3BvaW50ZXIocXVlcnlfZW5naW5lcyk7Cj4gKwo+ICsJ LyogVGhlIHNlY29uZCBpb2N0bCBzdG9yZXMgdGhlIGVuZ2luZXMgaW4gcXVlcnlfZW5naW5lcyAq Lwo+ICsJaWd0X3JlcXVpcmUoIWlvY3RsKGZkLCBEUk1fSU9DVExfSTkxNV9RVUVSWSwgJnF1ZXJ5 KSk7Cj4gKwo+ICsJcmV0dXJuIHF1ZXJ5X2VuZ2luZXM7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lk IHNldF9wYXJhbShpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCwKPiArCQkgICAgICBzdHJ1Y3QgZHJt X2k5MTVfcXVlcnlfZW5naW5lX2luZm8gKnF1ZXJ5X2VuZ2luZSkKPiArewo+ICsJaW50IGk7Cj4g KwlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW0gY3R4X3BhcmFtOwo+ICsJc3RydWN0 IGk5MTVfY29udGV4dF9wYXJhbV9lbmdpbmVzICpjdHhfZW5naW5lOwo+ICsJc2l6ZV90IHNpemUg PSBzaXplb2Yoc3RydWN0IGk5MTVfY29udGV4dF9wYXJhbV9lbmdpbmVzKSArCj4gKwkJICAgICAg cXVlcnlfZW5naW5lLT5udW1fZW5naW5lcyAqCj4gKwkJICAgICAgc2l6ZW9mKCpjdHhfZW5naW5l LT5jbGFzc19pbnN0YW5jZSk7Cj4gKwo+ICsJaWd0X2Fzc2VydCgoY3R4X2VuZ2luZSA9IG1hbGxv YyhzaXplKSkpOwo+ICsKPiArCWN0eF9lbmdpbmUtPmV4dGVuc2lvbnMgPSAwOwo+ICsJZm9yIChp ID0gMDsgaSA8IHF1ZXJ5X2VuZ2luZS0+bnVtX2VuZ2luZXM7IGkrKykgewo+ICsJCWN0eF9lbmdp bmUtPmNsYXNzX2luc3RhbmNlW2ldLmNsYXNzID0gcXVlcnlfZW5naW5lLT5lbmdpbmVzW2ldLmNs YXNzOwo+ICsJCWN0eF9lbmdpbmUtPmNsYXNzX2luc3RhbmNlW2ldLmluc3RhbmNlID0gcXVlcnlf ZW5naW5lLT5lbmdpbmVzW2ldLmluc3RhbmNlOwo+ICsJfQo+ICsKPiArCWN0eF9wYXJhbS5jdHhf aWQgPSBjdHhfaWQ7Cj4gKwljdHhfcGFyYW0uc2l6ZSA9IHNpemU7Cj4gKwljdHhfcGFyYW0ucGFy YW0gPSBJOTE1X0NPTlRFWFRfUEFSQU1fRU5HSU5FUzsKPiArCWN0eF9wYXJhbS52YWx1ZSA9IHRv X3VzZXJfcG9pbnRlcihjdHhfZW5naW5lKTsKPiArCj4gKwkvKiBjaGVjayB3aGV0aGVyIHdlIGZy ZWUgdGhlIGVuZ2luZXMgKi8KPiArCWlndF9yZXF1aXJlKCFpb2N0bChmZCwgRFJNX0lPQ1RMX0k5 MTVfR0VNX0NPTlRFWFRfU0VUUEFSQU0sICZjdHhfcGFyYW0pKTsKPiArCj4gKwlmcmVlKGN0eF9l bmdpbmUpOwoKTGVha3Mgb24gc2tpcCwgbm90IHRoYXQgaXQgbWF0dGVycyBhIGxvdCwgYnV0IHRo ZSBjb21tZW50cyBtYWtlcyBtZSAKdGhpbmsgeW91IHdhbnRlZCB0byBoYW5kbGUgaXQuCgo+ICt9 Cj4gKwo+ICtpbnQgX19nZW1fc2V0dXBfY3R4X2VuZ2luZXMoaW50IGZkLCB1aW50MzJfdCBjdHhf aWQpCj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9xdWVyeV9lbmdpbmVfaW5mbyAqcXVlcnlfZW5n aW5lOwo+ICsJaW50IG47Cj4gKwo+ICsJcXVlcnlfZW5naW5lID0gcXVlcnlfZW5naW5lcyhmZCk7 Cj4gKwlzZXRfcGFyYW0oZmQsIGN0eF9pZCwgcXVlcnlfZW5naW5lKTsKPiArCj4gKwluID0gcXVl cnlfZW5naW5lLT5udW1fZW5naW5lczsKPiArCWZyZWUocXVlcnlfZW5naW5lKTsKPiArCj4gKwly ZXR1cm4gbjsKPiArfQo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2d0LmggYi9saWIvaWd0X2d0LmgK PiBpbmRleCA1NGU5NWRhOS4uNTEyZjk1OGQgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9ndC5oCj4g KysrIGIvbGliL2lndF9ndC5oCj4gQEAgLTg2LDggKzg2LDEzIEBAIGV4dGVybiBjb25zdCBzdHJ1 Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZSB7Cj4gICAJICAgICBlX18rKykgXAo+ICAgCQlmb3Jf aWYgKGdlbV9yaW5nX2hhc19waHlzaWNhbF9lbmdpbmUoZmRfXywgZmxhZ3NfXyA9IGVfXy0+ZXhl Y19pZCB8IGVfXy0+ZmxhZ3MpKQo+ICAgCj4gKyNkZWZpbmUgZm9yX2VhY2hfZW5naW5lX2N0eChm ZCwgY3R4LCBlKSBcCj4gKwkJZm9yIChpbnQgX19tID0gX19nZW1fc2V0dXBfY3R4X2VuZ2luZXMo ZmQsIGN0eCksIF9fZSA9IGUgPSAxOyBcCj4gKwkJCQlfX2UgPD0gX19tOyBlID0gKytfX2UpCj4g KwoKSXMgX19lIG5lZWRlZD8gQ291bGQganVzdCB1c2UgcGFzc2VkIGluIGU/Cgo+ICAgYm9vbCBn ZW1fcmluZ19pc19waHlzaWNhbF9lbmdpbmUoaW50IGZkLCB1bnNpZ25lZCBpbnQgcmluZyk7Cj4g ICBib29sIGdlbV9yaW5nX2hhc19waHlzaWNhbF9lbmdpbmUoaW50IGZkLCB1bnNpZ25lZCBpbnQg cmluZyk7Cj4gK2ludCBfX2dlbV9zZXR1cF9jdHhfZW5naW5lcyhpbnQgZmQsIHVpbnQzMl90IGN0 eF9pZCk7Cj4gICAKPiAgIGJvb2wgZ2VtX2Nhbl9zdG9yZV9kd29yZChpbnQgZmQsIHVuc2lnbmVk IGludCBlbmdpbmUpOwo+ICAgCj4gCgpMb29rcyBva2F5LiBCdXQgd2UgbmVlZCB0byBkZWNpZGUg d2hldGhlciB3ZSB3YW50IHRoZSBpdGVyYXRvciB0byBiZSBhIApzdHJ1Y3Qgc29vbmVyIHJhdGhl ciB0aGFuIGxhdGVyIG5vdy4KCkkgdGhpbmsgaWYgeW91IGdvIGFuZCBjb252ZXJ0IG9uZSBvZiB0 aGUgdGVzdHMgd2hpY2ggdXNlcyAKZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lIHRvIGVudW1lcmF0 ZSBzdWJ0ZXN0cyBhbmQgc28sIGl0IHdpbGwgYmVjb21lIApjbGVhcmVyIHdoYXQgYXBwcm9hY2gg d29yayBiZXR0ZXIuIChzdHJ1Y3QgaXRlcmF0b3IsIG9yIGhlbHBlcnMgdG8gZ2V0IApkYXRhIGZy b20gZW5naW5lIGluZGV4LikKClJlZ2FyZHMsCgpUdnJ0a28KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaWd0LWRldgo=