From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id B303889B05 for ; Tue, 15 Jan 2019 21:57:55 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id p17so4851445qtl.5 for ; Tue, 15 Jan 2019 13:57:55 -0800 (PST) Message-ID: <14e2a8ab8d452c1fcc87898ffd2766e9a63626fa.camel@redhat.com> From: Lyude Paul Date: Tue, 15 Jan 2019 16:57:53 -0500 In-Reply-To: <20190111090532.19235-14-paul.kocialkowski@bootlin.com> References: <20190111090532.19235-1-paul.kocialkowski@bootlin.com> <20190111090532.19235-14-paul.kocialkowski@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v3 13/21] lib/igt_kms: Add helpers to count and iterate planes from pipe List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: UmV2aWV3ZWQtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+CgpPbiBGcmksIDIwMTkt MDEtMTEgYXQgMTA6MDUgKzAxMDAsIFBhdWwgS29jaWFsa293c2tpIHdyb3RlOgo+IFRoaXMgaW50 cm9kdWNlcyBoZWxwZXJzIHRoYXQgYWxsb3cgY291bnRpbmcgaG93IG1hbnkgcGxhbmVzIG9mIGEg Z2l2ZW4KPiB0eXBlIGFyZSBwcmVzZW50IGZyb20gYSBwaXBlIGFuZCBnZXR0aW5nIHRoZSBuLXRo IHBsYW5lIG9mIGEgZ2l2ZW4gdHlwZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtv d3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5jb20+Cj4gLS0tCj4gIGxpYi9pZ3Rfa21z LmMgfCA0OCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK PiAgbGliL2lndF9rbXMuaCB8ICAzICsrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDUxIGluc2VydGlv bnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9rbXMuYyBiL2xpYi9pZ3Rfa21zLmMKPiBp bmRleCA2ODRhNTk5Y2E2NzQuLmU1YzRlZTcyODg0YSAxMDA2NDQKPiAtLS0gYS9saWIvaWd0X2tt cy5jCj4gKysrIGIvbGliL2lndF9rbXMuYwo+IEBAIC0yMjc2LDYgKzIyNzYsNTQgQEAgaWd0X3Bs YW5lX3QgKmlndF9waXBlX2dldF9wbGFuZV90eXBlKGlndF9waXBlX3QKPiAqcGlwZSwgaW50IHBs YW5lX3R5cGUpCj4gIAlyZXR1cm4gJnBpcGUtPnBsYW5lc1twbGFuZV9pZHhdOwo+ICB9Cj4gIAo+ ICsvKioKPiArICogaWd0X3BpcGVfY291bnRfcGxhbmVfdHlwZToKPiArICogQHBpcGU6IFRhcmdl dCBwaXBlCj4gKyAqIEBwbGFuZV90eXBlOiBDdXJzb3IsIHByaW1hcnkgb3IgYW4gb3ZlcmxheSBw bGFuZQo+ICsgKgo+ICsgKiBDb3VudHMgdGhlIG51bWJlciBvZiBwbGFuZXMgb2YgdHlwZSBAcGxh bmVfdHlwZSBmb3IgdGhlIHByb3ZpZGVkIEBwaXBlLgo+ICsgKgo+ICsgKiBSZXR1cm5zOiBUaGUg bnVtYmVyIG9mIHBsYW5lcyB0aGF0IG1hdGNoIHRoZSByZXF1ZXN0ZWQgcGxhbmUgdHlwZQo+ICsg Ki8KPiAraW50IGlndF9waXBlX2NvdW50X3BsYW5lX3R5cGUoaWd0X3BpcGVfdCAqcGlwZSwgaW50 IHBsYW5lX3R5cGUpCj4gK3sKPiArCWludCBpLCBjb3VudCA9IDA7Cj4gKwo+ICsJZm9yKGkgPSAw OyBpIDwgcGlwZS0+bl9wbGFuZXM7IGkrKykKPiArCQlpZiAocGlwZS0+cGxhbmVzW2ldLnR5cGUg PT0gcGxhbmVfdHlwZSkKPiArCQkJY291bnQrKzsKPiArCj4gKwlyZXR1cm4gY291bnQ7Cj4gK30K PiArCj4gKy8qKgo+ICsgKiBpZ3RfcGlwZV9nZXRfcGxhbmVfdHlwZV9pbmRleDoKPiArICogQHBp cGU6IFRhcmdldCBwaXBlCj4gKyAqIEBwbGFuZV90eXBlOiBDdXJzb3IsIHByaW1hcnkgb3IgYW4g b3ZlcmxheSBwbGFuZQo+ICsgKiBAaW5kZXg6IHRoZSBpbmRleCBvZiB0aGUgcGxhbmUgYW1vbmcg cGxhbmVzIG9mIHRoZSBzYW1lIHR5cGUKPiArICoKPiArICogR2V0IHRoZSBAaW5kZXggdGggcGxh bmUgb2YgdHlwZSBAcGxhbmVfdHlwZSBmb3IgdGhlIHByb3ZpZGVkIEBwaXBlLgo+ICsgKgo+ICsg KiBSZXR1cm5zOiBUaGUgQGluZGV4IHRoIHBsYW5lIHRoYXQgbWF0Y2hlcyB0aGUgcmVxdWVzdGVk IHBsYW5lIHR5cGUKPiArICovCj4gK2lndF9wbGFuZV90ICppZ3RfcGlwZV9nZXRfcGxhbmVfdHlw ZV9pbmRleChpZ3RfcGlwZV90ICpwaXBlLCBpbnQKPiBwbGFuZV90eXBlLAo+ICsJCQkJCSAgIGlu dCBpbmRleCkKPiArewo+ICsJaW50IGksIHR5cGVfaW5kZXggPSAwOwo+ICsKPiArCWZvcihpID0g MDsgaSA8IHBpcGUtPm5fcGxhbmVzOyBpKyspIHsKPiArCQlpZiAocGlwZS0+cGxhbmVzW2ldLnR5 cGUgIT0gcGxhbmVfdHlwZSkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCWlmICh0eXBlX2luZGV4 ID09IGluZGV4KQo+ICsJCQlyZXR1cm4gJnBpcGUtPnBsYW5lc1tpXTsKPiArCj4gKwkJdHlwZV9p bmRleCsrOwo+ICsJfQo+ICsKPiArCXJldHVybiBOVUxMOwo+ICt9Cj4gKwo+ICBzdGF0aWMgYm9v bCBvdXRwdXRfaXNfaW50ZXJuYWxfcGFuZWwoaWd0X291dHB1dF90ICpvdXRwdXQpCj4gIHsKPiAg CXN3aXRjaCAob3V0cHV0LT5jb25maWcuY29ubmVjdG9yLT5jb25uZWN0b3JfdHlwZSkgewo+IGRp ZmYgLS1naXQgYS9saWIvaWd0X2ttcy5oIGIvbGliL2lndF9rbXMuaAo+IGluZGV4IDRhN2MzYzk3 OTU3Zi4uMGY5OTUzNWUyYzZlIDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3Rfa21zLmgKPiArKysgYi9s aWIvaWd0X2ttcy5oCj4gQEAgLTQwNSw2ICs0MDUsOSBAQCBpZ3Rfb3V0cHV0X3QgKmlndF9vdXRw dXRfZnJvbV9jb25uZWN0b3IoaWd0X2Rpc3BsYXlfdAo+ICpkaXNwbGF5LAo+ICAgICAgZHJtTW9k ZUNvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgCj4gIGlndF9wbGFuZV90ICppZ3RfcGlwZV9nZXRf cGxhbmVfdHlwZShpZ3RfcGlwZV90ICpwaXBlLCBpbnQgcGxhbmVfdHlwZSk7Cj4gK2ludCBpZ3Rf cGlwZV9jb3VudF9wbGFuZV90eXBlKGlndF9waXBlX3QgKnBpcGUsIGludCBwbGFuZV90eXBlKTsK PiAraWd0X3BsYW5lX3QgKmlndF9waXBlX2dldF9wbGFuZV90eXBlX2luZGV4KGlndF9waXBlX3Qg KnBpcGUsIGludAo+IHBsYW5lX3R5cGUsCj4gKwkJCQkJICAgaW50IGluZGV4KTsKPiAgaWd0X291 dHB1dF90ICppZ3RfZ2V0X3NpbmdsZV9vdXRwdXRfZm9yX3BpcGUoaWd0X2Rpc3BsYXlfdCAqZGlz cGxheSwgZW51bQo+IHBpcGUgcGlwZSk7Cj4gIAo+ICB2b2lkIGlndF9waXBlX3JlcXVlc3Rfb3V0 X2ZlbmNlKGlndF9waXBlX3QgKnBpcGUpOwotLSAKQ2hlZXJzLAoJTHl1ZGUgUGF1bAoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5n IGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==