From: Karthik B S <karthik.b.s@intel.com>
To: Petri Latvala <petri.latvala@intel.com>, nidhi1.gupta@intel.com
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [RFC, i-g-t] Added dynamic Subtest
Date: Wed, 11 Nov 2020 15:12:12 +0530 [thread overview]
Message-ID: <150da36c-cb0a-f308-c6b1-bf2cf336c9ae@intel.com> (raw)
In-Reply-To: <20201106093436.GV7444@platvala-desk.ger.corp.intel.com>
On 11/6/2020 3:04 PM, Petri Latvala wrote:
> On Fri, Nov 06, 2020 at 02:57:57PM +0530, nidhi1.gupta@intel.com wrote:
>> From: Nidhi Gupta <nidhi1.gupta@intel.com>
>>
>> Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
>> ---
>> tests/kms_atomic_transition.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
>> index a71bbe10..aa2afe02 100644
>> --- a/tests/kms_atomic_transition.c
>> +++ b/tests/kms_atomic_transition.c
>> @@ -1025,16 +1025,16 @@ igt_main
>> run_transition_test(&display, pipe, output, TRANSITION_MODESET_DISABLE, false, false);
>>
>> for (i = 1; i <= IGT_MAX_PIPES; i++) {
Since we're now anyway planning to use dynamic subtests for this,
Could we just have a count of the number of outputs connected and use
this, instead of using IGT_MAX_PIPES to populate the subtests and
eventually skipping them?
@Petri,
Does this sound good?
Thanks,
Karthik.B.S
>> - igt_subtest_f("%ix-modeset-transitions", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions", i)
>> run_modeset_transition(&display, i, false, false);
>>
>> - igt_subtest_f("%ix-modeset-transitions-nonblocking", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking", i)
>> run_modeset_transition(&display, i, true, false);
>>
>> - igt_subtest_f("%ix-modeset-transitions-fencing", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-fencing", i)
>> run_modeset_transition(&display, i, false, true);
>>
>> - igt_subtest_f("%ix-modeset-transitions-nonblocking-fencing", i)
>> + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking-fencing", i)
>> run_modeset_transition(&display, i, true, true);
> Where are the igt_dynamic() blocks for these?
>
>
> --
> Petri Latvala
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-11-11 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 9:27 [igt-dev] [RFC, i-g-t] Added dynamic Subtest nidhi1.gupta
2020-11-06 9:34 ` Petri Latvala
2020-11-11 9:42 ` Karthik B S [this message]
2020-11-11 10:26 ` Petri Latvala
2020-11-06 9:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-06 11:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-12-01 2:32 [igt-dev] [RFC, i-g-t] Added Dynamic Subtest nidhi1.gupta
2020-12-01 13:44 ` Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150da36c-cb0a-f308-c6b1-bf2cf336c9ae@intel.com \
--to=karthik.b.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=nidhi1.gupta@intel.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).