From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id D937C10E0A6 for ; Fri, 28 Apr 2023 05:59:18 +0000 (UTC) Message-ID: <1510967b-6e10-54d2-953e-3d96f0cbb75b@intel.com> Date: Fri, 28 Apr 2023 11:28:55 +0530 Content-Language: en-US To: =?UTF-8?Q?Zbigniew_Kempczy=c5=84ski?= , References: <20230427200307.240349-1-zbigniew.kempczynski@intel.com> <20230427200307.240349-15-zbigniew.kempczynski@intel.com> From: "Modem, Bhanuprakash" In-Reply-To: <20230427200307.240349-15-zbigniew.kempczynski@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v7 14/16] lib/igt_fb: For xe assume vram is used on discrete List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri-28-04-2023 01:33 am, Zbigniew Kempczyński wrote: > Assume fb bo's were created on vram on discrete, otherwise use system > memory. > LGTM Reviewed-by: Bhanuprakash Modem > Signed-off-by: Zbigniew Kempczyński > > --- > v2: use -1 for i915 region (Bhanu) > --- > lib/igt_fb.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/lib/igt_fb.c b/lib/igt_fb.c > index 7379b99aa8..df3d7d91a9 100644 > --- a/lib/igt_fb.c > +++ b/lib/igt_fb.c > @@ -2545,6 +2545,7 @@ igt_fb_create_intel_buf(int fd, struct buf_ops *bops, > { > struct intel_buf *buf; > uint32_t bo_name, handle, compression; > + uint64_t region; > int num_surfaces; > int i; > > @@ -2571,12 +2572,16 @@ igt_fb_create_intel_buf(int fd, struct buf_ops *bops, > bo_name = gem_flink(fd, fb->gem_handle); > handle = gem_open(fd, bo_name); > > - buf = intel_buf_create_using_handle_and_size(bops, handle, > - fb->width, fb->height, > - fb->plane_bpp[0], 0, > - igt_fb_mod_to_tiling(fb->modifier), > - compression, fb->size, > - fb->strides[0]); > + /* For i915 region doesn't matter, for xe does */ > + region = buf_ops_get_driver(bops) == INTEL_DRIVER_XE ? > + vram_if_possible(fd, 0) : -1; > + buf = intel_buf_create_full(bops, handle, > + fb->width, fb->height, > + fb->plane_bpp[0], 0, > + igt_fb_mod_to_tiling(fb->modifier), > + compression, fb->size, > + fb->strides[0], > + region); > intel_buf_set_name(buf, name); > > /* Make sure we close handle on destroy path */