From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA8C889310 for ; Wed, 7 Feb 2018 13:42:12 +0000 (UTC) Message-ID: <1518010930.14464.5.camel@intel.com> From: Mika Kahola Date: Wed, 07 Feb 2018 15:42:10 +0200 In-Reply-To: <20180206101417.59979-2-maarten.lankhorst@linux.intel.com> References: <20180206101417.59979-1-maarten.lankhorst@linux.intel.com> <20180206101417.59979-2-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 02/12] tests: Always call igt_remove_fb without checking. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: mika.kahola@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , igt-dev@lists.freedesktop.org List-ID: T24gVHVlLCAyMDE4LTAyLTA2IGF0IDExOjE0ICswMTAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90 ZToKPiBUaGlzIGNsZWFucyB1cCB0aGUgdGVzdHMgc2xpZ2h0bHkuCj4gCgpSZXZpZXdlZC1ieTog TWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVsLmNvbT4KCj4gU2lnbmVkLW9mZi1ieTogTWFh cnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0K PiDCoHRlc3RzL2ttc19mbGlwLmPCoMKgwqDCoMKgwqDCoMKgwqDCoHzCoMKgMyArLS0KPiDCoHRl c3RzL2ttc19wYW5lbF9maXR0aW5nLmMgfCAxNSArKystLS0tLS0tLS0tLS0KPiDCoHRlc3RzL2tt c19wbGFuZV9zY2FsaW5nLmMgfMKgwqA3ICstLS0tLS0KPiDCoHRlc3RzL2ttc19yb3RhdGlvbl9j cmMuY8KgwqB8IDE2ICsrLS0tLS0tLS0tLS0tLS0KPiDCoHRlc3RzL2ttc19zZXRtb2RlLmPCoMKg wqDCoMKgwqDCoHwgMTIgKysrLS0tLS0tLS0tCj4gwqA1IGZpbGVzIGNoYW5nZWQsIDEwIGluc2Vy dGlvbnMoKyksIDQzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfZmxp cC5jIGIvdGVzdHMva21zX2ZsaXAuYwo+IGluZGV4IGI0M2U3NzEyM2U3Zi4uM2Q2ZmU5NDhkM2Ji IDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2ttc19mbGlwLmMKPiArKysgYi90ZXN0cy9rbXNfZmxpcC5j Cj4gQEAgLTEzMzIsOCArMTMzMiw3IEBAIHN0YXRpYyB2b2lkIHJ1bl90ZXN0X29uX2NydGNfc2V0 KHN0cnVjdAo+IHRlc3Rfb3V0cHV0ICpvLCBpbnQgKmNydGNfaWR4cywKPiDCoAlpZ3RfaW5mbygi XG4lczogUEFTU0VEXG5cbiIsIHRlc3RfbmFtZSk7Cj4gwqAKPiDCoG91dDoKPiAtCWlmIChvLT5m Yl9pZHNbMl0pCj4gLQkJaWd0X3JlbW92ZV9mYihkcm1fZmQsICZvLT5mYl9pbmZvWzJdKTsKPiAr CWlndF9yZW1vdmVfZmIoZHJtX2ZkLCAmby0+ZmJfaW5mb1syXSk7Cj4gwqAJaWd0X3JlbW92ZV9m Yihkcm1fZmQsICZvLT5mYl9pbmZvWzFdKTsKPiDCoAlpZ3RfcmVtb3ZlX2ZiKGRybV9mZCwgJm8t PmZiX2luZm9bMF0pOwo+IMKgCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19wYW5lbF9maXR0aW5n LmMgYi90ZXN0cy9rbXNfcGFuZWxfZml0dGluZy5jCj4gaW5kZXggZTBjYTZjY2E4ZTZhLi5iM2Nl ZTIyM2E4ZTcgMTAwNjQ0Cj4gLS0tIGEvdGVzdHMva21zX3BhbmVsX2ZpdHRpbmcuYwo+ICsrKyBi L3Rlc3RzL2ttc19wYW5lbF9maXR0aW5nLmMKPiBAQCAtNTEsMTAgKzUxLDcgQEAgc3RhdGljIHZv aWQgcHJlcGFyZV9jcnRjKGRhdGFfdCAqZGF0YSwKPiBpZ3Rfb3V0cHV0X3QgKm91dHB1dCwgZW51 bSBwaXBlIHBpcGUsCj4gwqAJaWd0X291dHB1dF9zZXRfcGlwZShvdXRwdXQsIHBpcGUpOwo+IMKg Cj4gwqAJLyogYmVmb3JlIGFsbG9jYXRpbmcsIGZyZWUgaWYgYW55IG9sZGVyIGZiICovCj4gLQlp ZiAoZGF0YS0+ZmIxLmZiX2lkKSB7Cj4gLQkJaWd0X3JlbW92ZV9mYihkYXRhLT5kcm1fZmQsICZk YXRhLT5mYjEpOwo+IC0JCWRhdGEtPmZiMS5mYl9pZCA9IDA7Cj4gLQl9Cj4gKwlpZ3RfcmVtb3Zl X2ZiKGRhdGEtPmRybV9mZCwgJmRhdGEtPmZiMSk7Cj4gwqAKPiDCoAkvKiBhbGxvY2F0ZSBmYiBm b3IgcGxhbmUgMSAqLwo+IMKgCWlndF9jcmVhdGVfcGF0dGVybl9mYihkYXRhLT5kcm1fZmQsCj4g QEAgLTgzLDE0ICs4MCw4IEBAIHN0YXRpYyB2b2lkIGNsZWFudXBfY3J0YyhkYXRhX3QgKmRhdGEs Cj4gaWd0X291dHB1dF90ICpvdXRwdXQsIGlndF9wbGFuZV90ICpwbGFuZSkKPiDCoHsKPiDCoAlp Z3RfZGlzcGxheV90ICpkaXNwbGF5ID0gJmRhdGEtPmRpc3BsYXk7Cj4gwqAKPiAtCWlmIChkYXRh LT5mYjEuZmJfaWQpIHsKPiAtCQlpZ3RfcmVtb3ZlX2ZiKGRhdGEtPmRybV9mZCwgJmRhdGEtPmZi MSk7Cj4gLQkJZGF0YS0+ZmIxLmZiX2lkID0gMDsKPiAtCX0KPiAtCWlmIChkYXRhLT5mYjIuZmJf aWQpIHsKPiAtCQlpZ3RfcmVtb3ZlX2ZiKGRhdGEtPmRybV9mZCwgJmRhdGEtPmZiMik7Cj4gLQkJ ZGF0YS0+ZmIyLmZiX2lkID0gMDsKPiAtCX0KPiArCWlndF9yZW1vdmVfZmIoZGF0YS0+ZHJtX2Zk LCAmZGF0YS0+ZmIxKTsKPiArCWlndF9yZW1vdmVfZmIoZGF0YS0+ZHJtX2ZkLCAmZGF0YS0+ZmIy KTsKPiDCoAo+IMKgCWlmIChwbGFuZS0+dHlwZSAhPSBEUk1fUExBTkVfVFlQRV9QUklNQVJZKSB7 Cj4gwqAJCWlndF9wbGFuZV90ICpwcmltYXJ5Owo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfcGxh bmVfc2NhbGluZy5jIGIvdGVzdHMva21zX3BsYW5lX3NjYWxpbmcuYwo+IGluZGV4IDIwOGY5MjYy Zjg0Yi4uMzE3MTMzMWM5NmI4IDEwMDY0NAo+IC0tLSBhL3Rlc3RzL2ttc19wbGFuZV9zY2FsaW5n LmMKPiArKysgYi90ZXN0cy9rbXNfcGxhbmVfc2NhbGluZy5jCj4gQEAgLTYyLDEzICs2Miw4IEBA IHN0YXRpYyB2b2lkIGNsZWFudXBfZmJzKGRhdGFfdCAqZGF0YSkKPiDCoHsKPiDCoAlpbnQgaTsK PiDCoAo+IC0JZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoZGF0YS0+ZmIpOyBpKyspIHsKPiAt CQlpZiAoIWRhdGEtPmZiW2ldLmZiX2lkKQo+IC0JCQljb250aW51ZTsKPiAtCj4gKwlmb3IgKGkg PSAwOyBpIDwgQVJSQVlfU0laRShkYXRhLT5mYik7IGkrKykKPiDCoAkJaWd0X3JlbW92ZV9mYihk YXRhLT5kcm1fZmQsICZkYXRhLT5mYltpXSk7Cj4gLQkJZGF0YS0+ZmJbaV0uZmJfaWQgPSAwOwo+ IC0JfQo+IMKgfQo+IMKgCj4gwqBzdGF0aWMgdm9pZCBjbGVhbnVwX2NydGMoZGF0YV90ICpkYXRh KQo+IGRpZmYgLS1naXQgYS90ZXN0cy9rbXNfcm90YXRpb25fY3JjLmMgYi90ZXN0cy9rbXNfcm90 YXRpb25fY3JjLmMKPiBpbmRleCBmNjU1NjJiYWU5ZWIuLjRmNTZkM2Q2NWRiNCAxMDA2NDQKPiAt LS0gYS90ZXN0cy9rbXNfcm90YXRpb25fY3JjLmMKPiArKysgYi90ZXN0cy9rbXNfcm90YXRpb25f Y3JjLmMKPiBAQCAtMTc0LDE3ICsxNzQsMTAgQEAgc3RhdGljIHZvaWQgcHJlcGFyZV9jcnRjKGRh dGFfdCAqZGF0YSwKPiBpZ3Rfb3V0cHV0X3QgKm91dHB1dCwgZW51bSBwaXBlIHBpcGUsCj4gwqAK PiDCoHN0YXRpYyB2b2lkIHJlbW92ZV9mYnMoZGF0YV90ICpkYXRhKQo+IMKgewo+IC0JaWYgKCFk YXRhLT5mYi5mYl9pZCkKPiAtCQlyZXR1cm47Cj4gLQo+IMKgCWlndF9yZW1vdmVfZmIoZGF0YS0+ Z2Z4X2ZkLCAmZGF0YS0+ZmIpOwo+IMKgCWlndF9yZW1vdmVfZmIoZGF0YS0+Z2Z4X2ZkLCAmZGF0 YS0+ZmJfcmVmZXJlbmNlKTsKPiDCoAlpZ3RfcmVtb3ZlX2ZiKGRhdGEtPmdmeF9mZCwgJmRhdGEt PmZiX3Vucm90YXRlZCk7Cj4gLQo+IC0JaWYgKGRhdGEtPmZiX2ZsaXAuZmJfaWQpCj4gLQkJaWd0 X3JlbW92ZV9mYihkYXRhLT5nZnhfZmQsICZkYXRhLT5mYl9mbGlwKTsKPiAtCj4gLQlkYXRhLT5m Yl9mbGlwLmZiX2lkID0gZGF0YS0+ZmIuZmJfaWQgPSAwOwo+ICsJaWd0X3JlbW92ZV9mYihkYXRh LT5nZnhfZmQsICZkYXRhLT5mYl9mbGlwKTsKPiDCoH0KPiDCoAo+IMKgZW51bSByZWN0YW5nbGVf dHlwZSB7Cj4gQEAgLTIwNSwxMiArMTk4LDcgQEAgc3RhdGljIHZvaWQgcHJlcGFyZV9mYnMoZGF0 YV90ICpkYXRhLAo+IGlndF9vdXRwdXRfdCAqb3V0cHV0LAo+IMKgCXVpbnQzMl90IHBpeGVsX2Zv cm1hdCA9IGRhdGEtPm92ZXJyaWRlX2ZtdCA/Ogo+IERSTV9GT1JNQVRfWFJHQjg4ODg7Cj4gwqAJ Y29uc3QgZmxvYXQgZmxpcF9vcGFjaXR5ID0gMC43NTsKPiDCoAo+IC0JaWYgKGRhdGEtPmZiLmZi X2lkKSB7Cj4gLQkJaWd0X3BsYW5lX3NldF9mYihwbGFuZSwgTlVMTCk7Cj4gLQkJaWd0X2Rpc3Bs YXlfY29tbWl0MihkaXNwbGF5LCBkaXNwbGF5LT5pc19hdG9taWMgPwo+IENPTU1JVF9BVE9NSUMg OiBDT01NSVRfVU5JVkVSU0FMKTsKPiAtCj4gLQkJcmVtb3ZlX2ZicyhkYXRhKTsKPiAtCX0KPiAr CXJlbW92ZV9mYnMoZGF0YSk7Cj4gwqAKPiDCoAlpZ3RfcGxhbmVfc2V0X3JvdGF0aW9uKHBsYW5l LCBJR1RfUk9UQVRJT05fMCk7Cj4gwqAKPiBkaWZmIC0tZ2l0IGEvdGVzdHMva21zX3NldG1vZGUu YyBiL3Rlc3RzL2ttc19zZXRtb2RlLmMKPiBpbmRleCAwNjI0MWIxOTFhMGYuLjQ3ZDA0ZmI1Zjdi MSAxMDA2NDQKPiAtLS0gYS90ZXN0cy9rbXNfc2V0bW9kZS5jCj4gKysrIGIvdGVzdHMva21zX3Nl dG1vZGUuYwo+IEBAIC0zNjEsNiArMzYxLDkgQEAgc3RhdGljIHZvaWQgY2xlYW51cF9jcnRjcyhz dHJ1Y3QgY3J0Y19jb25maWcKPiAqY3J0Y3MsIGludCBjcnRjX2NvdW50KQo+IMKgCWludCBpOwo+ IMKgCj4gwqAJZm9yIChpID0gMDsgaSA8IGNydGNfY291bnQ7IGkrKykgewo+ICsJCWlndF9yZW1v dmVfZmIoZHJtX2ZkLCAmY3J0Y3NbaV0uZmJfaW5mbyk7Cj4gKwkJZHJtTW9kZVNldENydGMoZHJt X2ZkLCBjcnRjc1tpXS5jcnRjX2lkLCAwLCAwLCAwLAo+IE5VTEwsIDAsIE5VTEwpOwo+ICsKPiDC oAkJZnJlZShjcnRjc1tpXS5jY29uZnMpOwo+IMKgCX0KPiDCoH0KPiBAQCAtNTc3LDE1ICs1ODAs NiBAQCBzdGF0aWMgdm9pZCB0ZXN0X2NydGNfY29uZmlnKGNvbnN0IHN0cnVjdAo+IHRlc3RfY29u ZmlnICp0Y29uZiwKPiDCoAlpZiAocmV0ID09IDAgJiYgdGNvbmYtPmZsYWdzICYgVEVTVF9USU1J TkdTKQo+IMKgCQljaGVja190aW1pbmdzKGNydGNzWzBdLmNydGNfaWR4LCAmY3J0Y3NbMF0ubW9k ZSk7Cj4gwqAKPiAtCWZvciAoaSA9IDA7IGkgPCBjcnRjX2NvdW50OyBpKyspIHsKPiAtCQlpZiAo Y3J0Y3NbaV0uZmJfaW5mby5mYl9pZCkgewo+IC0JCQlkcm1Nb2RlU2V0Q3J0Yyhkcm1fZmQsIGNy dGNzW2ldLmNydGNfaWQsIDAsCj4gMCwgMCwgTlVMTCwKPiAtCQkJCQkwLCBOVUxMKTsKPiAtCQkJ ZHJtTW9kZVJtRkIoZHJtX2ZkLCBjcnRjc1tpXS5mYl9pbmZvLmZiX2lkKTsKPiAtCQkJY3J0Y3Nb aV0uZmJfaW5mby5mYl9pZCA9IDA7Cj4gLQkJfQo+IC0JfQo+IC0KPiDCoAlyZXR1cm47Cj4gwqB9 Cj4gwqAKLS0gCk1pa2EgS2Fob2xhIC0gSW50ZWwgT1RDCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2lndC1kZXYK