From: "Szwichtenberg, Radoslaw" <radoslaw.szwichtenberg@intel.com>
To: "Dec, Katarzyna" <katarzyna.dec@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib: Move common gpgpu/media functions to gpu_fill library
Date: Wed, 28 Mar 2018 14:17:55 +0000 [thread overview]
Message-ID: <1522246672.3030.8.camel@intel.com> (raw)
In-Reply-To: <20180327133648.30510-1-katarzyna.dec@intel.com>
On Tue, 2018-03-27 at 15:36 +0200, Katarzyna Dec wrote:
> Gpgpu_fill and media_fill libraries are very similar and many
> functions can be shared. I have created library gpu_fill with
> all functions needed for implementing gpgpu_fill and media_fill
> tests for all Gens. Duplicates, e.g. where only name was changed,
> were removed. The earliest common function remained.
>
> -static void
> -gen8_emit_state_base_address(struct intel_batchbuffer *batch)
> -{
> - OUT_BATCH(GEN8_STATE_BASE_ADDRESS | (16 - 2));
> -
> - /* general */
> - OUT_BATCH(0 | (0x78 << 4) | (0 << 1) | BASE_ADDRESS_MODIFY);
> - OUT_BATCH(0);
> -
Why did you choose
> + OUT_BATCH(0 | BASE_ADDRESS_MODIFY);
and not the one above? Does it make any difference which is used?
Radek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-03-28 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 13:36 [igt-dev] [PATCH i-g-t 1/3] lib: Move common gpgpu/media functions to gpu_fill library Katarzyna Dec
2018-03-27 13:36 ` [igt-dev] [PATCH i-g-t 2/3] lib: Adjust refactored gpu_fill library to our coding style Katarzyna Dec
2018-03-27 13:36 ` [igt-dev] [PATCH i-g-t v2] lib/gpgpu_fill: Add missing configuration parameters for gpgpu_fill Katarzyna Dec
2018-03-27 23:52 ` [igt-dev] [PATCH i-g-t 1/3] lib: Move common gpgpu/media functions to gpu_fill library Daniele Ceraolo Spurio
2018-03-28 13:32 ` Szwichtenberg, Radoslaw
2018-03-28 18:50 ` Daniele Ceraolo Spurio
2018-04-04 13:25 ` Katarzyna Dec
2018-03-28 14:17 ` Szwichtenberg, Radoslaw [this message]
2018-04-04 13:20 ` Katarzyna Dec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522246672.3030.8.camel@intel.com \
--to=radoslaw.szwichtenberg@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.dec@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox