From: "Kalamarz, Lukasz" <lukasz.kalamarz@intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t v5 4/4] lib/intel_batchbuffer: Move batch functions from media/render/gpgpu libs
Date: Tue, 24 Apr 2018 08:41:39 +0000 [thread overview]
Message-ID: <1524559298.3558.56.camel@intel.com> (raw)
In-Reply-To: <f3d9b02c-d662-ac20-7b8c-675099ab054f@intel.com>
Thank You Kasia and Daniele for review process in this series :)
---
Lukasz
On Mon, 2018-04-23 at 10:21 -0700, Daniele Ceraolo Spurio wrote:
>
> On 23/04/18 07:20, Lukasz Kalamarz wrote:
> > Batch functions were copy/pasted across several libs.
> > With moving it into intel_batchbuffer lib test can now be
> > easly maintained without worrying that we forgot to modify
> > older version of lib.
> >
> > v2: Added documentation into lib and rebased patch
> > v3: Fixed typos and rebased patch
> > v4: Fixed documentation issues
> > v5: Rename, clean up of leftovers from previous version
> > and documentation polishing
> >
> > Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz@intel.com>
> > Cc: Katarzyna Dec <katarzyna.dec@intel.com>
> > Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > ---
> > lib/gpgpu_fill.c | 6 ++--
> > lib/gpu_fill.c | 67 +++++++++++-------------------------
> > ----
> > lib/gpu_fill.h | 15 ---------
> > lib/intel_batchbuffer.c | 80
> > +++++++++++++++++++++++++++++++++++++++++++-----
> > lib/intel_batchbuffer.h | 15 +++++++--
> > lib/media_fill_gen7.c | 2 +-
> > lib/media_fill_gen8.c | 2 +-
> > lib/media_fill_gen9.c | 2 +-
> > lib/media_spin.c | 62 ++++++++--------------------------
> > ---
> > lib/rendercopy_gen6.c | 68 +++++++++++-------------------------
> > -----
> > lib/rendercopy_gen7.c | 64 +++++++++---------------------------
> > --
> > lib/rendercopy_gen8.c | 81 +++++++++++++++---------------------
> > -------------
> > lib/rendercopy_gen9.c | 81 +++++++++++++++---------------------
> > -------------
> > 13 files changed, 201 insertions(+), 344 deletions(-)
> >
>
> <snip>
>
> > +void *
> > +intel_batchbuffer_subdata_alloc(struct intel_batchbuffer *batch,
> > uint32_t size,
> > + uint32_t align)
> > +{
> > + uint32_t offset = intel_batchbuffer_align(batch, align);
> > +
> > + igt_assert(size < intel_batchbuffer_space(batch));
>
> you can use "<=" here. With this fixed:
>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>
> Daniele
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-04-24 8:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 14:20 [igt-dev] [PATCH i-g-t v5 1/4] lib/rendercopy_gen7: Reorganizing batch allocations Lukasz Kalamarz
2018-04-23 14:20 ` [igt-dev] [PATCH i-g-t v5 2/4] lib/rendercopy_gen7: Cosmetic changes in code Lukasz Kalamarz
2018-04-23 17:09 ` Daniele Ceraolo Spurio
2018-04-23 14:20 ` [igt-dev] [PATCH i-g-t v5 3/4] lib/intel_batchbuffer: Removal of state variable from a intel_batchbuffer structure Lukasz Kalamarz
2018-04-23 14:20 ` [igt-dev] [PATCH i-g-t v5 4/4] lib/intel_batchbuffer: Move batch functions from media/render/gpgpu libs Lukasz Kalamarz
2018-04-23 17:21 ` Daniele Ceraolo Spurio
2018-04-24 8:41 ` Kalamarz, Lukasz [this message]
2018-04-23 15:51 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,v5,1/4] lib/rendercopy_gen7: Reorganizing batch allocations Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524559298.3558.56.camel@intel.com \
--to=lukasz.kalamarz@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox