* [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID
@ 2018-04-27 23:05 José Roberto de Souza
2018-04-27 23:36 ` Paulo Zanoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: José Roberto de Souza @ 2018-04-27 23:05 UTC (permalink / raw)
To: igt-dev; +Cc: Rodrigo Vivi
This PCI ID was recently added to kernel in commit
'672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
but not added here.
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: James Ausmus <james.ausmus@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
lib/i915_pciids.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index 0b2ba46f..334d6321 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -354,7 +354,8 @@
INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \
INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
- INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
+ INTEL_VGA_DEVICE(0x591D, info), /* WKS GT2 */ \
+ INTEL_VGA_DEVICE(0x591C, info) /* ULX GT2 */
#define INTEL_KBL_GT3_IDS(info) \
INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
--
2.17.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID
2018-04-27 23:05 [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID José Roberto de Souza
@ 2018-04-27 23:36 ` Paulo Zanoni
2018-04-28 0:00 ` Souza, Jose
2018-04-30 13:23 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-04-30 17:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Paulo Zanoni @ 2018-04-27 23:36 UTC (permalink / raw)
To: José Roberto de Souza, igt-dev; +Cc: Rodrigo Vivi
Em Sex, 2018-04-27 às 16:05 -0700, José Roberto de Souza escreveu:
> This PCI ID was recently added to kernel in commit
> '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
> but not added here.
Please see "[PATCH igt 1/3] lib: sync with the newer i915_pciids.h from
the Kernel (KBL + ICL)".
We should just be copying i915_pciids.h from the Kernel to here, so
both files stay in sync and differences are easier to spot.
This also means that the new ID should be added in a different spot.
Thanks,
Paulo
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: James Ausmus <james.ausmus@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> lib/i915_pciids.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 0b2ba46f..334d6321 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -354,7 +354,8 @@
> INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \
> INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
> INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
> - INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> + INTEL_VGA_DEVICE(0x591D, info), /* WKS GT2 */ \
> + INTEL_VGA_DEVICE(0x591C, info) /* ULX GT2 */
>
> #define INTEL_KBL_GT3_IDS(info) \
> INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID
2018-04-27 23:36 ` Paulo Zanoni
@ 2018-04-28 0:00 ` Souza, Jose
0 siblings, 0 replies; 5+ messages in thread
From: Souza, Jose @ 2018-04-28 0:00 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org, Zanoni, Paulo R; +Cc: Vivi, Rodrigo
On Fri, 2018-04-27 at 16:36 -0700, Paulo Zanoni wrote:
> Em Sex, 2018-04-27 às 16:05 -0700, José Roberto de Souza escreveu:
> > This PCI ID was recently added to kernel in commit
> > '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
> > but not added here.
>
> Please see "[PATCH igt 1/3] lib: sync with the newer i915_pciids.h
> from
> the Kernel (KBL + ICL)".
Oh I missed that patch.
So lets drop this one and go with yours.
>
> We should just be copying i915_pciids.h from the Kernel to here, so
> both files stay in sync and differences are easier to spot.
>
> This also means that the new ID should be added in a different spot.
>
> Thanks,
> Paulo
>
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: James Ausmus <james.ausmus@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > lib/i915_pciids.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> > index 0b2ba46f..334d6321 100644
> > --- a/lib/i915_pciids.h
> > +++ b/lib/i915_pciids.h
> > @@ -354,7 +354,8 @@
> > INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \
> > INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
> > INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
> > - INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> > + INTEL_VGA_DEVICE(0x591D, info), /* WKS GT2 */ \
> > + INTEL_VGA_DEVICE(0x591C, info) /* ULX GT2 */
> >
> > #define INTEL_KBL_GT3_IDS(info) \
> > INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/kbl: Add missing Kaby Lake PCI ID
2018-04-27 23:05 [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID José Roberto de Souza
2018-04-27 23:36 ` Paulo Zanoni
@ 2018-04-30 13:23 ` Patchwork
2018-04-30 17:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-04-30 13:23 UTC (permalink / raw)
To: Souza, Jose; +Cc: igt-dev
== Series Details ==
Series: lib/kbl: Add missing Kaby Lake PCI ID
URL : https://patchwork.freedesktop.org/series/42435/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4112 -> IGTPW_1307 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42435/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1307 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cnl-psr: PASS -> DMESG-WARN (fdo#104951)
fi-cnl-y3: PASS -> DMESG-WARN (fdo#104951)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: NOTRUN -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-ivb-3520m: DMESG-WARN (fdo#106084) -> PASS
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
== Participating hosts (39 -> 35) ==
Missing (4): fi-hsw-4770r fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq
== Build changes ==
* IGT: IGT_4452 -> IGTPW_1307
CI_DRM_4112: 423a00794c9d9610a71d8a02cd3bc17c6fe5fae1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1307: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1307/
IGT_4452: 29ae12bd764e3b1876356e7628a32192b4ec9066 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4452: 04a2952c5b3782eb03cb136bb16d89daaf243f14 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1307/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/kbl: Add missing Kaby Lake PCI ID
2018-04-27 23:05 [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID José Roberto de Souza
2018-04-27 23:36 ` Paulo Zanoni
2018-04-30 13:23 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-04-30 17:35 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-04-30 17:35 UTC (permalink / raw)
To: Souza, Jose; +Cc: igt-dev
== Series Details ==
Series: lib/kbl: Add missing Kaby Lake PCI ID
URL : https://patchwork.freedesktop.org/series/42435/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4452_full -> IGTPW_1307_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1307_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1307_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/42435/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1307_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-bsd2:
shard-kbl: SKIP -> PASS
igt@kms_busy@extended-pageflip-hang-oldfb-render-b:
shard-snb: SKIP -> PASS
== Known issues ==
Here are the changes found in IGTPW_1307_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105312)
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105707)
igt@kms_flip@plain-flip-ts-check-interruptible:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: PASS -> FAIL (fdo#103925) +1
==== Possible fixes ====
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: INCOMPLETE (fdo#103665, fdo#106023) -> PASS
igt@kms_flip@absolute-wf_vblank-interruptible:
shard-apl: FAIL (fdo#106087) -> PASS
igt@kms_flip@dpms-vs-vblank-race-interruptible:
shard-glk: FAIL (fdo#103060) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#102887) -> PASS
igt@kms_flip@plain-flip-fb-recreate:
shard-hsw: FAIL (fdo#100368) -> PASS +1
igt@kms_flip@wf_vblank-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-snb: FAIL (fdo#103166) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#105312 https://bugs.freedesktop.org/show_bug.cgi?id=105312
fdo#105707 https://bugs.freedesktop.org/show_bug.cgi?id=105707
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106087 https://bugs.freedesktop.org/show_bug.cgi?id=106087
== Participating hosts (8 -> 5) ==
Missing (3): pig-skl-6600 pig-glk-j4005 pig-hsw-4770r
== Build changes ==
* IGT: IGT_4452 -> IGTPW_1307
* Linux: CI_DRM_4109 -> CI_DRM_4112
CI_DRM_4109: e701a0e6315dc85615f83b2ee14d9cb2f425d97d @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4112: 423a00794c9d9610a71d8a02cd3bc17c6fe5fae1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1307: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1307/
IGT_4452: 29ae12bd764e3b1876356e7628a32192b4ec9066 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4452: 04a2952c5b3782eb03cb136bb16d89daaf243f14 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1307/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-30 17:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-27 23:05 [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID José Roberto de Souza
2018-04-27 23:36 ` Paulo Zanoni
2018-04-28 0:00 ` Souza, Jose
2018-04-30 13:23 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-04-30 17:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox