From: Mika Kahola <mika.kahola@intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling
Date: Wed, 16 May 2018 15:48:41 +0300 [thread overview]
Message-ID: <1526474921.11552.89.camel@intel.com> (raw)
In-Reply-To: <20180516114537.GA8502@ahiler-desk1.ger.corp.intel.com>
On Wed, 2018-05-16 at 14:45 +0300, Arkadiusz Hiler wrote:
> On Wed, May 16, 2018 at 01:36:31PM +0200, Daniel Vetter wrote:
> >
> > On Tue, May 15, 2018 at 01:28:19PM +0300, Mika Kahola wrote:
> > >
> > > Make sure framebuffer compression is disabled when running this
> > > test.
> > Why? Commit message shouldn't just explain what you're doing, but
> > much
> > more important is why you're doing something.
> > -Daniel
> Since CI_TEST tag is used in the title I assume it's just to see how
> the
> change (mis)behaves, without any interest in having it
> reviewed/merged.
That's right. The patch was only meant to exclude that fbc has nothing
to do with crc mismatches that we keep receiving from CI runs. The
patch was not meant for a review.
> -Arek
--
Mika Kahola - Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-05-16 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 10:28 [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Mika Kahola
2018-05-15 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip_tiling Patchwork
2018-05-15 21:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-05-16 11:36 ` [igt-dev] [PATCH CI_TEST] tests/kms_flip_tiling Daniel Vetter
2018-05-16 11:45 ` Arkadiusz Hiler
2018-05-16 12:48 ` Mika Kahola [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-16 11:57 Mika Kahola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526474921.11552.89.camel@intel.com \
--to=mika.kahola@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox