From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] tests/kms_ccs: Don't populate igt_fb structs with stack garbage
Date: Wed, 23 May 2018 10:58:12 -0700 [thread overview]
Message-ID: <1527098292.2226.44.camel@intel.com> (raw)
In-Reply-To: <20180518204154.21990-1-ville.syrjala@linux.intel.com>
On Fri, 2018-05-18 at 23:41 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Clear the igt_fb struct to make sure no stack garbage is left in any
> members we don't explicitly initialize.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> tests/kms_ccs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> index 63298f137abb..e1ee58801ac3 100644
> --- a/tests/kms_ccs.c
> +++ b/tests/kms_ccs.c
> @@ -280,6 +280,8 @@ static void generate_fb(data_t *data, struct
> igt_fb *fb,
> int ret;
> uint32_t ccs_handle;
>
> + memset(fb, 0, sizeof(*fb));
> +
> /* Use either compressed or Y-tiled to test. However, given
> the lack of
> * available bandwidth, we use linear for the primary plane
> when
> * testing sprites, since we cannot fit two CCS planes into
> the
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-05-23 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 20:41 [igt-dev] [PATCH i-g-t 1/3] tests/kms_ccs: Don't populate igt_fb structs with stack garbage Ville Syrjala
2018-05-18 20:41 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_plane_scaling: Allow clip test to fail with YUV Ville Syrjala
2018-05-18 20:41 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_plane_scaling: Reduce the fb size 8x8 from 9x9 Ville Syrjala
2018-05-18 21:16 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] tests/kms_ccs: Don't populate igt_fb structs with stack garbage Patchwork
2018-05-19 8:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-05-23 17:58 ` Dhinakaran Pandiyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527098292.2226.44.camel@intel.com \
--to=dhinakaran.pandiyan@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox