From: "Kalamarz, Lukasz" <lukasz.kalamarz@intel.com>
To: "Dec, Katarzyna" <katarzyna.dec@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 1/5] lib/gen7_render: include gen6_render header
Date: Mon, 11 Jun 2018 12:42:13 +0000 [thread overview]
Message-ID: <1528720931.4203.53.camel@intel.com> (raw)
In-Reply-To: <20180611073139.GE8119@kdec5-desk.ger.corp.intel.com>
On Mon, 2018-06-11 at 09:31 +0200, Katarzyna Dec wrote:
> On Fri, Jun 08, 2018 at 01:38:51PM +0200, Lukasz Kalamarz wrote:
> > We would like to start including previous gens headers,
> > like we are doing in genX_media headers. For render we were
> > missing proper includes in gen7 and gen8 headers. This patch
> > fixes gen7 issue and also remove redefinition of two enums.
>
> There is something wrong with this commit msg what makes it hard
> to understang.
> Maybe sth like this:
> After removing duplications from gen6_render (others??) I would like
> to use this library for gen7_render. Some 'proper??' includes
> are missing for gen7 and gen8 headers.
> I am also removing redefinition of 2 enums (they are the same as for
> gen6).
>
> Maybe sth like this? (it is not perfect :))
> Kasia
>
Will fix that in next version of patch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-06-11 12:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 11:38 [igt-dev] [PATCH i-g-t 1/5] lib/gen7_render: include gen6_render header Lukasz Kalamarz
2018-06-08 11:38 ` [igt-dev] [PATCH i-g-t 2/5] lib/gen6_render.h: Use gen6 definitions where it is possible Lukasz Kalamarz
2018-06-11 7:44 ` Katarzyna Dec
2018-06-11 12:46 ` Kalamarz, Lukasz
2018-06-11 13:40 ` Katarzyna Dec
2018-06-08 11:38 ` [igt-dev] [PATCH i-g-t 3/5] lib/gen7_render: Drop duplicated definitions Lukasz Kalamarz
2018-06-08 11:38 ` [igt-dev] [PATCH i-g-t 4/5] lib/gen8_render: Cleanup of libs Lukasz Kalamarz
2018-06-11 7:58 ` Katarzyna Dec
2018-06-11 12:50 ` Kalamarz, Lukasz
2018-06-11 13:38 ` Katarzyna Dec
2018-06-08 11:38 ` [igt-dev] [PATCH i-g-t 5/5] lib/gen9_render: Header cleanup Lukasz Kalamarz
2018-06-11 7:59 ` Katarzyna Dec
2018-06-08 12:16 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] lib/gen7_render: include gen6_render header Patchwork
2018-06-08 14:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-06-11 7:31 ` [igt-dev] [PATCH i-g-t 1/5] " Katarzyna Dec
2018-06-11 12:42 ` Kalamarz, Lukasz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528720931.4203.53.camel@intel.com \
--to=lukasz.kalamarz@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.dec@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox