igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Tomi Sarvela <tomi.p.sarvela@intel.com>,
	Martin Peres <martin.peres@linux.intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list.
Date: Mon, 16 Jul 2018 11:29:48 -0700	[thread overview]
Message-ID: <1531765788.7606.69.camel@intel.com> (raw)
In-Reply-To: <20180716174310.GM4262@intel.com>

On Mon, 2018-07-16 at 10:43 -0700, Rodrigo Vivi wrote:
> On Fri, Jul 13, 2018 at 04:39:04PM -0700, Dhinakaran Pandiyan wrote:
> > 
> > We do not have PSR panels on shards machines, so this is the only
> > way to
> > test PSR in CI.
> We definitely need this...
> but we need to ckeck the overall time and ff limits here as well...

 From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runt
imes0.log
 19.46 igt@kms_psr@suspend pass
  4.78 igt@kms_psr@dpms pass
  3.37 igt@kms_psr@sprite_blt pass
  3.35 igt@kms_psr@sprite_plane_onoff pass
  3.35 igt@kms_psr@sprite_plane_move pass
  3.35 igt@kms_psr@sprite_mmap_gtt pass
  3.35 igt@kms_psr@sprite_mmap_cpu pass
  3.34 igt@kms_psr@sprite_render pass
  3.34 igt@kms_psr@primary_render pass
  3.34 igt@kms_psr@primary_page_flip pass
  3.33 igt@kms_psr@primary_mmap_cpu pass
  3.31 igt@kms_psr@primary_mmap_gtt pass
  3.31 igt@kms_psr@primary_blt pass
  3.29 igt@kms_psr@cursor_render pass
  3.29 igt@kms_psr@cursor_plane_onoff pass
  3.29 igt@kms_psr@cursor_plane_move pass
  3.29 igt@kms_psr@cursor_mmap_gtt pass
  3.29 igt@kms_psr@cursor_mmap_cpu pass
  3.29 igt@kms_psr@cursor_blt pass
  3.14 igt@kms_psr@basic pass
  3.11 igt@kms_psr@no_drrs pass

Each test is under the 30s limit and kms_psr@suspend is the only that
gets closer to the limit.

Without kms_psr subtests 730.18s TOTAL
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4488/fi-kbl-r/runtimes0
.log
With kms_psr subtests 626.50s TOTAL
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1588/fi-kbl-r/runtimes0.
log

> ditto on the kms_frontbuffer_tracking one...

From https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-whl-u/runti
mes0.log

  7.38 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwri
te pass
  6.23 igt@kms_frontbuffer_tracking@fbcpsr-1p-indfb-fliptrack pass
  5.79 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap
-cpu pass
  5.71 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
-cpu pass
  5.69 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-blt
pass
  5.53 igt@kms_frontbuffer_tracking@psr-farfromfence pass
  5.51 igt@kms_frontbuffer_tracking@fbcpsr-farfromfence pass
  5.48 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-m
map-wc pass
5.20 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-g
tt pass
  5.19 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
-wc pass
  5.18 igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt pass
  5.18 igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap
-gtt pass
  5.16 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-m
map-gtt pass
  5.14 igt@gem_sync@basic-each pass
  5.10 igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt pass
  5.08 igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-gtt pass
  4.96 igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap
-gtt pass
  4.74 igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap
-gtt pass
  4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-m
map-gtt pass
  4.73 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-m
map-gtt pass
  4.72 igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap
-gtt pass
  4.62 igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-m
map-gtt skip
  4.61 igt@kms_frontbuffer_tracking@fbcpsr-1p-shrfb-fliptrack skip
  4.58 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-m
map-gtt skip
  4.57 igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-r
ender skip
  3.63 igt@kms_frontbuffer_tracking@fbcpsr-stridechange skip

Same here, all are under the individual test limit.

I am not sure what the overall time limit is, this is what I see - 
Without PSR frontbuffer 742.12s
(https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_4498/fi-skl-6600u/runt
imes0.log)
With PSR frontbuffer tests 693.63s
(https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1590/fi-skl-6600u/runti
mes0.log)

Looks like there are others tests with a larger variance negating the
impact of new PSR tests.

-DK

> 
> > 
> > 
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> >  tests/intel-ci/fast-feedback.testlist | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-
> > ci/fast-feedback.testlist
> > index aa861d39..e262d024 100644
> > --- a/tests/intel-ci/fast-feedback.testlist
> > +++ b/tests/intel-ci/fast-feedback.testlist
> > @@ -244,6 +244,26 @@ igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
> >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b
> >  igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c
> >  igt@kms_psr@basic
> > +igt@kms_psr@no_drrs
> > +igt@kms_psr@primary_page_flip
> > +igt@kms_psr@primary_mmap_gtt
> > +igt@kms_psr@primary_mmap_cpu
> > +igt@kms_psr@primary_blt
> > +igt@kms_psr@primary_render
> > +igt@kms_psr@sprite_mmap_gtt
> > +igt@kms_psr@sprite_mmap_cpu
> > +igt@kms_psr@sprite_blt
> > +igt@kms_psr@sprite_render
> > +igt@kms_psr@sprite_plane_move
> > +igt@kms_psr@sprite_plane_onoff
> > +igt@kms_psr@cursor_mmap_gtt
> > +igt@kms_psr@cursor_mmap_cpu
> > +igt@kms_psr@cursor_blt
> > +igt@kms_psr@cursor_render
> > +igt@kms_psr@cursor_plane_move
> > +igt@kms_psr@cursor_plane_onoff
> > +igt@kms_psr@dpms
> > +igt@kms_psr@suspend
> >  igt@kms_setmode@basic-clone-single-crtc
> >  igt@kms_sink_crc_basic
> >  igt@pm_backlight@basic-brightness
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-07-16 18:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 23:39 [igt-dev] [PATCH i-g-t] tests/psr: Add PSR tests to fast-feedback list Dhinakaran Pandiyan
2018-07-14  0:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-07-14  0:28 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
2018-07-14  6:05   ` Dhinakaran Pandiyan
2018-07-14  1:08 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2018-07-14  6:37 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-07-14  8:03 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-07-16 17:43 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
2018-07-16 18:29   ` Dhinakaran Pandiyan [this message]
2018-07-17  5:13     ` Rodrigo Vivi
2018-07-17  7:52       ` Martin Peres
2018-07-17 18:30         ` Dhinakaran Pandiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531765788.7606.69.camel@intel.com \
    --to=dhinakaran.pandiyan@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=martin.peres@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tomi.p.sarvela@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).