From: Mika Kahola <mika.kahola@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_flip: Set duration for subtest from command line
Date: Thu, 09 Aug 2018 14:29:15 +0300 [thread overview]
Message-ID: <1533814155.30780.5.camel@intel.com> (raw)
In-Reply-To: <153381004511.6849.14423157077521872600@skylake-alporthouse-com>
On Thu, 2018-08-09 at 11:20 +0100, Chris Wilson wrote:
> Quoting Mika Kahola (2018-08-09 11:12:33)
> >
> > To reduce the execution time of kms_flip test on CI, let's move
> > subtest
> > duration parameter as command line option. The default subtest
> > duration
> > is 3 seconds for test that require jitter computation and for the
> > rest
> > of the subtests are run only once.
> I disagree with having tests that change between invocations. It's
> far
> too easy for one to make a mistake and not configure the test
> correctly,
> completely fairly to reproduce whatever bug one was seeking.
>
So, should I remove the option of setting the duration for the
subtests? Originally, we have timeouts ranging from 0 to 30 seconds,
depending on a test. Based on my tests on GLK, I found out that tests
that require some jitter computation yields the similar results if we
run it for 3 or 30 seconds. When running less than 3 seconds there are
differences in jitter results. That's why I suggested that 3 seconds
would be a sweetspot for the subtests.
Should I just use 3 seconds timeout for all subtests and discard the
possibility to set the timeout?
> If you think both durations are interesting for different aspects,
> test
> both.
> -Chris
--
Mika Kahola - Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-08-09 11:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 10:12 [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_flip: Binary mode optimizations Mika Kahola
2018-08-09 10:12 ` [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_flip: Set duration for subtest from command line Mika Kahola
2018-08-09 10:20 ` Chris Wilson
2018-08-09 11:29 ` Mika Kahola [this message]
2018-11-08 11:47 ` Maarten Lankhorst
2018-11-08 12:45 ` Kahola, Mika
2018-11-08 13:11 ` Maarten Lankhorst
2018-11-08 14:41 ` Kahola, Mika
2018-08-09 10:12 ` [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_flip: Change 2x tests execution order Mika Kahola
2018-11-08 11:16 ` Maarten Lankhorst
2018-08-09 11:09 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_flip: Binary mode optimizations (rev4) Patchwork
2018-08-09 12:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533814155.30780.5.camel@intel.com \
--to=mika.kahola@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).