From: Mika Kahola <mika.kahola@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later
Date: Thu, 06 Sep 2018 13:51:53 +0300 [thread overview]
Message-ID: <1536231113.20284.18.camel@intel.com> (raw)
In-Reply-To: <1535548332-8413-1-git-send-email-juhapekka.heikkila@gmail.com>
On Wed, 2018-08-29 at 16:12 +0300, Juha-Pekka Heikkila wrote:
> gen11 enables 90/270 rotation for RGB565 mode. IGT would need support
> for
> C8 mode to enable running this subtest on gen11 and later.
>
> v2 (Mika Kahola): Combine gen checks into one comparison. Update
> comment on why bad-pixel-format is disabled beyond gen11.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_rotation_crc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index b994cc5..5ed0c0b 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -557,7 +557,12 @@ igt_main
> data.pos_y = 0;
>
> igt_subtest_f("bad-pixel-format") {
> - igt_require(gen >= 9);
> + /*
> + * gen11 enables RGB565 rotation for 90/270 degrees.
> + * DRM_FORMAT_C8 fmt need to be enabled for IGT if
> want to run
> + * this test on gen11 and later.
> + */
> + igt_require(gen >= 9 && gen < 11);
> data.rotation = IGT_ROTATION_90;
> data.override_fmt = DRM_FORMAT_RGB565;
> test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY,
> true);
Both patches now pushed to IGT.
--
Mika Kahola - Intel OTC
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-09-06 10:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 12:27 [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 Juha-Pekka Heikkila
2018-08-27 12:27 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later Juha-Pekka Heikkila
2018-08-27 13:14 ` Mika Kahola
2018-08-27 16:33 ` Rodrigo Vivi
2018-08-28 13:38 ` Juha-Pekka Heikkila
2018-08-30 0:22 ` Rodrigo Vivi
2018-08-29 13:12 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
2018-09-06 10:51 ` Mika Kahola [this message]
2018-08-27 12:48 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 Patchwork
2018-08-27 13:10 ` [igt-dev] [PATCH i-g-t 1/2] " Mika Kahola
2018-08-28 11:06 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] " Patchwork
2018-08-30 8:07 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2) Patchwork
2018-08-30 8:20 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-09-02 19:34 ` Patchwork
2018-09-02 20:25 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536231113.20284.18.camel@intel.com \
--to=mika.kahola@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).