From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0809B89BAF for ; Fri, 21 Sep 2018 00:06:41 +0000 (UTC) Message-ID: <1537488299.2746.31.camel@intel.com> From: Paulo Zanoni Date: Thu, 20 Sep 2018 17:04:59 -0700 In-Reply-To: <20180719150415.935-6-ville.syrjala@linux.intel.com> References: <20180719150415.935-1-ville.syrjala@linux.intel.com> <20180719150415.935-6-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 06/25] lib/igt_fb: Respect the users choice of stride List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: RW0gUXVpLCAyMDE4LTA3LTE5IMOgcyAxODowMyArMDMwMCwgVmlsbGUgU3lyamFsYSBlc2NyZXZl dToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IAo+IFdlIHByZW50ZWQgdG8gYWxsb3cgdGhlIGNhbGxlciB0byBzcGVjaWZ5IHRoZSBzdHJp ZGUgZXhwbGljaXRseSBmb3IKPiB0aGUKPiBmYi4gQnV0IHdlIGRvbid0IGFjdHVhbGx5IHVzZSB0 aGF0IHVzZXIgc3BlY2lmaWVkIHN0cmlkZSB3aGVuIHdlCj4gY2FsY3VsYXRlIHRoZSByZXF1aXJl IGJvIHNpemUuIEZpeCB0aGF0IG92ZXJzaWdodC4KPiAKClJlcXVpcmVzIHNpbXBsZSByZWJhc2Uu CgpSZXZpZXdlZC1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cgo+ IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIuYyB8IDM3ICsrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDE1IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMK PiBpbmRleCBhZTcxZDk2NzMyMjguLjY3NDgzNTdhZDE2YiAxMDA2NDQKPiAtLS0gYS9saWIvaWd0 X2ZiLmMKPiArKysgYi9saWIvaWd0X2ZiLmMKPiBAQCAtMjE1LDExICsyMTUsMTIgQEAgc3RhdGlj IHVuc2lnbmVkIHBsYW5hcl9oZWlnaHQoc3RydWN0Cj4gZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3Jt YXQsIHVuc2lnbmVkIGhlaWdodAo+ICAKPiAgc3RhdGljIHZvaWQgY2FsY19mYl9zaXplX3BsYW5h cihpbnQgZmQsIGludCB3aWR0aCwgaW50IGhlaWdodCwKPiAgCQkJCXN0cnVjdCBmb3JtYXRfZGVz Y19zdHJ1Y3QgKmZvcm1hdCwKPiAtCQkJCXVpbnQ2NF90IHRpbGluZywgdW5zaWduZWQgKnNpemVf cmV0LAo+IC0JCQkJdW5zaWduZWQgKnN0cmlkZV9yZXQsIHVuc2lnbmVkCj4gKm9mZnNldHMpCj4g KwkJCQl1aW50NjRfdCB0aWxpbmcsIHVuc2lnbmVkIHN0cmlkZSwKPiArCQkJCXVuc2lnbmVkICpz aXplX3JldCwgdW5zaWduZWQKPiAqc3RyaWRlX3JldCwKPiArCQkJCXVuc2lnbmVkICpvZmZzZXRz KQo+ICB7Cj4gIAlpbnQgcGxhbmU7Cj4gLQl1bnNpZ25lZCBzdHJpZGUgPSAwLCB0aWxlX3dpZHRo LCB0aWxlX2hlaWdodDsKPiArCXVuc2lnbmVkIG1heF9zdHJpZGUgPSAwLCB0aWxlX3dpZHRoLCB0 aWxlX2hlaWdodDsKPiAgCj4gIAkqc2l6ZV9yZXQgPSAwOwo+ICAKPiBAQCAtMjI5LDEwICsyMzAs MTMgQEAgc3RhdGljIHZvaWQgY2FsY19mYl9zaXplX3BsYW5hcihpbnQgZmQsIGludAo+IHdpZHRo LCBpbnQgaGVpZ2h0LAo+ICAJCWlndF9nZXRfZmJfdGlsZV9zaXplKGZkLCB0aWxpbmcsIGZvcm1h dC0KPiA+cGxhbmVfYnBwW3BsYW5lXSwgJnRpbGVfd2lkdGgsICZ0aWxlX2hlaWdodCk7Cj4gIAo+ ICAJCXBsYW5lX3N0cmlkZSA9IEFMSUdOKHBsYW5hcl9zdHJpZGUoZm9ybWF0LCB3aWR0aCwKPiBw bGFuZSksIHRpbGVfd2lkdGgpOwo+IC0JCWlmIChzdHJpZGUgPCBwbGFuZV9zdHJpZGUpCj4gLQkJ CXN0cmlkZSA9IHBsYW5lX3N0cmlkZTsKPiArCQlpZiAobWF4X3N0cmlkZSA8IHBsYW5lX3N0cmlk ZSkKPiArCQkJbWF4X3N0cmlkZSA9IHBsYW5lX3N0cmlkZTsKPiAgCX0KPiAgCj4gKwlpZiAoIXN0 cmlkZSkKPiArCQlzdHJpZGUgPSBtYXhfc3RyaWRlOwo+ICsKPiAgCWZvciAocGxhbmUgPSAwOyBw bGFuZSA8IGZvcm1hdC0+bnVtX3BsYW5lczsgcGxhbmUrKykgewo+ICAJCWlmIChvZmZzZXRzKQo+ ICAJCQlvZmZzZXRzW3BsYW5lXSA9ICpzaXplX3JldDsKPiBAQCAtMjUxLDkgKzI1NSw5IEBAIHN0 YXRpYyB2b2lkIGNhbGNfZmJfc2l6ZV9wbGFuYXIoaW50IGZkLCBpbnQKPiB3aWR0aCwgaW50IGhl aWdodCwKPiAgCj4gIHN0YXRpYyB2b2lkIGNhbGNfZmJfc2l6ZV9wYWNrZWQoaW50IGZkLCBpbnQg d2lkdGgsIGludCBoZWlnaHQsCj4gIAkJCQlzdHJ1Y3QgZm9ybWF0X2Rlc2Nfc3RydWN0ICpmb3Jt YXQsCj4gdWludDY0X3QgdGlsaW5nLAo+IC0JCQkJdW5zaWduZWQgKnNpemVfcmV0LCB1bnNpZ25l ZAo+ICpzdHJpZGVfcmV0KQo+ICsJCQkJdW5zaWduZWQgc3RyaWRlLCB1bnNpZ25lZCAqc2l6ZV9y ZXQsCj4gdW5zaWduZWQgKnN0cmlkZV9yZXQpCj4gIHsKPiAtCXVuc2lnbmVkIGludCB0aWxlX3dp ZHRoLCB0aWxlX2hlaWdodCwgc3RyaWRlLCBzaXplOwo+ICsJdW5zaWduZWQgaW50IHRpbGVfd2lk dGgsIHRpbGVfaGVpZ2h0LCBzaXplOwo+ICAJaW50IGJ5dGVfd2lkdGggPSB3aWR0aCAqIChmb3Jt YXQtPnBsYW5lX2JwcFswXSAvIDgpOwo+ICAKPiAgCWlndF9nZXRfZmJfdGlsZV9zaXplKGZkLCB0 aWxpbmcsIGZvcm1hdC0+cGxhbmVfYnBwWzBdLAo+ICZ0aWxlX3dpZHRoLCAmdGlsZV9oZWlnaHQp Owo+IEBAIC0yNzAsMTUgKzI3NCwxOCBAQCBzdGF0aWMgdm9pZCBjYWxjX2ZiX3NpemVfcGFja2Vk KGludCBmZCwgaW50Cj4gd2lkdGgsIGludCBoZWlnaHQsCj4gIAkJICogdGlsZWQuIEJ1dCB0aGVu IHRoYXQgZmFpbHVyZSBpcyBleHBlY3RlZC4KPiAgCQkgKi8KPiAgCj4gLQkJdiA9IGJ5dGVfd2lk dGg7Cj4gLQkJZm9yIChzdHJpZGUgPSA1MTI7IHN0cmlkZSA8IHY7IHN0cmlkZSAqPSAyKQo+IC0J CQk7Cj4gKwkJaWYgKCFzdHJpZGUpIHsKPiArCQkJdiA9IGJ5dGVfd2lkdGg7Cj4gKwkJCWZvciAo c3RyaWRlID0gNTEyOyBzdHJpZGUgPCB2OyBzdHJpZGUgKj0gMikKPiArCQkJCTsKPiArCQl9Cj4g IAo+ICAJCXYgPSBzdHJpZGUgKiBoZWlnaHQ7Cj4gIAkJZm9yIChzaXplID0gMTAyNCoxMDI0OyBz aXplIDwgdjsgc2l6ZSAqPSAyKQo+ICAJCQk7Cj4gIAl9IGVsc2Ugewo+IC0JCXN0cmlkZSA9IEFM SUdOKGJ5dGVfd2lkdGgsIHRpbGVfd2lkdGgpOwo+ICsJCWlmICghc3RyaWRlKQo+ICsJCQlzdHJp ZGUgPSBBTElHTihieXRlX3dpZHRoLCB0aWxlX3dpZHRoKTsKPiAgCQlzaXplID0gc3RyaWRlICog QUxJR04oaGVpZ2h0LCB0aWxlX2hlaWdodCk7Cj4gIAl9Cj4gIAo+IEBAIC0zMDYsOSArMzEzLDkg QEAgdm9pZCBpZ3RfY2FsY19mYl9zaXplKGludCBmZCwgaW50IHdpZHRoLCBpbnQKPiBoZWlnaHQs IHVpbnQzMl90IGRybV9mb3JtYXQsIHVpbnQ2NAo+ICAJaWd0X2Fzc2VydChmb3JtYXQpOwo+ICAK PiAgCWlmIChmb3JtYXQtPm51bV9wbGFuZXMgPiAxKQo+IC0JCWNhbGNfZmJfc2l6ZV9wbGFuYXIo ZmQsIHdpZHRoLCBoZWlnaHQsIGZvcm1hdCwKPiB0aWxpbmcsIHNpemVfcmV0LCBzdHJpZGVfcmV0 LCBOVUxMKTsKPiArCQljYWxjX2ZiX3NpemVfcGxhbmFyKGZkLCB3aWR0aCwgaGVpZ2h0LCBmb3Jt YXQsCj4gdGlsaW5nLCAwLCBzaXplX3JldCwgc3RyaWRlX3JldCwgTlVMTCk7Cj4gIAllbHNlCj4g LQkJY2FsY19mYl9zaXplX3BhY2tlZChmZCwgd2lkdGgsIGhlaWdodCwgZm9ybWF0LAo+IHRpbGlu Zywgc2l6ZV9yZXQsIHN0cmlkZV9yZXQpOwo+ICsJCWNhbGNfZmJfc2l6ZV9wYWNrZWQoZmQsIHdp ZHRoLCBoZWlnaHQsIGZvcm1hdCwKPiB0aWxpbmcsIDAsIHNpemVfcmV0LCBzdHJpZGVfcmV0KTsK PiAgfQo+ICAKPiAgLyoqCj4gQEAgLTM4MywxMCArMzkwLDEwIEBAIHN0YXRpYyBpbnQgY3JlYXRl X2JvX2Zvcl9mYihpbnQgZmQsIGludCB3aWR0aCwKPiBpbnQgaGVpZ2h0LAo+ICAJCXVuc2lnbmVk IGNhbGN1bGF0ZWRfc2l6ZSwgY2FsY3VsYXRlZF9zdHJpZGU7Cj4gIAo+ICAJCWlmIChmb3JtYXQt Pm51bV9wbGFuZXMgPiAxKQo+IC0JCQljYWxjX2ZiX3NpemVfcGxhbmFyKGZkLCB3aWR0aCwgaGVp Z2h0LAo+IGZvcm1hdCwgdGlsaW5nLAo+ICsJCQljYWxjX2ZiX3NpemVfcGxhbmFyKGZkLCB3aWR0 aCwgaGVpZ2h0LAo+IGZvcm1hdCwgdGlsaW5nLCBzdHJpZGUsCj4gIAkJCQkJICAgICZjYWxjdWxh dGVkX3NpemUsCj4gJmNhbGN1bGF0ZWRfc3RyaWRlLCBvZmZzZXRzKTsKPiAgCQllbHNlCj4gLQkJ CWNhbGNfZmJfc2l6ZV9wYWNrZWQoZmQsIHdpZHRoLCBoZWlnaHQsCj4gZm9ybWF0LCB0aWxpbmcs Cj4gKwkJCWNhbGNfZmJfc2l6ZV9wYWNrZWQoZmQsIHdpZHRoLCBoZWlnaHQsCj4gZm9ybWF0LCB0 aWxpbmcsIHN0cmlkZSwKPiAgCQkJCQkgICAgJmNhbGN1bGF0ZWRfc2l6ZSwKPiAmY2FsY3VsYXRl ZF9zdHJpZGUpOwo+ICAKPiAgCQlpZiAoc3RyaWRlID09IDApCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaWd0LWRldgo=