From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63EA06E69E for ; Fri, 21 Sep 2018 00:15:54 +0000 (UTC) Message-ID: <1537488953.2746.32.camel@intel.com> From: Paulo Zanoni Date: Thu, 20 Sep 2018 17:15:53 -0700 In-Reply-To: <20180719150415.935-8-ville.syrjala@linux.intel.com> References: <20180719150415.935-1-ville.syrjala@linux.intel.com> <20180719150415.935-8-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 08/25] lib/igt_fb: Use fb_blit_upload as the base class for fb_convert_blit_upload List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: RW0gUXVpLCAyMDE4LTA3LTE5IMOgcyAxODowMyArMDMwMCwgVmlsbGUgU3lyamFsYSBlc2NyZXZl dToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IAo+IGZiX2JsaXRfdXBsb2FkIGFscmVhZHkgaGFzIGV2ZXJ5dGhpbmcgd2UgbmVlZCwgc28g bGV0J3MgdXNlIGl0IGFzIHRoZQo+IGJhc2UgY2xhc3MgZm9yIGZiX2NvbnZlcnRfYmxpdF91cGxv YWQuCj4gCgpSZXZpZXdlZC1ieTogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5j b20+Cgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIuYyB8IDU3ICsrKysrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2xpYi9pZ3RfZmIuYyBiL2xpYi9pZ3RfZmIuYwo+IGluZGV4IDMyNGNiNjI0MTQ0Yi4uYjVlZWYx YTIzNTc2IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3RfZmIuYwo+ IEBAIC0xMzY4LDE1ICsxMzY4LDEyIEBAIHN0YXRpYyB2b2lkIGNyZWF0ZV9jYWlyb19zdXJmYWNl X19ndHQoaW50IGZkLAo+IHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICB9Cj4gIAo+ICBzdHJ1Y3QgZmJf Y29udmVydF9ibGl0X3VwbG9hZCB7Cj4gLQlpbnQgZmQ7Cj4gLQlzdHJ1Y3QgaWd0X2ZiICpmYjsK PiArCXN0cnVjdCBmYl9ibGl0X3VwbG9hZCBiYXNlOwo+ICAKPiAgCXN0cnVjdCB7Cj4gIAkJdWlu dDhfdCAqbWFwOwo+ICAJCXVuc2lnbmVkIHN0cmlkZSwgc2l6ZTsKPiAgCX0gcmdiMjQ7Cj4gLQo+ IC0Jc3RydWN0IGZiX2JsaXRfbGluZWFyIGxpbmVhcjsKPiAgfTsKPiAgCj4gIHN0YXRpYyB1aW50 OF90IGNsYW1wcmdiKGZsb2F0IHZhbCkKPiBAQCAtMTQwNCw4ICsxNDAxLDggQEAgc3RhdGljIHZv aWQgY29udmVydF9udjEyX3RvX3JnYjI0KHN0cnVjdCBpZ3RfZmIKPiAqZmIsIHN0cnVjdCBmYl9j b252ZXJ0X2JsaXRfdXBsbwo+ICAJaW50IGksIGo7Cj4gIAljb25zdCB1aW50OF90ICp5LCAqdXY7 Cj4gIAl1aW50OF90ICpyZ2IyNCA9IGJsaXQtPnJnYjI0Lm1hcDsKPiAtCXVuc2lnbmVkIHJnYjI0 X3N0cmlkZSA9IGJsaXQtPnJnYjI0LnN0cmlkZSwgcGxhbmFyX3N0cmlkZSA9Cj4gYmxpdC0+bGlu ZWFyLnN0cmlkZTsKPiAtCXVpbnQ4X3QgKmJ1ZiA9IG1hbGxvYyhibGl0LT5saW5lYXIuc2l6ZSk7 Cj4gKwl1bnNpZ25lZCByZ2IyNF9zdHJpZGUgPSBibGl0LT5yZ2IyNC5zdHJpZGUsIHBsYW5hcl9z dHJpZGUgPQo+IGJsaXQtPmJhc2UubGluZWFyLnN0cmlkZTsKPiArCXVpbnQ4X3QgKmJ1ZiA9IG1h bGxvYyhibGl0LT5iYXNlLmxpbmVhci5zaXplKTsKPiAgCXN0cnVjdCBpZ3RfbWF0NCBtID0gaWd0 X3ljYmNyX3RvX3JnYl9tYXRyaXgoZmItCj4gPmNvbG9yX2VuY29kaW5nLAo+ICAJCQkJCQkgICAg ZmItCj4gPmNvbG9yX3JhbmdlKTsKPiAgCj4gQEAgLTE0MTQsOSArMTQxMSw5IEBAIHN0YXRpYyB2 b2lkIGNvbnZlcnRfbnYxMl90b19yZ2IyNChzdHJ1Y3QgaWd0X2ZiCj4gKmZiLCBzdHJ1Y3QgZmJf Y29udmVydF9ibGl0X3VwbG8KPiAgCSAqIGl0J3MgZmFzdGVyIHRvIGNvcHkgdGhlIHdob2xlIEJP IHRvIGEgdGVtcG9yYXJ5IGJ1ZmZlcgo+IGFuZCBjb252ZXJ0Cj4gIAkgKiBmcm9tIHRoZXJlLgo+ ICAJICovCj4gLQlpZ3RfbWVtY3B5X2Zyb21fd2MoYnVmLCBibGl0LT5saW5lYXIubWFwLCBibGl0 LQo+ID5saW5lYXIuc2l6ZSk7Cj4gLQl5ID0gJmJ1ZltibGl0LT5saW5lYXIub2Zmc2V0c1swXV07 Cj4gLQl1diA9ICZidWZbYmxpdC0+bGluZWFyLm9mZnNldHNbMV1dOwo+ICsJaWd0X21lbWNweV9m cm9tX3djKGJ1ZiwgYmxpdC0+YmFzZS5saW5lYXIubWFwLCBibGl0LQo+ID5iYXNlLmxpbmVhci5z aXplKTsKPiArCXkgPSAmYnVmW2JsaXQtPmJhc2UubGluZWFyLm9mZnNldHNbMF1dOwo+ICsJdXYg PSAmYnVmW2JsaXQtPmJhc2UubGluZWFyLm9mZnNldHNbMV1dOwo+ICAKPiAgCWZvciAoaSA9IDA7 IGkgPCBmYi0+aGVpZ2h0IC8gMjsgaSsrKSB7Cj4gIAkJZm9yIChqID0gMDsgaiA8IGZiLT53aWR0 aCAvIDI7IGorKykgewo+IEBAIC0xNTEwLDExICsxNTA3LDExIEBAIHN0YXRpYyB2b2lkIGNvbnZl cnRfbnYxMl90b19yZ2IyNChzdHJ1Y3QKPiBpZ3RfZmIgKmZiLCBzdHJ1Y3QgZmJfY29udmVydF9i bGl0X3VwbG8KPiAgc3RhdGljIHZvaWQgY29udmVydF9yZ2IyNF90b19udjEyKHN0cnVjdCBpZ3Rf ZmIgKmZiLCBzdHJ1Y3QKPiBmYl9jb252ZXJ0X2JsaXRfdXBsb2FkICpibGl0KQo+ICB7Cj4gIAlp bnQgaSwgajsKPiAtCXVpbnQ4X3QgKnkgPSAmYmxpdC0+bGluZWFyLm1hcFtibGl0LT5saW5lYXIu b2Zmc2V0c1swXV07Cj4gLQl1aW50OF90ICp1diA9ICZibGl0LT5saW5lYXIubWFwW2JsaXQtPmxp bmVhci5vZmZzZXRzWzFdXTsKPiArCXVpbnQ4X3QgKnkgPSAmYmxpdC0+YmFzZS5saW5lYXIubWFw W2JsaXQtCj4gPmJhc2UubGluZWFyLm9mZnNldHNbMF1dOwo+ICsJdWludDhfdCAqdXYgPSAmYmxp dC0+YmFzZS5saW5lYXIubWFwW2JsaXQtCj4gPmJhc2UubGluZWFyLm9mZnNldHNbMV1dOwo+ICAJ Y29uc3QgdWludDhfdCAqcmdiMjQgPSBibGl0LT5yZ2IyNC5tYXA7Cj4gIAl1bnNpZ25lZCByZ2Iy NF9zdHJpZGUgPSBibGl0LT5yZ2IyNC5zdHJpZGU7Cj4gLQl1bnNpZ25lZCBwbGFuYXJfc3RyaWRl ID0gYmxpdC0+bGluZWFyLnN0cmlkZTsKPiArCXVuc2lnbmVkIHBsYW5hcl9zdHJpZGUgPSBibGl0 LT5iYXNlLmxpbmVhci5zdHJpZGU7Cj4gIAlzdHJ1Y3QgaWd0X21hdDQgbSA9IGlndF9yZ2JfdG9f eWNiY3JfbWF0cml4KGZiLQo+ID5jb2xvcl9lbmNvZGluZywKPiAgCQkJCQkJICAgIGZiLQo+ID5j b2xvcl9yYW5nZSk7Cj4gIAo+IEBAIC0xNjQxLDggKzE2MzgsOCBAQCBzdGF0aWMgdm9pZCBjb252 ZXJ0X3l1eXZfdG9fcmdiMjQoc3RydWN0IGlndF9mYgo+ICpmYiwgc3RydWN0IGZiX2NvbnZlcnRf YmxpdF91cGxvCj4gIAlpbnQgaSwgajsKPiAgCWNvbnN0IHVpbnQ4X3QgKnl1eXY7Cj4gIAl1aW50 OF90ICpyZ2IyNCA9IGJsaXQtPnJnYjI0Lm1hcDsKPiAtCXVuc2lnbmVkIHJnYjI0X3N0cmlkZSA9 IGJsaXQtPnJnYjI0LnN0cmlkZSwgeXV5dl9zdHJpZGUgPQo+IGJsaXQtPmxpbmVhci5zdHJpZGU7 Cj4gLQl1aW50OF90ICpidWYgPSBtYWxsb2MoYmxpdC0+bGluZWFyLnNpemUpOwo+ICsJdW5zaWdu ZWQgcmdiMjRfc3RyaWRlID0gYmxpdC0+cmdiMjQuc3RyaWRlLCB5dXl2X3N0cmlkZSA9Cj4gYmxp dC0+YmFzZS5saW5lYXIuc3RyaWRlOwo+ICsJdWludDhfdCAqYnVmID0gbWFsbG9jKGJsaXQtPmJh c2UubGluZWFyLnNpemUpOwo+ICAJc3RydWN0IGlndF9tYXQ0IG0gPSBpZ3RfeWNiY3JfdG9fcmdi X21hdHJpeChmYi0KPiA+Y29sb3JfZW5jb2RpbmcsCj4gIAkJCQkJCSAgICBmYi0KPiA+Y29sb3Jf cmFuZ2UpOwo+ICAKPiBAQCAtMTY1MSw3ICsxNjQ4LDcgQEAgc3RhdGljIHZvaWQgY29udmVydF95 dXl2X3RvX3JnYjI0KHN0cnVjdCBpZ3RfZmIKPiAqZmIsIHN0cnVjdCBmYl9jb252ZXJ0X2JsaXRf dXBsbwo+ICAJICogaXQncyBmYXN0ZXIgdG8gY29weSB0aGUgd2hvbGUgQk8gdG8gYSB0ZW1wb3Jh cnkgYnVmZmVyCj4gYW5kIGNvbnZlcnQKPiAgCSAqIGZyb20gdGhlcmUuCj4gIAkgKi8KPiAtCWln dF9tZW1jcHlfZnJvbV93YyhidWYsIGJsaXQtPmxpbmVhci5tYXAsIGJsaXQtCj4gPmxpbmVhci5z aXplKTsKPiArCWlndF9tZW1jcHlfZnJvbV93YyhidWYsIGJsaXQtPmJhc2UubGluZWFyLm1hcCwg YmxpdC0KPiA+YmFzZS5saW5lYXIuc2l6ZSk7Cj4gIAl5dXl2ID0gYnVmOwo+ICAKPiAgCWZvciAo aSA9IDA7IGkgPCBmYi0+aGVpZ2h0OyBpKyspIHsKPiBAQCAtMTY5OCwxMCArMTY5NSwxMCBAQCBz dGF0aWMgdm9pZCBjb252ZXJ0X3JnYjI0X3RvX3l1eXYoc3RydWN0Cj4gaWd0X2ZiICpmYiwgc3Ry dWN0IGZiX2NvbnZlcnRfYmxpdF91cGxvCj4gIAkJCQkgIGNvbnN0IHVuc2lnbmVkIGNoYXIgc3d6 WzRdKQo+ICB7Cj4gIAlpbnQgaSwgajsKPiAtCXVpbnQ4X3QgKnl1eXYgPSBibGl0LT5saW5lYXIu bWFwOwo+ICsJdWludDhfdCAqeXV5diA9IGJsaXQtPmJhc2UubGluZWFyLm1hcDsKPiAgCWNvbnN0 IHVpbnQ4X3QgKnJnYjI0ID0gYmxpdC0+cmdiMjQubWFwOwo+ICAJdW5zaWduZWQgcmdiMjRfc3Ry aWRlID0gYmxpdC0+cmdiMjQuc3RyaWRlOwo+IC0JdW5zaWduZWQgeXV5dl9zdHJpZGUgPSBibGl0 LT5saW5lYXIuc3RyaWRlOwo+ICsJdW5zaWduZWQgeXV5dl9zdHJpZGUgPSBibGl0LT5iYXNlLmxp bmVhci5zdHJpZGU7Cj4gIAlzdHJ1Y3QgaWd0X21hdDQgbSA9IGlndF9yZ2JfdG9feWNiY3JfbWF0 cml4KGZiLQo+ID5jb2xvcl9lbmNvZGluZywKPiAgCQkJCQkJICAgIGZiLQo+ID5jb2xvcl9yYW5n ZSk7Cj4gIAo+IEBAIC0xNzUwLDcgKzE3NDcsNyBAQCBzdGF0aWMgdm9pZCBjb252ZXJ0X3JnYjI0 X3RvX3l1eXYoc3RydWN0IGlndF9mYgo+ICpmYiwgc3RydWN0IGZiX2NvbnZlcnRfYmxpdF91cGxv Cj4gIHN0YXRpYyB2b2lkIGRlc3Ryb3lfY2Fpcm9fc3VyZmFjZV9fY29udmVydCh2b2lkICphcmcp Cj4gIHsKPiAgCXN0cnVjdCBmYl9jb252ZXJ0X2JsaXRfdXBsb2FkICpibGl0ID0gYXJnOwo+IC0J c3RydWN0IGlndF9mYiAqZmIgPSBibGl0LT5mYjsKPiArCXN0cnVjdCBpZ3RfZmIgKmZiID0gYmxp dC0+YmFzZS5mYjsKPiAgCj4gIAkvKiBDb252ZXJ0IGxpbmVhciByZ2IgYmFjayEgKi8KPiAgCXN3 aXRjaChmYi0+ZHJtX2Zvcm1hdCkgewo+IEBAIC0xNzcwLDEwICsxNzY3LDEwIEBAIHN0YXRpYyB2 b2lkCj4gZGVzdHJveV9jYWlyb19zdXJmYWNlX19jb252ZXJ0KHZvaWQgKmFyZykKPiAgCj4gIAlt dW5tYXAoYmxpdC0+cmdiMjQubWFwLCBibGl0LT5yZ2IyNC5zaXplKTsKPiAgCj4gLQlpZiAoYmxp dC0+bGluZWFyLmhhbmRsZSkKPiAtCQlmcmVlX2xpbmVhcl9tYXBwaW5nKGJsaXQtPmZkLCBibGl0 LT5mYiwgJmJsaXQtCj4gPmxpbmVhcik7Cj4gKwlpZiAoYmxpdC0+YmFzZS5saW5lYXIuaGFuZGxl KQo+ICsJCWZyZWVfbGluZWFyX21hcHBpbmcoYmxpdC0+YmFzZS5mZCwgYmxpdC0+YmFzZS5mYiwK PiAmYmxpdC0+YmFzZS5saW5lYXIpOwo+ICAJZWxzZQo+IC0JCWdlbV9tdW5tYXAoYmxpdC0+bGlu ZWFyLm1hcCwgZmItPnNpemUpOwo+ICsJCWdlbV9tdW5tYXAoYmxpdC0+YmFzZS5saW5lYXIubWFw LCBmYi0+c2l6ZSk7Cj4gIAo+ICAJZnJlZShibGl0KTsKPiAgCj4gQEAgLTE3ODUsOCArMTc4Miw4 IEBAIHN0YXRpYyB2b2lkIGNyZWF0ZV9jYWlyb19zdXJmYWNlX19jb252ZXJ0KGludAo+IGZkLCBz dHJ1Y3QgaWd0X2ZiICpmYikKPiAgCXN0cnVjdCBmYl9jb252ZXJ0X2JsaXRfdXBsb2FkICpibGl0 ID0gbWFsbG9jKHNpemVvZigqYmxpdCkpOwo+ICAJaWd0X2Fzc2VydChibGl0KTsKPiAgCj4gLQli bGl0LT5mZCA9IGZkOwo+IC0JYmxpdC0+ZmIgPSBmYjsKPiArCWJsaXQtPmJhc2UuZmQgPSBmZDsK PiArCWJsaXQtPmJhc2UuZmIgPSBmYjsKPiAgCWJsaXQtPnJnYjI0LnN0cmlkZSA9IEFMSUdOKGZi LT53aWR0aCAqIDQsIDE2KTsKPiAgCWJsaXQtPnJnYjI0LnNpemUgPSBBTElHTihibGl0LT5yZ2Iy NC5zdHJpZGUgKiBmYi0+aGVpZ2h0LAo+IHN5c2NvbmYoX1NDX1BBR0VTSVpFKSk7Cj4gIAlibGl0 LT5yZ2IyNC5tYXAgPSBtbWFwKE5VTEwsIGJsaXQtPnJnYjI0LnNpemUsIFBST1RfUkVBRCB8Cj4g UFJPVF9XUklURSwgTUFQX1BSSVZBVEUgfCBNQVBfQU5PTllNT1VTLCAtMSwgMCk7Cj4gQEAgLTE3 OTQsMTUgKzE3OTEsMTUgQEAgc3RhdGljIHZvaWQgY3JlYXRlX2NhaXJvX3N1cmZhY2VfX2NvbnZl cnQoaW50Cj4gZmQsIHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICAKPiAgCWlmIChmYi0+dGlsaW5nID09 IExPQ0FMX0k5MTVfRk9STUFUX01PRF9ZX1RJTEVEIHx8Cj4gIAkgICAgZmItPnRpbGluZyA9PSBM T0NBTF9JOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQpIHsKPiAtCQlzZXR1cF9saW5lYXJfbWFwcGlu ZyhmZCwgZmIsICZibGl0LT5saW5lYXIpOwo+ICsJCXNldHVwX2xpbmVhcl9tYXBwaW5nKGZkLCBm YiwgJmJsaXQtPmJhc2UubGluZWFyKTsKPiAgCX0gZWxzZSB7Cj4gLQkJYmxpdC0+bGluZWFyLmhh bmRsZSA9IDA7Cj4gLQkJYmxpdC0+bGluZWFyLm1hcCA9IGdlbV9tbWFwX19ndHQoZmQsIGZiLT5n ZW1faGFuZGxlLCAKPiBmYi0+c2l6ZSwKPiArCQlibGl0LT5iYXNlLmxpbmVhci5oYW5kbGUgPSAw Owo+ICsJCWJsaXQtPmJhc2UubGluZWFyLm1hcCA9IGdlbV9tbWFwX19ndHQoZmQsIGZiLQo+ID5n ZW1faGFuZGxlLCBmYi0+c2l6ZSwKPiAgCQkJCQkgICAgICBQUk9UX1JFQUQgfAo+IFBST1RfV1JJ VEUpOwo+IC0JCWlndF9hc3NlcnQoYmxpdC0+bGluZWFyLm1hcCk7Cj4gLQkJYmxpdC0+bGluZWFy LnN0cmlkZSA9IGZiLT5zdHJpZGU7Cj4gLQkJYmxpdC0+bGluZWFyLnNpemUgPSBmYi0+c2l6ZTsK PiAtCQltZW1jcHkoYmxpdC0+bGluZWFyLm9mZnNldHMsIGZiLT5vZmZzZXRzLCBzaXplb2YoZmIt Cj4gPm9mZnNldHMpKTsKPiArCQlpZ3RfYXNzZXJ0KGJsaXQtPmJhc2UubGluZWFyLm1hcCk7Cj4g KwkJYmxpdC0+YmFzZS5saW5lYXIuc3RyaWRlID0gZmItPnN0cmlkZTsKPiArCQlibGl0LT5iYXNl LmxpbmVhci5zaXplID0gZmItPnNpemU7Cj4gKwkJbWVtY3B5KGJsaXQtPmJhc2UubGluZWFyLm9m ZnNldHMsIGZiLT5vZmZzZXRzLAo+IHNpemVvZihmYi0+b2Zmc2V0cykpOwo+ICAJfQo+ICAKPiAg CS8qIENvbnZlcnQgdG8gbGluZWFyIHJnYiEgKi8KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pZ3QtZGV2Cg==