From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D5D76E053 for ; Fri, 21 Sep 2018 23:48:57 +0000 (UTC) Message-ID: <1537573736.3945.55.camel@intel.com> From: Paulo Zanoni Date: Fri, 21 Sep 2018 16:48:56 -0700 In-Reply-To: <20180719150415.935-20-ville.syrjala@linux.intel.com> References: <20180719150415.935-1-ville.syrjala@linux.intel.com> <20180719150415.935-20-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 20/25] lib/igt_fb: Refactor blitter usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville Syrjala , igt-dev@lists.freedesktop.org List-ID: RW0gUXVpLCAyMDE4LTA3LTE5IMOgcyAxODowNCArMDMwMCwgVmlsbGUgU3lyamFsYSBlc2NyZXZl dToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+IAo+IERlZHVwbGljYXRlIHRoZSBibGl0dGVyIGNvZGUuCgpSZXZpZXdlZC1ieTogUGF1bG8g WmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZp bGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGxp Yi9pZ3RfZmIuYyB8IDYyICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tLQo+IC0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygr KSwgMzMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3RfZmIuYyBiL2xpYi9p Z3RfZmIuYwo+IGluZGV4IDIzZjUzY2FhMGFkMi4uYTA4NTkyMzBmMzdmIDEwMDY0NAo+IC0tLSBh L2xpYi9pZ3RfZmIuYwo+ICsrKyBiL2xpYi9pZ3RfZmIuYwo+IEBAIC0xMjA2LDMyICsxMjA2LDQ0 IEBAIHN0cnVjdCBmYl9ibGl0X3VwbG9hZCB7Cj4gIAlzdHJ1Y3QgZmJfYmxpdF9saW5lYXIgbGlu ZWFyOwo+ICB9Owo+ICAKPiArc3RhdGljIHZvaWQgYmxpdGNvcHkoY29uc3Qgc3RydWN0IGlndF9m YiAqZHN0X2ZiLAo+ICsJCSAgICAgY29uc3Qgc3RydWN0IGlndF9mYiAqc3JjX2ZiKQo+ICt7Cj4g KwlpZ3RfYXNzZXJ0X2VxKGRzdF9mYi0+ZmQsIHNyY19mYi0+ZmQpOwo+ICsJaWd0X2Fzc2VydF9l cShkc3RfZmItPm51bV9wbGFuZXMsIHNyY19mYi0+bnVtX3BsYW5lcyk7Cj4gKwo+ICsJZm9yIChp bnQgaSA9IDA7IGkgPCBkc3RfZmItPm51bV9wbGFuZXM7IGkrKykgewo+ICsJCWlndF9hc3NlcnRf ZXEoZHN0X2ZiLT5wbGFuZV9icHBbaV0sIHNyY19mYi0KPiA+cGxhbmVfYnBwW2ldKTsKPiArCQlp Z3RfYXNzZXJ0X2VxKGRzdF9mYi0+cGxhbmVfd2lkdGhbaV0sIHNyY19mYi0KPiA+cGxhbmVfd2lk dGhbaV0pOwo+ICsJCWlndF9hc3NlcnRfZXEoZHN0X2ZiLT5wbGFuZV9oZWlnaHRbaV0sIHNyY19m Yi0KPiA+cGxhbmVfaGVpZ2h0W2ldKTsKPiArCj4gKwkJaWd0X2JsaXR0ZXJfZmFzdF9jb3B5X19y YXcoZHN0X2ZiLT5mZCwKPiArCQkJCQkgICBzcmNfZmItPmdlbV9oYW5kbGUsCj4gKwkJCQkJICAg c3JjX2ZiLT5vZmZzZXRzW2ldLAo+ICsJCQkJCSAgIHNyY19mYi0+c3RyaWRlc1tpXSwKPiArCQkJ CQkgICBpZ3RfZmJfbW9kX3RvX3RpbGluZyhzcmNfCj4gZmItPnRpbGluZyksCj4gKwkJCQkJICAg MCwgMCwgLyogc3JjX3gsIHNyY195ICovCj4gKwkJCQkJICAgZHN0X2ZiLT5wbGFuZV93aWR0aFtp XSwKPiBkc3RfZmItPnBsYW5lX2hlaWdodFtpXSwKPiArCQkJCQkgICBkc3RfZmItPnBsYW5lX2Jw cFtpXSwKPiArCQkJCQkgICBkc3RfZmItPmdlbV9oYW5kbGUsCj4gKwkJCQkJICAgZHN0X2ZiLT5v ZmZzZXRzW2ldLAo+ICsJCQkJCSAgIGRzdF9mYi0+c3RyaWRlc1tpXSwKPiArCQkJCQkgICBpZ3Rf ZmJfbW9kX3RvX3RpbGluZyhkc3RfCj4gZmItPnRpbGluZyksCj4gKwkJCQkJICAgMCwgMCAvKiBk c3RfeCwgZHN0X3kgKi8pOwo+ICsJfQo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBmcmVlX2xpbmVh cl9tYXBwaW5nKHN0cnVjdCBmYl9ibGl0X3VwbG9hZCAqYmxpdCkKPiAgewo+ICAJaW50IGZkID0g YmxpdC0+ZmQ7Cj4gIAlzdHJ1Y3QgaWd0X2ZiICpmYiA9IGJsaXQtPmZiOwo+ICAJc3RydWN0IGZi X2JsaXRfbGluZWFyICpsaW5lYXIgPSAmYmxpdC0+bGluZWFyOwo+IC0JdW5zaWduZWQgaW50IG9i al90aWxpbmcgPSBpZ3RfZmJfbW9kX3RvX3RpbGluZyhmYi0+dGlsaW5nKTsKPiAtCWludCBpOwo+ ICAKPiAgCWdlbV9tdW5tYXAobGluZWFyLT5tYXAsIGxpbmVhci0+ZmIuc2l6ZSk7Cj4gIAlnZW1f c2V0X2RvbWFpbihmZCwgbGluZWFyLT5mYi5nZW1faGFuZGxlLAo+ICAJCSAgICAgICBJOTE1X0dF TV9ET01BSU5fR1RULCAwKTsKPiAgCj4gLQlmb3IgKGkgPSAwOyBpIDwgZmItPm51bV9wbGFuZXM7 IGkrKykKPiAtCQlpZ3RfYmxpdHRlcl9mYXN0X2NvcHlfX3JhdyhmZCwKPiAtCQkJCQkgICBsaW5l YXItPmZiLmdlbV9oYW5kbGUsCj4gLQkJCQkJICAgbGluZWFyLT5mYi5vZmZzZXRzW2ldLAo+IC0J CQkJCSAgIGxpbmVhci0+ZmIuc3RyaWRlc1tpXSwKPiAtCQkJCQkgICBJOTE1X1RJTElOR19OT05F LAo+IC0JCQkJCSAgIDAsIDAsIC8qIHNyY194LCBzcmNfeSAqLwo+IC0JCQkJCSAgIGZiLT5wbGFu ZV93aWR0aFtpXSwgZmItCj4gPnBsYW5lX2hlaWdodFtpXSwKPiAtCQkJCQkgICBmYi0+cGxhbmVf YnBwW2ldLAo+IC0JCQkJCSAgIGZiLT5nZW1faGFuZGxlLAo+IC0JCQkJCSAgIGZiLT5vZmZzZXRz W2ldLAo+IC0JCQkJCSAgIGZiLT5zdHJpZGVzW2ldLAo+IC0JCQkJCSAgIG9ial90aWxpbmcsCj4g LQkJCQkJICAgMCwgMCAvKiBkc3RfeCwgZHN0X3kgKi8pOwo+ICsJYmxpdGNvcHkoZmIsICZsaW5l YXItPmZiKTsKPiAgCj4gIAlnZW1fc3luYyhmZCwgbGluZWFyLT5mYi5nZW1faGFuZGxlKTsKPiAg CWdlbV9jbG9zZShmZCwgbGluZWFyLT5mYi5nZW1faGFuZGxlKTsKPiBAQCAtMTI1MCw5ICsxMjYy LDYgQEAgc3RhdGljIHZvaWQgZGVzdHJveV9jYWlyb19zdXJmYWNlX19ibGl0KHZvaWQKPiAqYXJn KQo+ICAKPiAgc3RhdGljIHZvaWQgc2V0dXBfbGluZWFyX21hcHBpbmcoaW50IGZkLCBzdHJ1Y3Qg aWd0X2ZiICpmYiwgc3RydWN0Cj4gZmJfYmxpdF9saW5lYXIgKmxpbmVhcikKPiAgewo+IC0JdW5z aWduZWQgaW50IG9ial90aWxpbmcgPSBpZ3RfZmJfbW9kX3RvX3RpbGluZyhmYi0+dGlsaW5nKTsK PiAtCWludCBpOwo+IC0KPiAgCS8qCj4gIAkgKiBXZSBjcmVhdGUgYSBsaW5lYXIgQk8gdGhhdCB3 ZSdsbCBtYXAgZm9yIHRoZSBDUFUgdG8gd3JpdGUKPiB0byAodXNpbmcKPiAgCSAqIGNhaXJvKS4g VGhpcyBsaW5lYXIgYm8gd2lsbCBiZSB0aGVuIGJsaXR0ZWQgdG8gaXRzIGZpbmFsCj4gQEAgLTEy NzEsMjAgKzEyODAsNyBAQCBzdGF0aWMgdm9pZCBzZXR1cF9saW5lYXJfbWFwcGluZyhpbnQgZmQs Cj4gc3RydWN0IGlndF9mYiAqZmIsIHN0cnVjdCBmYl9ibGl0X2xpbmVhCj4gIAlnZW1fc2V0X2Rv bWFpbihmZCwgbGluZWFyLT5mYi5nZW1faGFuZGxlLAo+ICAJCQlJOTE1X0dFTV9ET01BSU5fR1RU LCAwKTsKPiAgCj4gLQlmb3IgKGkgPSAwOyBpIDwgZmItPm51bV9wbGFuZXM7IGkrKykKPiAtCQlp Z3RfYmxpdHRlcl9mYXN0X2NvcHlfX3JhdyhmZCwKPiAtCQkJCQkgICBmYi0+Z2VtX2hhbmRsZSwK PiAtCQkJCQkgICBmYi0+b2Zmc2V0c1tpXSwKPiAtCQkJCQkgICBmYi0+c3RyaWRlc1tpXSwKPiAt CQkJCQkgICBvYmpfdGlsaW5nLAo+IC0JCQkJCSAgIDAsIDAsIC8qIHNyY194LCBzcmNfeSAqLwo+ IC0JCQkJCSAgIGZiLT5wbGFuZV93aWR0aFtpXSwgZmItCj4gPnBsYW5lX2hlaWdodFtpXSwKPiAt CQkJCQkgICBmYi0+cGxhbmVfYnBwW2ldLAo+IC0JCQkJCSAgIGxpbmVhci0+ZmIuZ2VtX2hhbmRs ZSwKPiAtCQkJCQkgICBsaW5lYXItPmZiLm9mZnNldHNbaV0sCj4gLQkJCQkJICAgbGluZWFyLT5m Yi5zdHJpZGVzW2ldLAo+IC0JCQkJCSAgIEk5MTVfVElMSU5HX05PTkUsCj4gLQkJCQkJICAgMCwg MCAvKiBkc3RfeCwgZHN0X3kgKi8pOwo+ICsJYmxpdGNvcHkoJmxpbmVhci0+ZmIsIGZiKTsKPiAg Cj4gIAlnZW1fc3luYyhmZCwgbGluZWFyLT5mYi5nZW1faGFuZGxlKTsKPiAgCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1kZXYgbWFpbGluZyBsaXN0 CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=