public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tomasz Lis <tomasz.lis@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: bartosz.dunajski@intel.com
Subject: [igt-dev] [PATCH i-g-t v2 2/3] lib: Update surface state to set MOCS and coherency.
Date: Fri,  5 Oct 2018 20:04:35 +0200	[thread overview]
Message-ID: <1538762676-15259-3-git-send-email-tomasz.lis@intel.com> (raw)
In-Reply-To: <1538762676-15259-1-git-send-email-tomasz.lis@intel.com>

From: "Lis, Tomasz" <tomasz.lis@intel.com>

Having LLC cache enabled by MOCS is required to perform coherency tests.
Surface coherency type needs to be set as well for that test.

Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Winiarski <michal.winiarski@intel.com>

Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
---
 lib/gpu_cmds.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 556a94c..d9c6fa1 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -376,6 +376,9 @@ gen8_fill_surface_state(struct intel_batchbuffer *batch,
 	ss->ss2.width  = igt_buf_width(buf) - 1;
 	ss->ss3.pitch  = buf->stride - 1;
 
+	ss->ss1.memory_object_control = 2;
+	ss->ss5.coherency_type = 1;
+
 	ss->ss7.shader_chanel_select_r = 4;
 	ss->ss7.shader_chanel_select_g = 5;
 	ss->ss7.shader_chanel_select_b = 6;
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2018-10-05 18:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 18:04 [igt-dev] [PATCH i-g-t v2 0/3] Data Port Cache Coherency test Tomasz Lis
2018-10-05 18:04 ` [igt-dev] [PATCH i-g-t v2 1/3] lib: Separated emit part of gpgpu_fill Tomasz Lis
2018-10-24 14:49   ` Kalamarz, Lukasz
2018-10-05 18:04 ` Tomasz Lis [this message]
2018-10-05 18:04 ` [igt-dev] [PATCH i-g-t v2 3/3] igt: Add a test for Data Port Coherency Tomasz Lis
2018-10-05 19:59 ` [igt-dev] ✓ Fi.CI.BAT: success for Data Port Cache Coherency test Patchwork
2018-10-06  2:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1538762676-15259-3-git-send-email-tomasz.lis@intel.com \
    --to=tomasz.lis@intel.com \
    --cc=bartosz.dunajski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox