public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org
Cc: jyoti.r.yadav@intel.com, anshuman.gupta@intel.com
Subject: [igt-dev] [PATCH i-g-t 4/5] tests/pm_dc: Added test for DC5 during DPMS
Date: Thu,  7 Mar 2019 23:00:16 +0530	[thread overview]
Message-ID: <1551979817-26123-5-git-send-email-anshuman.gupta@intel.com> (raw)
In-Reply-To: <1551979817-26123-1-git-send-email-anshuman.gupta@intel.com>

From: Jyoti Yadav <jyoti.r.yadav@intel.com>

Added new subtest for DC5 entry during DPMS on/off cycle.
During DPMS on/off cycle DC5 counter is incremented.

v2: Rename the subtest with meaningful name.
v3: Rebased.
v4: Addressed review comments by removing leftover code
    cleanup().
v5: Addressed the review comment by removing redundant
    read_dc_counter() suggested by Imre.
    Listing actual change in patch set changelog to make review easier.
v6: Three way patch applied, no functional change.
v7: Disabling runtime suspend for the platfrom which support, DC9.
    rebased due to test name pm_dc changed to i915_pm_dc, aligning to
    other PM tests.

Signed-off-by: Jyoti Yadav <jyoti.r.yadav@intel.com>
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_dc.c | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)

diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index cf79790..813e38f 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -46,6 +46,7 @@ typedef struct {
 	enum psr_mode op_psr_mode;
 	drmModeModeInfo *mode;
 	igt_output_t *output;
+	bool runtime_suspend_disabled;
 } data_t;
 
 bool dc_state_wait_entry(int, int, int);
@@ -173,6 +174,33 @@ static void test_dc_state_psr(data_t *data, int dc_flag)
 	cleanup(data);
 }
 
+static void dpms_off_on(data_t *data)
+{
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+					   DRM_MODE_DPMS_OFF);
+	}
+	if (!data->runtime_suspend_disabled)
+		igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
+	for (int i = 0; i < data->display.n_outputs; i++) {
+		kmstest_set_connector_dpms(data->drm_fd, data->display.outputs[i].config.connector,
+				   DRM_MODE_DPMS_ON);
+	}
+	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_ACTIVE));
+}
+
+static void test_dc_state_dpms(data_t *data, int dc_flag)
+{
+	uint32_t dc_counter;
+
+	dc_counter = read_dc_counter(data->drm_fd, dc_flag);
+	if (IS_BROXTON(data->devid) && IS_GEMINILAKE(data->devid) &&
+		AT_LEAST_GEN(data->devid, 11))
+		data->runtime_suspend_disabled = igt_disable_runtime_pm();
+	dpms_off_on(data);
+	check_dc_counter(data->drm_fd, dc_flag, dc_counter);
+}
+
 int main(int argc, char *argv[])
 {
 	bool has_runtime_pm;
@@ -189,6 +217,7 @@ int main(int argc, char *argv[])
 		has_runtime_pm = igt_setup_runtime_pm();
 		igt_info("Runtime PM support: %d\n", has_runtime_pm);
 		igt_require(has_runtime_pm);
+		data.runtime_suspend_disabled = false;
 		igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
 		igt_display_require(&data.display, data.drm_fd);
 	}
@@ -208,6 +237,11 @@ int main(int argc, char *argv[])
 			      "Sink does not support PSR\n");
 		test_dc_state_psr(&data, CHECK_DC6);
 	}
+
+	igt_subtest("dc5-dpms") {
+		test_dc_state_dpms(&data, CHECK_DC5);
+	}
+
 	igt_fixture {
 		close(data.debugfs_fd);
 		display_fini(&data);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-03-07 17:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-07 17:30 [igt-dev] [PATCH i-g-t 0/5] DC states igt tests patch series v7 Anshuman Gupta
2019-03-07 17:30 ` [igt-dev] [PATCH i-g-t 1/5] lib/igt_pm: igt lib helper routines to support DC5/6 tests Anshuman Gupta
2019-03-07 17:30 ` [igt-dev] [PATCH i-g-t 2/5] tests/pm_dc: Added new test to verify Display C States Anshuman Gupta
2019-03-07 17:30 ` [igt-dev] [PATCH i-g-t 3/5] tests/pm_dc: Added test for DC6 during PSR Anshuman Gupta
2019-03-07 17:30 ` Anshuman Gupta [this message]
2019-03-07 17:30 ` [Intel-gfx] [PATCH i-g-t 5/5] tests/pm_dc: Added test for DC6 during DPMS Anshuman Gupta
2019-03-07 18:25 ` [igt-dev] ✓ Fi.CI.BAT: success for DC states igt tests patch series (rev4) Patchwork
2019-03-07 19:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551979817-26123-5-git-send-email-anshuman.gupta@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jyoti.r.yadav@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox