From: Uma Shankar <uma.shankar@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: ville.syrjala@intel.com, maarten.lankhorst@intel.com
Subject: [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test
Date: Fri, 22 Mar 2019 19:47:33 +0530 [thread overview]
Message-ID: <1553264253-19807-1-git-send-email-uma.shankar@intel.com> (raw)
Due to Gamma/Degamma limitation with precision (lack of
exact 1.0 representation) due to ABI restriction, applying
linear gamma affects crc. This patch fixes the same by making
ctm tests independant of gamma/degamma.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108147
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
tests/kms_color.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index decf3c2..0656682 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -662,13 +662,9 @@ static bool test_pipe_ctm(data_t *data,
0.0, 1.0, 0.0,
0.0, 0.0, 1.0
};
- double *degamma_linear, *gamma_linear;
igt_output_t *output;
bool ret = true;
- degamma_linear = generate_table(data->degamma_lut_size, 1.0);
- gamma_linear = generate_table(data->gamma_lut_size, 1.0);
-
for_each_valid_output_on_pipe(&data->display, primary->pipe->pipe, output) {
drmModeModeInfo *mode;
struct igt_fb fb_modeset, fb;
@@ -696,8 +692,6 @@ static bool test_pipe_ctm(data_t *data,
igt_assert(fb_modeset_id);
igt_plane_set_fb(primary, &fb_modeset);
- set_degamma(data, primary->pipe, degamma_linear);
- set_gamma(data, primary->pipe, gamma_linear);
disable_ctm(primary->pipe);
igt_display_commit(&data->display);
@@ -725,9 +719,6 @@ static bool test_pipe_ctm(data_t *data,
igt_output_set_pipe(output, PIPE_NONE);
}
- free(degamma_linear);
- free(gamma_linear);
-
return ret;
}
--
1.9.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2019-03-22 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:17 Uma Shankar [this message]
2019-03-22 14:11 ` [igt-dev] [PATCH i-g-t] tests/kms_color: Fix CRC mismatch issues with ctm test Ville Syrjälä
2019-03-22 15:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-03-23 14:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553264253-19807-1-git-send-email-uma.shankar@intel.com \
--to=uma.shankar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=maarten.lankhorst@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox