public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 2/2] tests/i915/i915_pm_rpm: modeset-pc8-residency-stress
Date: Wed, 27 Mar 2019 15:25:23 +0530	[thread overview]
Message-ID: <1553680523-24273-3-git-send-email-anshuman.gupta@intel.com> (raw)
In-Reply-To: <1553680523-24273-1-git-send-email-anshuman.gupta@intel.com>

Introduced pc8_needs_screen_off flag in order to differentiate
between HASWELL/BROADWELL and AT_LEAST_GEN9. GEN9 onwards
PC8+ residency does't require display to be turned on.

v3:Removed pc8_needs_screen_off from mode_set_data structure,
   made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram]
   Made modeset_subtest() to tests PC8+ residency after enabling a screen,
   earlier it expects PC8+ residency to stop on HSW/BDW.

Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_rpm.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 7e0c370..55151e8 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -900,8 +900,12 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		igt_require(enable_one_screen_with_type(&ms_data, type));
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_active());
-		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(!pc8_plus_residency_changed(5));
+		if (wait_flags & WAIT_PC8_RES && pc8_needs_screen_off)
+			if (pc8_needs_screen_off)
+				igt_assert(!pc8_plus_residency_changed(5));
+			else
+				igt_assert(pc8_plus_residency_changed(5));
+
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 	}
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2019-03-27  9:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27  9:55 [igt-dev] [PATCH i-g-t v3 0/2] Enabling PC8+ residency for all GEN9+ platforms v3 Anshuman Gupta
2019-03-27  9:55 ` [igt-dev] [PATCH i-g-t v3 1/2] tests/i915/i915_pm_rpm: Enable PC8+ residency test for all Gen9+ Anshuman Gupta
2019-03-27 12:28   ` Ramalingam C
2019-03-27 13:45     ` Gupta, Anshuman
2019-03-27 15:36       ` Ramalingam C
2019-03-27  9:55 ` Anshuman Gupta [this message]
2019-03-27 12:32   ` [igt-dev] [PATCH i-g-t v3 2/2] tests/i915/i915_pm_rpm: modeset-pc8-residency-stress Ramalingam C
2019-03-27 11:20 ` [igt-dev] ✓ Fi.CI.BAT: success for Enabling PC8+ residency for all GEN9+ platforms (rev3) Patchwork
2019-03-27 20:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553680523-24273-3-git-send-email-anshuman.gupta@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox