From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v4 2/2] tests/i915/i915_pm_rpm: modeset-pc8-residency-stress
Date: Thu, 28 Mar 2019 18:21:08 +0530 [thread overview]
Message-ID: <1553777468-11611-3-git-send-email-anshuman.gupta@intel.com> (raw)
In-Reply-To: <1553777468-11611-1-git-send-email-anshuman.gupta@intel.com>
Introduced pc8_needs_screen_off flag in order to differentiate
between HASWELL/BROADWELL and AT_LEAST_GEN9. GEN9 onwards
PC8+ residency does't require display to be turned on.
v3:Removed pc8_needs_screen_off from mode_set_data structure,
made it global, aligning to has_pc8 and has_runtime_pm globals. [Ram]
Made modeset_subtest() to tests PC8+ residency after enabling a screen,
earlier it expects PC8+ residency to stop on HSW/BDW.
v4:Fixed conditional code for pc8_needs_screen_off. [Ram]
Used macros for timeout values, given to PC8+ residency check function. [Ram]
Changed the screen on timeout to check pc8+ residency to 10 seconds.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
tests/i915/i915_pm_rpm.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 70e8ac7..092ee64 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -907,7 +907,7 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
if (wait_flags & WAIT_STATUS)
igt_assert(wait_for_suspended());
if (wait_flags & WAIT_PC8_RES)
- igt_assert(pc8_plus_residency_changed(30));
+ igt_assert(pc8_plus_residency_changed(TIME_OUT_SEC_30));
if (wait_flags & WAIT_EXTRA)
sleep(5);
@@ -917,7 +917,13 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
if (wait_flags & WAIT_STATUS)
igt_assert(wait_for_active());
if (wait_flags & WAIT_PC8_RES)
- igt_assert(!pc8_plus_residency_changed(5));
+ if (pc8_needs_screen_off)
+ igt_assert(!pc8_plus_residency_changed
+ (TIME_OUT_SEC_5));
+ else
+ igt_assert(pc8_plus_residency_changed
+ (TIME_OUT_SEC_10));
+
if (wait_flags & WAIT_EXTRA)
sleep(5);
}
--
2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-28 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 12:51 [igt-dev] [PATCH i-g-t v4 0/2] Enabling PC8+ residency for all GEN9+ platforms v4 Anshuman Gupta
2019-03-28 12:51 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/i915/i915_pm_rpm: Enable PC8+ residency test for all Gen9+ Anshuman Gupta
2019-03-28 12:51 ` Anshuman Gupta [this message]
2019-03-28 14:45 ` [igt-dev] ✗ Fi.CI.BAT: failure for Enabling PC8+ residency for all GEN9+ platforms (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553777468-11611-3-git-send-email-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox